From: Vladimir Zapolskiy <vz@mleia.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
davem@davemloft.net, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH] crypto: s5p-sss - Use consistent indentation for variables and members
Date: Sat, 28 May 2016 22:33:36 +0300 [thread overview]
Message-ID: <5749F290.1010205@mleia.com> (raw)
In-Reply-To: <1464349780-27674-1-git-send-email-k.kozlowski@samsung.com>
Hi Krzysztof,
On 27.05.2016 14:49, Krzysztof Kozlowski wrote:
> Bring some consistency by:
> 1. Replacing fixed-space indentation of structure members with just
> tabs.
> 2. Remove indentation in declaration of local variable between type and
> name. Driver was mixing usage of such indentation and lack of it.
> When removing indentation, reorder variables in
> reversed-christmas-tree order with first variables being initialized
> ones.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
it looks like a trivial and nice change, thank you.
Acked-by: Vladimir Zapolskiy <vz@mleia.com>
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Zapolskiy <vz@mleia.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
davem@davemloft.net, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH] crypto: s5p-sss - Use consistent indentation for variables and members
Date: Sat, 28 May 2016 22:33:36 +0300 [thread overview]
Message-ID: <5749F290.1010205@mleia.com> (raw)
In-Reply-To: <1464349780-27674-1-git-send-email-k.kozlowski@samsung.com>
Hi Krzysztof,
On 27.05.2016 14:49, Krzysztof Kozlowski wrote:
> Bring some consistency by:
> 1. Replacing fixed-space indentation of structure members with just
> tabs.
> 2. Remove indentation in declaration of local variable between type and
> name. Driver was mixing usage of such indentation and lack of it.
> When removing indentation, reorder variables in
> reversed-christmas-tree order with first variables being initialized
> ones.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
it looks like a trivial and nice change, thank you.
Acked-by: Vladimir Zapolskiy <vz@mleia.com>
--
With best wishes,
Vladimir
next prev parent reply other threads:[~2016-05-28 19:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 11:49 [PATCH] crypto: s5p-sss - Use consistent indentation for variables and members Krzysztof Kozlowski
2016-05-28 19:33 ` Vladimir Zapolskiy [this message]
2016-05-28 19:33 ` Vladimir Zapolskiy
2016-05-31 10:19 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5749F290.1010205@mleia.com \
--to=vz@mleia.com \
--cc=b.zolnierkie@samsung.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=k.kozlowski@samsung.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.