From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
linux-kernel@vger.kernel.org
Cc: devicetree@vger.kernel.org, Kukjin Kim <kgene@kernel.org>,
Kumar Gala <galak@codeaurora.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
linux-samsung-soc@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: exynos: Add TMU nodes regulator supply for Peach boards
Date: Wed, 01 Jun 2016 10:50:25 +0200 [thread overview]
Message-ID: <574EA1D1.6020606@samsung.com> (raw)
In-Reply-To: <1464731280-24588-1-git-send-email-javier@osg.samsung.com>
On 05/31/2016 11:48 PM, Javier Martinez Canillas wrote:
> The Exynos5800 Peach Pi and Exynos5420 Peach Pit Chromebooks have the
> LDO10 1.8V output connected to the VDD18_TS{01,23,4} Exynos SoC pins.
>
> Add this regulator as the input supply of the Thermal Management Unit
> channels and also remove the always-on property since all the devices
> using LDO10 as input supply are now defined.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
> arch/arm/boot/dts/exynos5420-peach-pit.dts | 21 ++++++++++++++++++++-
> arch/arm/boot/dts/exynos5800-peach-pi.dts | 21 ++++++++++++++++++++-
> 2 files changed, 40 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> index c1247402cb17..a55760b5fa82 100644
> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> @@ -425,7 +425,6 @@
> regulator-name = "vdd_ldo10";
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> - regulator-always-on;
> regulator-state-mem {
> regulator-off-in-suspend;
> };
> @@ -924,6 +923,26 @@
> assigned-clock-parents = <&clock CLK_FIN_PLL>;
> };
>
> +&tmu_cpu0 {
> + vtmu-supply = <&ldo10_reg>;
> +};
> +
> +&tmu_cpu1 {
> + vtmu-supply = <&ldo10_reg>;
> +};
> +
> +&tmu_cpu2 {
> + vtmu-supply = <&ldo10_reg>;
> +};
> +
> +&tmu_cpu3 {
> + vtmu-supply = <&ldo10_reg>;
> +};
> +
> +&tmu_gpu {
> + vtmu-supply = <&ldo10_reg>;
> +};
> +
Here and for Peach Pi please put the nodes in alphabetical order.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: exynos: Add TMU nodes regulator supply for Peach boards
Date: Wed, 01 Jun 2016 10:50:25 +0200 [thread overview]
Message-ID: <574EA1D1.6020606@samsung.com> (raw)
In-Reply-To: <1464731280-24588-1-git-send-email-javier@osg.samsung.com>
On 05/31/2016 11:48 PM, Javier Martinez Canillas wrote:
> The Exynos5800 Peach Pi and Exynos5420 Peach Pit Chromebooks have the
> LDO10 1.8V output connected to the VDD18_TS{01,23,4} Exynos SoC pins.
>
> Add this regulator as the input supply of the Thermal Management Unit
> channels and also remove the always-on property since all the devices
> using LDO10 as input supply are now defined.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
> arch/arm/boot/dts/exynos5420-peach-pit.dts | 21 ++++++++++++++++++++-
> arch/arm/boot/dts/exynos5800-peach-pi.dts | 21 ++++++++++++++++++++-
> 2 files changed, 40 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> index c1247402cb17..a55760b5fa82 100644
> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
> @@ -425,7 +425,6 @@
> regulator-name = "vdd_ldo10";
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> - regulator-always-on;
> regulator-state-mem {
> regulator-off-in-suspend;
> };
> @@ -924,6 +923,26 @@
> assigned-clock-parents = <&clock CLK_FIN_PLL>;
> };
>
> +&tmu_cpu0 {
> + vtmu-supply = <&ldo10_reg>;
> +};
> +
> +&tmu_cpu1 {
> + vtmu-supply = <&ldo10_reg>;
> +};
> +
> +&tmu_cpu2 {
> + vtmu-supply = <&ldo10_reg>;
> +};
> +
> +&tmu_cpu3 {
> + vtmu-supply = <&ldo10_reg>;
> +};
> +
> +&tmu_gpu {
> + vtmu-supply = <&ldo10_reg>;
> +};
> +
Here and for Peach Pi please put the nodes in alphabetical order.
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-06-01 8:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 21:48 [PATCH] ARM: dts: exynos: Add TMU nodes regulator supply for Peach boards Javier Martinez Canillas
2016-05-31 21:48 ` Javier Martinez Canillas
2016-05-31 21:48 ` Javier Martinez Canillas
2016-06-01 8:50 ` Krzysztof Kozlowski [this message]
2016-06-01 8:50 ` Krzysztof Kozlowski
2016-06-01 13:19 ` Javier Martinez Canillas
2016-06-01 13:19 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574EA1D1.6020606@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.