[meta-python][PATCHv3 0/3] Tornado 4.3 is missing python2 RDEPENDS

[meta-python][PATCHv3 0/3] Tornado 4.3 is missing python2 RDEPENDS

[S. Lockwood-Childs]

Tornado 4.3 needs a couple more backport modules to prevent tornado/gen.py
from bombing on import errors when running on python2 rather than python3.4

  ImportError: No module named singledispatch

  ImportError: No module named backports_abc

S. Lockwood-Childs (3):
  python-backports-abc: initial recipe for version 0.4
  python-singledispatch: initial recipe for version 3.4.0.3
  python-tornado: add missing python2 runtime deps

 .../python/python-backports-abc_0.4.bb                 | 18 ++++++++++++++++++
 .../python/python-singledispatch_3.4.0.3.bb            | 13 +++++++++++++
 .../recipes-devtools/python/python-tornado_4.3.bb      |  2 +-
 3 files changed, 32 insertions(+), 1 deletion(-)
 create mode 100644 meta-python/recipes-devtools/python/python-backports-abc_0.4.bb
 create mode 100644 meta-python/recipes-devtools/python/python-singledispatch_3.4.0.3.bb

-- 
1.9.1

[meta-python][PATCHv3 1/3] python-backports-abc: initial recipe for version 0.4 RDEPENDS

[S. Lockwood-Childs]

Tornado 4.3 needs a couple more backport modules to prevent tornado/gen.py
from bombing on import errors when running on python2 rather than python3.4

  ImportError: No module named backports_abc

Signed-off-by: S. Lockwood-Childs <sjl@vctlabs.com>
---
 .../python/python-backports-abc_0.4.bb                 | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 meta-python/recipes-devtools/python/python-backports-abc_0.4.bb

diff --git a/meta-python/recipes-devtools/python/python-backports-abc_0.4.bb b/meta-python/recipes-devtools/python/python-backports-abc_0.4.bb
new file mode 100644
index 0000000..6a4d267
--- /dev/null
+++ b/meta-python/recipes-devtools/python/python-backports-abc_0.4.bb
@@ -0,0 +1,18 @@
+SUMMARY = "collections.abc from Python 3.4"
+DESCRIPTION = "A backport of recent additions to the 'collections.abc' module"
+
+LICENSE = "PSF"
+LIC_FILES_CHKSUM = "file://${WORKDIR}/LICENSE;md5=dd98d01d471fac8d8dbdd975229dba03"
+
+# pypi package doesn't have valid entry for license
+SRC_URI += "https://raw.githubusercontent.com/cython/backports_abc/master/LICENSE;name=license"
+
+SRC_URI[md5sum] = "0b65a216ce9dc9c1a7e20a729dd7c05b"
+SRC_URI[sha256sum] = "8b3e4092ba3d541c7a2f9b7d0d9c0275b21c6a01c53a61c731eba6686939d0a5"
+SRC_URI[license.md5sum] = "dd98d01d471fac8d8dbdd975229dba03"
+SRC_URI[license.sha256sum] = "0a4f3b38055f50f047a42521568fa6ddb9a5976c2884f6ae138796d0f71150ca"
+
+
+
+PYPI_PACKAGE = "backports_abc"
+inherit pypi setuptools
-- 
1.9.1

[meta-python][PATCHv3 2/3] python-singledispatch: initial recipe for version 3.4.0.3

[S. Lockwood-Childs]

Tornado 4.3 needs a couple more backport modules to prevent tornado/gen.py
from bombing on import errors when running on python2 rather than python3.4

  ImportError: No module named singledispatch

Signed-off-by: S. Lockwood-Childs <sjl@vctlabs.com>
---
 .../python/python-singledispatch_3.4.0.3.bb                 | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 meta-python/recipes-devtools/python/python-singledispatch_3.4.0.3.bb

diff --git a/meta-python/recipes-devtools/python/python-singledispatch_3.4.0.3.bb b/meta-python/recipes-devtools/python/python-singledispatch_3.4.0.3.bb
new file mode 100644
index 0000000..87f46e5
--- /dev/null
+++ b/meta-python/recipes-devtools/python/python-singledispatch_3.4.0.3.bb
@@ -0,0 +1,13 @@
+SUMMARY = "functools.singledispatch from Python 3.4"
+DESCRIPTION = "PEP 443 proposed to expose a mechanism in the functools standard library module \
+in Python 3.4 that provides a simple form of generic programming known as single-dispatch \
+generic functions.  This library is a backport of this functionality to Python 2.6 - 3.3"
+
+LICENSE = "Apache-2.0"
+LIC_FILES_CHKSUM = "file://README.rst;md5=ee3cd67264adc7eb07981f3644dc17dc"
+
+SRC_URI[md5sum] = "af2fc6a3d6cc5a02d0bf54d909785fcb"
+SRC_URI[sha256sum] = "5b06af87df13818d14f08a028e42f566640aef80805c3b50c5056b086e3c2b9c"
+
+PYPI_PACKAGE = "singledispatch"
+inherit pypi setuptools
-- 
1.9.1

[meta-python][PATCHv3 3/3] python-tornado: add missing python2 runtime deps

[S. Lockwood-Childs]

Tornado 4.3 needs backports_abc and singledispatch backport modules
at runtime to prevent tornado/gen.py from bombing on import errors
when running on python2 rather than python3.4

Signed-off-by: S. Lockwood-Childs <sjl@vctlabs.com>
---
 meta-python/recipes-devtools/python/python-tornado_4.3.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-python/recipes-devtools/python/python-tornado_4.3.bb b/meta-python/recipes-devtools/python/python-tornado_4.3.bb
index 55a48b8..d30f88f 100644
--- a/meta-python/recipes-devtools/python/python-tornado_4.3.bb
+++ b/meta-python/recipes-devtools/python/python-tornado_4.3.bb
@@ -1,3 +1,3 @@
 inherit pypi setuptools
 require python-tornado.inc
-RDEPENDS_${PN} += "${PYTHON_PN}-backports-ssl"
+RDEPENDS_${PN} += "${PYTHON_PN}-backports-ssl ${PYTHON_P}-backports-abc ${PYTHON_PN}-singledispatch"
-- 
1.9.1

Re: [meta-python][PATCHv3 3/3] python-tornado: add missing python2 runtime deps

[S. Lockwood-Childs]

On Thu, Jun 02, 2016 at 11:28:01AM -0700, S. Lockwood-Childs wrote:
> +RDEPENDS_${PN} += "${PYTHON_PN}-backports-ssl ${PYTHON_P}-backports-abc ${PYTHON_PN}-singledispatch"

Well that's really fun -- I managed to pick the version of the patch with the
typo when splitting it up. Do I have to send the whole series again to add one
letter (PYTHON_P -> PYTHON_PN) ?

Re: [meta-python][PATCHv3 3/3] python-tornado: add missing python2 runtime deps

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 588 bytes --]

On Thu, Jun 02, 2016 at 11:58:56AM -0700, S. Lockwood-Childs wrote:
> On Thu, Jun 02, 2016 at 11:28:01AM -0700, S. Lockwood-Childs wrote:
> > +RDEPENDS_${PN} += "${PYTHON_PN}-backports-ssl ${PYTHON_P}-backports-abc ${PYTHON_PN}-singledispatch"
> 
> Well that's really fun -- I managed to pick the version of the patch with the
> typo when splitting it up. Do I have to send the whole series again to add one
> letter (PYTHON_P -> PYTHON_PN) ?

I'll try not to forget to change it when cherry-picking to master-next.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [meta-python][PATCHv3 1/3] python-backports-abc: initial recipe for version 0.4 RDEPENDS

[Gary Thomas]

On 06/02/2016 08:26 PM, S. Lockwood-Childs wrote:
> Tornado 4.3 needs a couple more backport modules to prevent tornado/gen.py
> from bombing on import errors when running on python2 rather than python3.4
>
>    ImportError: No module named backports_abc
>
> Signed-off-by: S. Lockwood-Childs <sjl@vctlabs.com>

In my mind, this patch (and its sibling) don't really have anything to to
with Tornado, they are just new packages being added to make that package happy.
I'd prefer to see a commit message that reflects what this package is as well
as why it is being added.

> ---
>   .../python/python-backports-abc_0.4.bb                 | 18 ++++++++++++++++++
>   1 file changed, 18 insertions(+)
>   create mode 100644 meta-python/recipes-devtools/python/python-backports-abc_0.4.bb
>
> diff --git a/meta-python/recipes-devtools/python/python-backports-abc_0.4.bb b/meta-python/recipes-devtools/python/python-backports-abc_0.4.bb
> new file mode 100644
> index 0000000..6a4d267
> --- /dev/null
> +++ b/meta-python/recipes-devtools/python/python-backports-abc_0.4.bb
> @@ -0,0 +1,18 @@
> +SUMMARY = "collections.abc from Python 3.4"
> +DESCRIPTION = "A backport of recent additions to the 'collections.abc' module"
> +
> +LICENSE = "PSF"
> +LIC_FILES_CHKSUM = "file://${WORKDIR}/LICENSE;md5=dd98d01d471fac8d8dbdd975229dba03"
> +
> +# pypi package doesn't have valid entry for license
> +SRC_URI += "https://raw.githubusercontent.com/cython/backports_abc/master/LICENSE;name=license"
> +
> +SRC_URI[md5sum] = "0b65a216ce9dc9c1a7e20a729dd7c05b"
> +SRC_URI[sha256sum] = "8b3e4092ba3d541c7a2f9b7d0d9c0275b21c6a01c53a61c731eba6686939d0a5"
> +SRC_URI[license.md5sum] = "dd98d01d471fac8d8dbdd975229dba03"
> +SRC_URI[license.sha256sum] = "0a4f3b38055f50f047a42521568fa6ddb9a5976c2884f6ae138796d0f71150ca"
> +
> +
> +
> +PYPI_PACKAGE = "backports_abc"
> +inherit pypi setuptools
>


-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Re: [meta-python][PATCHv3 1/3] python-backports-abc: initial recipe for version 0.4 RDEPENDS

[S. Lockwood-Childs]

On Fri, Jun 03, 2016 at 07:03:22AM +0200, Gary Thomas wrote:
> On 06/02/2016 08:26 PM, S. Lockwood-Childs wrote:
> >Tornado 4.3 needs a couple more backport modules to prevent tornado/gen.py
> >from bombing on import errors when running on python2 rather than python3.4
> >
> >   ImportError: No module named backports_abc
> >
> >Signed-off-by: S. Lockwood-Childs <sjl@vctlabs.com>
> 
> In my mind, this patch (and its sibling) don't really have anything to to
> with Tornado, they are just new packages being added to make that package happy.
> I'd prefer to see a commit message that reflects what this package is as well
> as why it is being added.

> >+SUMMARY = "collections.abc from Python 3.4"
> >+DESCRIPTION = "A backport of recent additions to the 'collections.abc' module"

What would you like to see, a repeat of the SUMMARY or DESCRIPTION lines 
added to the corresponding commit messages (if so, which)? 

Other than that, I don't know what else to say about them; if their absence
wasn't breaking Tornado, I would not have picked either of these particular
modules to submit. Neither one has much use yet outside of Tornado (found no
other users of abc, while singledispatch is also used by rpy (python interface
to R). 

Re: [meta-python][PATCHv3 1/3] python-backports-abc: initial recipe for version 0.4 RDEPENDS

[Gary Thomas]

On 06/03/2016 07:38 AM, S. Lockwood-Childs wrote:
> On Fri, Jun 03, 2016 at 07:03:22AM +0200, Gary Thomas wrote:
>> On 06/02/2016 08:26 PM, S. Lockwood-Childs wrote:
>>> Tornado 4.3 needs a couple more backport modules to prevent tornado/gen.py
>> >from bombing on import errors when running on python2 rather than python3.4
>>>
>>>    ImportError: No module named backports_abc
>>>
>>> Signed-off-by: S. Lockwood-Childs <sjl@vctlabs.com>
>>
>> In my mind, this patch (and its sibling) don't really have anything to to
>> with Tornado, they are just new packages being added to make that package happy.
>> I'd prefer to see a commit message that reflects what this package is as well
>> as why it is being added.
>
>>> +SUMMARY = "collections.abc from Python 3.4"
>>> +DESCRIPTION = "A backport of recent additions to the 'collections.abc' module"
>
> What would you like to see, a repeat of the SUMMARY or DESCRIPTION lines
> added to the corresponding commit messages (if so, which)?
>
> Other than that, I don't know what else to say about them; if their absence
> wasn't breaking Tornado, I would not have picked either of these particular
> modules to submit. Neither one has much use yet outside of Tornado (found no
> other users of abc, while singledispatch is also used by rpy (python interface
> to R).
>

I would think the SUMMARY would be OK, along with a note that the package was
introduced to make Tornado happy.  (I know this is just "eye candy", but it does
help when searching through git logs...)

Thanks for doing this - I was about to make similar changes myself.

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Re: [meta-python][PATCHv3 1/3] python-backports-abc: initial recipe for version 0.4 RDEPENDS

[S. Lockwood-Childs]

On Fri, Jun 03, 2016 at 07:47:50AM +0200, Gary Thomas wrote:
> On 06/03/2016 07:38 AM, S. Lockwood-Childs wrote:
> >On Fri, Jun 03, 2016 at 07:03:22AM +0200, Gary Thomas wrote:
> >>On 06/02/2016 08:26 PM, S. Lockwood-Childs wrote:
> >>>Tornado 4.3 needs a couple more backport modules to prevent tornado/gen.py
> >>>from bombing on import errors when running on python2 rather than python3.4
> >>>
> >>>   ImportError: No module named backports_abc
> >>>
> >>>Signed-off-by: S. Lockwood-Childs <sjl@vctlabs.com>
> >>
> >>In my mind, this patch (and its sibling) don't really have anything to to
> >>with Tornado, they are just new packages being added to make that package happy.
> >>I'd prefer to see a commit message that reflects what this package is as well
> >>as why it is being added.
> >
> >>>+SUMMARY = "collections.abc from Python 3.4"
> >>>+DESCRIPTION = "A backport of recent additions to the 'collections.abc' module"
> >
> >What would you like to see, a repeat of the SUMMARY or DESCRIPTION lines
> >added to the corresponding commit messages (if so, which)?
> >
> >Other than that, I don't know what else to say about them; if their absence
> >wasn't breaking Tornado, I would not have picked either of these particular
> >modules to submit. Neither one has much use yet outside of Tornado (found no
> >other users of abc, while singledispatch is also used by rpy (python interface
> >to R).
> >
> 
> I would think the SUMMARY would be OK, along with a note that the package was
> introduced to make Tornado happy.  (I know this is just "eye candy", but it does
> help when searching through git logs...)
> 
> Thanks for doing this - I was about to make similar changes myself.

I am all for having useful git logs.

And at least it gives me a reason to resubmit the patch series without the 
typo that came back (grrr) though Martin was nice enough not to make me.