All of lore.kernel.org
 help / color / mirror / Atom feed
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: at91: ma5d4: properly define crystals frequencies
Date: Wed, 08 Jun 2016 01:46:01 +0200	[thread overview]
Message-ID: <57575CB9.8020808@denx.de> (raw)
In-Reply-To: <1465342279-9193-1-git-send-email-alexandre.belloni@free-electrons.com>

On 06/08/2016 01:31 AM, Alexandre Belloni wrote:
> The Denx MA5D4 dts doesn't properly define the slow_xtal and main_xtal
> frequencies, the PMC then has to fallback to using the RC oscillators whose
> precision is not really good.
> 
> As both crystals are populated, define their frequencies, see p17 of
> http://www.denx-cs.de/sites/all/files/MA5D4.HWM_.002.pdf
> 
> Also, remove the obsolete main_clock definition.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

That's correct, I had similar patch in my tree.

Acked-by: Marek Vasut <marex@denx.de>

Thanks!

> ---
>  arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi b/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi
> index e7b2109fc85a..99d57131782f 100644
> --- a/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi
> +++ b/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi
> @@ -20,8 +20,11 @@
>  	};
>  
>  	clocks {
> -		main_clock: main_clock {
> -			compatible = "atmel,osc", "fixed-clock";
> +		slow_xtal {
> +			clock-frequency = <32768>;
> +		};
> +
> +		main_xtal {
>  			clock-frequency = <12000000>;
>  		};
>  
> 


-- 
Best regards,
Marek Vasut

WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marex@denx.de>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: at91: ma5d4: properly define crystals frequencies
Date: Wed, 08 Jun 2016 01:46:01 +0200	[thread overview]
Message-ID: <57575CB9.8020808@denx.de> (raw)
In-Reply-To: <1465342279-9193-1-git-send-email-alexandre.belloni@free-electrons.com>

On 06/08/2016 01:31 AM, Alexandre Belloni wrote:
> The Denx MA5D4 dts doesn't properly define the slow_xtal and main_xtal
> frequencies, the PMC then has to fallback to using the RC oscillators whose
> precision is not really good.
> 
> As both crystals are populated, define their frequencies, see p17 of
> http://www.denx-cs.de/sites/all/files/MA5D4.HWM_.002.pdf
> 
> Also, remove the obsolete main_clock definition.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

That's correct, I had similar patch in my tree.

Acked-by: Marek Vasut <marex@denx.de>

Thanks!

> ---
>  arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi b/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi
> index e7b2109fc85a..99d57131782f 100644
> --- a/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi
> +++ b/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi
> @@ -20,8 +20,11 @@
>  	};
>  
>  	clocks {
> -		main_clock: main_clock {
> -			compatible = "atmel,osc", "fixed-clock";
> +		slow_xtal {
> +			clock-frequency = <32768>;
> +		};
> +
> +		main_xtal {
>  			clock-frequency = <12000000>;
>  		};
>  
> 


-- 
Best regards,
Marek Vasut

  reply	other threads:[~2016-06-07 23:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-07 23:31 [PATCH] ARM: dts: at91: ma5d4: properly define crystals frequencies Alexandre Belloni
2016-06-07 23:31 ` Alexandre Belloni
2016-06-07 23:46 ` Marek Vasut [this message]
2016-06-07 23:46   ` Marek Vasut
2016-06-10 14:49 ` Alexandre Belloni
2016-06-10 14:49   ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57575CB9.8020808@denx.de \
    --to=marex@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.