* [PATCH] ARM: dts: at91: ma5d4: properly define crystals frequencies
@ 2016-06-07 23:31 ` Alexandre Belloni
0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2016-06-07 23:31 UTC (permalink / raw)
To: linux-arm-kernel
The Denx MA5D4 dts doesn't properly define the slow_xtal and main_xtal
frequencies, the PMC then has to fallback to using the RC oscillators whose
precision is not really good.
As both crystals are populated, define their frequencies, see p17 of
http://www.denx-cs.de/sites/all/files/MA5D4.HWM_.002.pdf
Also, remove the obsolete main_clock definition.
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi b/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi
index e7b2109fc85a..99d57131782f 100644
--- a/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi
+++ b/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi
@@ -20,8 +20,11 @@
};
clocks {
- main_clock: main_clock {
- compatible = "atmel,osc", "fixed-clock";
+ slow_xtal {
+ clock-frequency = <32768>;
+ };
+
+ main_xtal {
clock-frequency = <12000000>;
};
--
2.8.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: at91: ma5d4: properly define crystals frequencies
@ 2016-06-07 23:31 ` Alexandre Belloni
0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2016-06-07 23:31 UTC (permalink / raw)
To: Nicolas Ferre, Marek Vasut
Cc: Boris Brezillon, linux-arm-kernel, linux-kernel,
Alexandre Belloni
The Denx MA5D4 dts doesn't properly define the slow_xtal and main_xtal
frequencies, the PMC then has to fallback to using the RC oscillators whose
precision is not really good.
As both crystals are populated, define their frequencies, see p17 of
http://www.denx-cs.de/sites/all/files/MA5D4.HWM_.002.pdf
Also, remove the obsolete main_clock definition.
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi b/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi
index e7b2109fc85a..99d57131782f 100644
--- a/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi
+++ b/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi
@@ -20,8 +20,11 @@
};
clocks {
- main_clock: main_clock {
- compatible = "atmel,osc", "fixed-clock";
+ slow_xtal {
+ clock-frequency = <32768>;
+ };
+
+ main_xtal {
clock-frequency = <12000000>;
};
--
2.8.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: at91: ma5d4: properly define crystals frequencies
2016-06-07 23:31 ` Alexandre Belloni
@ 2016-06-07 23:46 ` Marek Vasut
-1 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2016-06-07 23:46 UTC (permalink / raw)
To: linux-arm-kernel
On 06/08/2016 01:31 AM, Alexandre Belloni wrote:
> The Denx MA5D4 dts doesn't properly define the slow_xtal and main_xtal
> frequencies, the PMC then has to fallback to using the RC oscillators whose
> precision is not really good.
>
> As both crystals are populated, define their frequencies, see p17 of
> http://www.denx-cs.de/sites/all/files/MA5D4.HWM_.002.pdf
>
> Also, remove the obsolete main_clock definition.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
That's correct, I had similar patch in my tree.
Acked-by: Marek Vasut <marex@denx.de>
Thanks!
> ---
> arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi b/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi
> index e7b2109fc85a..99d57131782f 100644
> --- a/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi
> +++ b/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi
> @@ -20,8 +20,11 @@
> };
>
> clocks {
> - main_clock: main_clock {
> - compatible = "atmel,osc", "fixed-clock";
> + slow_xtal {
> + clock-frequency = <32768>;
> + };
> +
> + main_xtal {
> clock-frequency = <12000000>;
> };
>
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: at91: ma5d4: properly define crystals frequencies
@ 2016-06-07 23:46 ` Marek Vasut
0 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2016-06-07 23:46 UTC (permalink / raw)
To: Alexandre Belloni, Nicolas Ferre
Cc: Boris Brezillon, linux-arm-kernel, linux-kernel
On 06/08/2016 01:31 AM, Alexandre Belloni wrote:
> The Denx MA5D4 dts doesn't properly define the slow_xtal and main_xtal
> frequencies, the PMC then has to fallback to using the RC oscillators whose
> precision is not really good.
>
> As both crystals are populated, define their frequencies, see p17 of
> http://www.denx-cs.de/sites/all/files/MA5D4.HWM_.002.pdf
>
> Also, remove the obsolete main_clock definition.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
That's correct, I had similar patch in my tree.
Acked-by: Marek Vasut <marex@denx.de>
Thanks!
> ---
> arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi b/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi
> index e7b2109fc85a..99d57131782f 100644
> --- a/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi
> +++ b/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi
> @@ -20,8 +20,11 @@
> };
>
> clocks {
> - main_clock: main_clock {
> - compatible = "atmel,osc", "fixed-clock";
> + slow_xtal {
> + clock-frequency = <32768>;
> + };
> +
> + main_xtal {
> clock-frequency = <12000000>;
> };
>
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: at91: ma5d4: properly define crystals frequencies
2016-06-07 23:31 ` Alexandre Belloni
@ 2016-06-10 14:49 ` Alexandre Belloni
-1 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2016-06-10 14:49 UTC (permalink / raw)
To: linux-arm-kernel
On 08/06/2016 at 01:31:19 +0200, Alexandre Belloni wrote :
> The Denx MA5D4 dts doesn't properly define the slow_xtal and main_xtal
> frequencies, the PMC then has to fallback to using the RC oscillators whose
> precision is not really good.
>
> As both crystals are populated, define their frequencies, see p17 of
> http://www.denx-cs.de/sites/all/files/MA5D4.HWM_.002.pdf
>
> Also, remove the obsolete main_clock definition.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
Applied.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: at91: ma5d4: properly define crystals frequencies
@ 2016-06-10 14:49 ` Alexandre Belloni
0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2016-06-10 14:49 UTC (permalink / raw)
To: Nicolas Ferre, Marek Vasut
Cc: Boris Brezillon, linux-arm-kernel, linux-kernel
On 08/06/2016 at 01:31:19 +0200, Alexandre Belloni wrote :
> The Denx MA5D4 dts doesn't properly define the slow_xtal and main_xtal
> frequencies, the PMC then has to fallback to using the RC oscillators whose
> precision is not really good.
>
> As both crystals are populated, define their frequencies, see p17 of
> http://www.denx-cs.de/sites/all/files/MA5D4.HWM_.002.pdf
>
> Also, remove the obsolete main_clock definition.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
Applied.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-06-10 14:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-07 23:31 [PATCH] ARM: dts: at91: ma5d4: properly define crystals frequencies Alexandre Belloni
2016-06-07 23:31 ` Alexandre Belloni
2016-06-07 23:46 ` Marek Vasut
2016-06-07 23:46 ` Marek Vasut
2016-06-10 14:49 ` Alexandre Belloni
2016-06-10 14:49 ` Alexandre Belloni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.