All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] ARM: shmobile: marzen: Remove early_printk from command line
Date: Wed, 30 Apr 2014 00:45:07 +0000	[thread overview]
Message-ID: <5762305.SPmcAFynTG@avalon> (raw)
In-Reply-To: <1398757406-30920-3-git-send-email-horms+renesas@verge.net.au>

Hi Simon,

Thank you for the patch.

On Tuesday 29 April 2014 16:43:24 Simon Horman wrote:
> As far as I understand things this does not have any affect.
> So remove it.

The earlyprintk parameter actually makes a different when early printk support 
is enabled in the kernel. As that's not enabled by default, dropping it from 
the default command line is fine with me.

> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/arm/boot/dts/r8a7779-marzen.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/r8a7779-marzen.dts
> b/arch/arm/boot/dts/r8a7779-marzen.dts index 2c727cd..769ae84 100644
> --- a/arch/arm/boot/dts/r8a7779-marzen.dts
> +++ b/arch/arm/boot/dts/r8a7779-marzen.dts
> @@ -19,7 +19,7 @@
>  	compatible = "renesas,marzen", "renesas,r8a7779";
> 
>  	chosen {
> -		bootargs = "console=ttySC2,115200 earlyprintk=sh-sci.2,115200
> ignore_loglevel root=/dev/nfs ip=on"; +		bootargs = "console=ttySC2,115200
> ignore_loglevel root=/dev/nfs ip=on"; };
> 
>  	memory {

-- 
Regards,

Laurent Pinchart


WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ARM: shmobile: marzen: Remove early_printk from command line
Date: Wed, 30 Apr 2014 02:45:07 +0200	[thread overview]
Message-ID: <5762305.SPmcAFynTG@avalon> (raw)
In-Reply-To: <1398757406-30920-3-git-send-email-horms+renesas@verge.net.au>

Hi Simon,

Thank you for the patch.

On Tuesday 29 April 2014 16:43:24 Simon Horman wrote:
> As far as I understand things this does not have any affect.
> So remove it.

The earlyprintk parameter actually makes a different when early printk support 
is enabled in the kernel. As that's not enabled by default, dropping it from 
the default command line is fine with me.

> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/arm/boot/dts/r8a7779-marzen.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/r8a7779-marzen.dts
> b/arch/arm/boot/dts/r8a7779-marzen.dts index 2c727cd..769ae84 100644
> --- a/arch/arm/boot/dts/r8a7779-marzen.dts
> +++ b/arch/arm/boot/dts/r8a7779-marzen.dts
> @@ -19,7 +19,7 @@
>  	compatible = "renesas,marzen", "renesas,r8a7779";
> 
>  	chosen {
> -		bootargs = "console=ttySC2,115200 earlyprintk=sh-sci.2,115200
> ignore_loglevel root=/dev/nfs ip=on"; +		bootargs = "console=ttySC2,115200
> ignore_loglevel root=/dev/nfs ip=on"; };
> 
>  	memory {

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2014-04-30  0:45 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-29  7:43 [PATCH/RFC 0/4] ARM: shmobile: marzen: Initialise SCIF devices using DT Simon Horman
2014-04-29  7:43 ` Simon Horman
2014-04-29  7:43 ` [PATCH 1/4] ARM: shmobile: r8a7779: Add scif nodes to dtsi Simon Horman
2014-04-29  7:43   ` Simon Horman
2014-04-30  0:42   ` Laurent Pinchart
2014-04-30  0:42     ` Laurent Pinchart
2014-04-30  1:51     ` Simon Horman
2014-04-30  1:51       ` Simon Horman
2014-04-29  7:43 ` [PATCH 2/4] ARM: shmobile: marzen: Remove early_printk from command line Simon Horman
2014-04-29  7:43   ` Simon Horman
2014-04-30  0:45   ` Laurent Pinchart [this message]
2014-04-30  0:45     ` Laurent Pinchart
2014-04-29  7:43 ` [PATCH 3/4] ARM: shmobile: marzen: Initialise SCIF devices using DT Simon Horman
2014-04-29  7:43   ` Simon Horman
2014-04-30  0:45   ` Laurent Pinchart
2014-04-30  0:45     ` Laurent Pinchart
2014-04-29  7:43 ` [PATCH 4/4] ARM: shmobile: marzen: Use disabled variant of clock workaround for scif devices Simon Horman
2014-04-29  7:43   ` Simon Horman
2014-04-29 13:40   ` Magnus Damm
2014-04-29 13:40     ` Magnus Damm
2014-04-29 23:51     ` Simon Horman
2014-04-29 23:51       ` Simon Horman
2014-04-30  0:47       ` Laurent Pinchart
2014-04-30  0:47         ` Laurent Pinchart
2014-04-30  1:50         ` Simon Horman
2014-04-30  1:50           ` Simon Horman
2014-04-30  4:49           ` Magnus Damm
2014-04-30  4:49             ` Magnus Damm
2014-04-30  5:31             ` Simon Horman
2014-04-30  5:31               ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5762305.SPmcAFynTG@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.