From: tthayer@opensource.altera.com (Thor Thayer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 2/7] EDAC, altera: Add panic flag check to A10 IRQ
Date: Fri, 17 Jun 2016 12:11:21 -0500 [thread overview]
Message-ID: <57642F39.7020600@opensource.altera.com> (raw)
In-Reply-To: <20160617170253.GH3912@pd.tnic>
On 06/17/2016 12:02 PM, Borislav Petkov wrote:
> On Fri, Jun 17, 2016 at 12:05:41PM -0500, Thor Thayer wrote:
>> That is a good question. We have 2 important uses for OCRAM 1) to hold our
>> power-down/sleep and resume functions and 2) to hold our FPGA contents
>> during sleep. If either of these is corrupted, it is better to panic than to
>> load something that would cause incorrect.
>>
>> In the cases of the FIFOs such as Ethernet and USB, the plan is to add code
>> to drop the packet so that we'll get a re-transmission. In that case, it is
>> sort of recoverable.
>
> Much better. Now put that explanation in the code please!
>
> :-)
>
I'll add that in the next revision. Thanks for reviewing.
WARNING: multiple messages have this Message-ID (diff)
From: Thor Thayer <tthayer@opensource.altera.com>
To: Borislav Petkov <bp@alien8.de>
Cc: dougthompson@xmission.com, m.chehab@samsung.com,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux@arm.linux.org.uk, dinguyen@opensource.altera.com,
grant.likely@linaro.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, linux-edac@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, tthayer.linux@gmail.com
Subject: Re: [PATCHv3 2/7] EDAC, altera: Add panic flag check to A10 IRQ
Date: Fri, 17 Jun 2016 12:11:21 -0500 [thread overview]
Message-ID: <57642F39.7020600@opensource.altera.com> (raw)
In-Reply-To: <20160617170253.GH3912@pd.tnic>
On 06/17/2016 12:02 PM, Borislav Petkov wrote:
> On Fri, Jun 17, 2016 at 12:05:41PM -0500, Thor Thayer wrote:
>> That is a good question. We have 2 important uses for OCRAM 1) to hold our
>> power-down/sleep and resume functions and 2) to hold our FPGA contents
>> during sleep. If either of these is corrupted, it is better to panic than to
>> load something that would cause incorrect.
>>
>> In the cases of the FIFOs such as Ethernet and USB, the plan is to add code
>> to drop the packet so that we'll get a re-transmission. In that case, it is
>> sort of recoverable.
>
> Much better. Now put that explanation in the code please!
>
> :-)
>
I'll add that in the next revision. Thanks for reviewing.
next prev parent reply other threads:[~2016-06-17 17:11 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 21:19 [PATCHv3 0/7] Add Ethernet EDAC & peripheral init functions tthayer at opensource.altera.com
2016-06-13 21:19 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
2016-06-13 21:19 ` [PATCHv3 1/7] EDAC, altera: Check parent status for Arria10 EDAC block tthayer at opensource.altera.com
2016-06-13 21:19 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
2016-06-17 16:46 ` Borislav Petkov
2016-06-17 16:46 ` Borislav Petkov
2016-06-17 16:54 ` Thor Thayer
2016-06-17 16:54 ` Thor Thayer
2016-06-17 16:54 ` Borislav Petkov
2016-06-17 16:54 ` Borislav Petkov
2016-06-13 21:19 ` [PATCHv3 2/7] EDAC, altera: Add panic flag check to A10 IRQ tthayer at opensource.altera.com
2016-06-13 21:19 ` tthayer
2016-06-17 16:51 ` Borislav Petkov
2016-06-17 16:51 ` Borislav Petkov
2016-06-17 17:05 ` Thor Thayer
2016-06-17 17:05 ` Thor Thayer
2016-06-17 17:02 ` Borislav Petkov
2016-06-17 17:02 ` Borislav Petkov
2016-06-17 17:11 ` Thor Thayer [this message]
2016-06-17 17:11 ` Thor Thayer
2016-06-13 21:19 ` [PATCHv3 3/7] EDAC, altera: Share Arria10 check_deps & IRQ functions tthayer at opensource.altera.com
2016-06-13 21:19 ` tthayer
2016-06-17 17:00 ` Borislav Petkov
2016-06-17 17:00 ` Borislav Petkov
2016-06-17 17:09 ` Thor Thayer
2016-06-17 17:09 ` Thor Thayer
2016-06-17 17:11 ` Borislav Petkov
2016-06-17 17:11 ` Borislav Petkov
2016-06-17 17:37 ` Thor Thayer
2016-06-17 17:37 ` Thor Thayer
2016-06-13 21:19 ` [PATCHv3 4/7] Documentation: dt: socfpga: Add Arria10 Ethernet binding tthayer at opensource.altera.com
2016-06-13 21:19 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
2016-06-16 18:39 ` Rob Herring
2016-06-16 18:39 ` Rob Herring
2016-06-16 19:12 ` Thor Thayer
2016-06-16 19:12 ` Thor Thayer
2016-06-13 21:19 ` [PATCHv3 5/7] EDAC, altera: Add Arria10 ECC memory init functions tthayer at opensource.altera.com
2016-06-13 21:19 ` tthayer-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
2016-06-17 17:21 ` Borislav Petkov
2016-06-17 17:21 ` Borislav Petkov
2016-06-17 17:42 ` Thor Thayer
2016-06-17 17:42 ` Thor Thayer
2016-06-13 21:19 ` [PATCHv3 6/7] EDAC, altera: Add Arria10 Ethernet EDAC support tthayer at opensource.altera.com
2016-06-13 21:19 ` tthayer
2016-06-17 17:29 ` Borislav Petkov
2016-06-17 17:29 ` Borislav Petkov
2016-06-17 17:43 ` Thor Thayer
2016-06-17 17:43 ` Thor Thayer
2016-06-13 21:19 ` [PATCHv3 7/7] ARM: dts: Add Arria10 Ethernet EDAC devicetree entry tthayer at opensource.altera.com
2016-06-13 21:19 ` tthayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57642F39.7020600@opensource.altera.com \
--to=tthayer@opensource.altera.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.