* [PATCH 1/2] drm/omap: dsi: Remove unused variable
@ 2016-06-21 13:56 Thierry Reding
2016-06-21 13:56 ` [PATCH 2/2] drm/omap: hdmi: " Thierry Reding
2016-06-21 14:00 ` [PATCH 1/2] drm/omap: dsi: " Tomi Valkeinen
0 siblings, 2 replies; 4+ messages in thread
From: Thierry Reding @ 2016-06-21 13:56 UTC (permalink / raw)
To: Tomi Valkeinen; +Cc: Peter Ujfalusi, dri-devel
From: Thierry Reding <treding@nvidia.com>
Commit 973999aa0140 ("drm/omap: Remove regulator API abuse") removed the
only user of the local 'r' variable, which thus became unused.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/gpu/drm/omapdrm/dss/dsi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
index 6f45e9d00b41..e1be5e795cd8 100644
--- a/drivers/gpu/drm/omapdrm/dss/dsi.c
+++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
@@ -1167,7 +1167,6 @@ static int dsi_regulator_init(struct platform_device *dsidev)
{
struct dsi_data *dsi = dsi_get_dsidrv_data(dsidev);
struct regulator *vdds_dsi;
- int r;
if (dsi->vdds_dsi_reg != NULL)
return 0;
--
2.8.3
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] drm/omap: hdmi: Remove unused variable
2016-06-21 13:56 [PATCH 1/2] drm/omap: dsi: Remove unused variable Thierry Reding
@ 2016-06-21 13:56 ` Thierry Reding
2016-06-21 14:00 ` [PATCH 1/2] drm/omap: dsi: " Tomi Valkeinen
1 sibling, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2016-06-21 13:56 UTC (permalink / raw)
To: Tomi Valkeinen; +Cc: Peter Ujfalusi, dri-devel
From: Thierry Reding <treding@nvidia.com>
Commit 973999aa0140 ("drm/omap: Remove regulator API abuse") removed the
only user of the local 'r' variable, which thus became unused.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/gpu/drm/omapdrm/dss/hdmi5.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5.c b/drivers/gpu/drm/omapdrm/dss/hdmi5.c
index 061f9bab4c9b..0c0a5139a301 100644
--- a/drivers/gpu/drm/omapdrm/dss/hdmi5.c
+++ b/drivers/gpu/drm/omapdrm/dss/hdmi5.c
@@ -120,7 +120,6 @@ static irqreturn_t hdmi_irq_handler(int irq, void *data)
static int hdmi_init_regulator(void)
{
- int r;
struct regulator *reg;
if (hdmi.vdda_reg != NULL)
--
2.8.3
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] drm/omap: dsi: Remove unused variable
2016-06-21 13:56 [PATCH 1/2] drm/omap: dsi: Remove unused variable Thierry Reding
2016-06-21 13:56 ` [PATCH 2/2] drm/omap: hdmi: " Thierry Reding
@ 2016-06-21 14:00 ` Tomi Valkeinen
2016-06-21 14:01 ` Thierry Reding
1 sibling, 1 reply; 4+ messages in thread
From: Tomi Valkeinen @ 2016-06-21 14:00 UTC (permalink / raw)
To: Thierry Reding; +Cc: Peter Ujfalusi, dri-devel
[-- Attachment #1.1.1: Type: text/plain, Size: 1031 bytes --]
Hi Thierry,
On 21/06/16 16:56, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Commit 973999aa0140 ("drm/omap: Remove regulator API abuse") removed the
> only user of the local 'r' variable, which thus became unused.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/gpu/drm/omapdrm/dss/dsi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
> index 6f45e9d00b41..e1be5e795cd8 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dsi.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
> @@ -1167,7 +1167,6 @@ static int dsi_regulator_init(struct platform_device *dsidev)
> {
> struct dsi_data *dsi = dsi_get_dsidrv_data(dsidev);
> struct regulator *vdds_dsi;
> - int r;
>
> if (dsi->vdds_dsi_reg != NULL)
> return 0;
>
Thanks, but there's already 85332739628fe4beafecdb713438c7cb1454c2f5
("drm/omap: fix unused variable warning in dsi & hdmi") in the mainline
(-rc3).
Tomi
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] drm/omap: dsi: Remove unused variable
2016-06-21 14:00 ` [PATCH 1/2] drm/omap: dsi: " Tomi Valkeinen
@ 2016-06-21 14:01 ` Thierry Reding
0 siblings, 0 replies; 4+ messages in thread
From: Thierry Reding @ 2016-06-21 14:01 UTC (permalink / raw)
To: Tomi Valkeinen; +Cc: Peter Ujfalusi, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1260 bytes --]
On Tue, Jun 21, 2016 at 05:00:15PM +0300, Tomi Valkeinen wrote:
> Hi Thierry,
>
> On 21/06/16 16:56, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >
> > Commit 973999aa0140 ("drm/omap: Remove regulator API abuse") removed the
> > only user of the local 'r' variable, which thus became unused.
> >
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > ---
> > drivers/gpu/drm/omapdrm/dss/dsi.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
> > index 6f45e9d00b41..e1be5e795cd8 100644
> > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c
> > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
> > @@ -1167,7 +1167,6 @@ static int dsi_regulator_init(struct platform_device *dsidev)
> > {
> > struct dsi_data *dsi = dsi_get_dsidrv_data(dsidev);
> > struct regulator *vdds_dsi;
> > - int r;
> >
> > if (dsi->vdds_dsi_reg != NULL)
> > return 0;
> >
>
> Thanks, but there's already 85332739628fe4beafecdb713438c7cb1454c2f5
> ("drm/omap: fix unused variable warning in dsi & hdmi") in the mainline
> (-rc3).
Bah... that's what I get for not generating patches against linux-next.
Thanks for letting me know.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-06-21 14:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-21 13:56 [PATCH 1/2] drm/omap: dsi: Remove unused variable Thierry Reding
2016-06-21 13:56 ` [PATCH 2/2] drm/omap: hdmi: " Thierry Reding
2016-06-21 14:00 ` [PATCH 1/2] drm/omap: dsi: " Tomi Valkeinen
2016-06-21 14:01 ` Thierry Reding
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.