All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Wood <michael.g.wood@intel.com>
To: toaster@yoctoproject.org
Subject: Re: [PATCH] toaster: fix typo in arguments for libtoaster.js function
Date: Tue, 21 Jun 2016 15:57:18 +0100	[thread overview]
Message-ID: <576955CE.80408@intel.com> (raw)
In-Reply-To: <1466424046-13234-1-git-send-email-elliot.smith@intel.com>


Thanks, Submitted up to bitbake-devel and applied to toaster-next
Also opened a bug to create some tests for the project dashboard.

On 20/06/16 13:00, Elliot Smith wrote:
> The function for flattening the targets of a previous build
> to a space-separated list references prev and next arguments
> which aren't in the function signature. This prevents the "Rebuild"
> buttons (in the most-recent build section) from working.
>
> Fix the typo so that the buttons work again.
>
> Signed-off-by: Elliot Smith <elliot.smith@intel.com>
> ---
>   bitbake/lib/toaster/toastergui/static/js/libtoaster.js | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bitbake/lib/toaster/toastergui/static/js/libtoaster.js b/bitbake/lib/toaster/toastergui/static/js/libtoaster.js
> index eafe70d..a1379e1 100644
> --- a/bitbake/lib/toaster/toastergui/static/js/libtoaster.js
> +++ b/bitbake/lib/toaster/toastergui/static/js/libtoaster.js
> @@ -94,7 +94,7 @@ var libtoaster = (function () {
>   
>       /* Flatten the array of targets into a space spearated list */
>       if (targets instanceof Array){
> -      targets = targets.reduce(function(prevV, nextV){
> +      targets = targets.reduce(function(prev, next){
>           return prev + ' ' + next;
>         });
>       }



  reply	other threads:[~2016-06-21 14:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-20 12:00 [PATCH] toaster: fix typo in arguments for libtoaster.js function Elliot Smith
2016-06-21 14:57 ` Michael Wood [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-06-21 14:54 Michael Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=576955CE.80408@intel.com \
    --to=michael.g.wood@intel.com \
    --cc=toaster@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.