[PATCH] toaster: fix typo in arguments for libtoaster.js function

[PATCH] toaster: fix typo in arguments for libtoaster.js function

[Elliot Smith]

The function for flattening the targets of a previous build
to a space-separated list references prev and next arguments
which aren't in the function signature. This prevents the "Rebuild"
buttons (in the most-recent build section) from working.

Fix the typo so that the buttons work again.

Signed-off-by: Elliot Smith <elliot.smith@intel.com>
---
 bitbake/lib/toaster/toastergui/static/js/libtoaster.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bitbake/lib/toaster/toastergui/static/js/libtoaster.js b/bitbake/lib/toaster/toastergui/static/js/libtoaster.js
index eafe70d..a1379e1 100644
--- a/bitbake/lib/toaster/toastergui/static/js/libtoaster.js
+++ b/bitbake/lib/toaster/toastergui/static/js/libtoaster.js
@@ -94,7 +94,7 @@ var libtoaster = (function () {
 
     /* Flatten the array of targets into a space spearated list */
     if (targets instanceof Array){
-      targets = targets.reduce(function(prevV, nextV){
+      targets = targets.reduce(function(prev, next){
         return prev + ' ' + next;
       });
     }
-- 
2.7.4

[PATCH] toaster: fix typo in arguments for libtoaster.js function

[Michael Wood]

From: Elliot Smith <elliot.smith@intel.com>

The function for flattening the targets of a previous build
to a space-separated list references prev and next arguments
which aren't in the function signature. This prevents the "Rebuild"
buttons (in the most-recent build section) from working.

Fix the typo so that the buttons work again.

Signed-off-by: Elliot Smith <elliot.smith@intel.com>
Signed-off-by: Michael Wood <michael.g.wood@intel.com>
---
 lib/toaster/toastergui/static/js/libtoaster.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/toaster/toastergui/static/js/libtoaster.js b/lib/toaster/toastergui/static/js/libtoaster.js
index eafe70d..a1379e1 100644
--- a/lib/toaster/toastergui/static/js/libtoaster.js
+++ b/lib/toaster/toastergui/static/js/libtoaster.js
@@ -94,7 +94,7 @@ var libtoaster = (function () {
 
     /* Flatten the array of targets into a space spearated list */
     if (targets instanceof Array){
-      targets = targets.reduce(function(prevV, nextV){
+      targets = targets.reduce(function(prev, next){
         return prev + ' ' + next;
       });
     }
-- 
2.7.4

Re: [PATCH] toaster: fix typo in arguments for libtoaster.js function

[Michael Wood]

Thanks, Submitted up to bitbake-devel and applied to toaster-next
Also opened a bug to create some tests for the project dashboard.

On 20/06/16 13:00, Elliot Smith wrote:
> The function for flattening the targets of a previous build
> to a space-separated list references prev and next arguments
> which aren't in the function signature. This prevents the "Rebuild"
> buttons (in the most-recent build section) from working.
>
> Fix the typo so that the buttons work again.
>
> Signed-off-by: Elliot Smith <elliot.smith@intel.com>
> ---
>   bitbake/lib/toaster/toastergui/static/js/libtoaster.js | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bitbake/lib/toaster/toastergui/static/js/libtoaster.js b/bitbake/lib/toaster/toastergui/static/js/libtoaster.js
> index eafe70d..a1379e1 100644
> --- a/bitbake/lib/toaster/toastergui/static/js/libtoaster.js
> +++ b/bitbake/lib/toaster/toastergui/static/js/libtoaster.js
> @@ -94,7 +94,7 @@ var libtoaster = (function () {
>   
>       /* Flatten the array of targets into a space spearated list */
>       if (targets instanceof Array){
> -      targets = targets.reduce(function(prevV, nextV){
> +      targets = targets.reduce(function(prev, next){
>           return prev + ' ' + next;
>         });
>       }