From: Eric Blake <eblake@redhat.com>
To: "Lluís Vilanova" <vilanova@ac.upc.edu>, qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] trace: [linux-user] Commandline arguments to control tracing
Date: Tue, 21 Jun 2016 16:08:32 -0600 [thread overview]
Message-ID: <5769BAE0.1040105@redhat.com> (raw)
In-Reply-To: <146651541133.29362.6693427750748986464.stgit@fimbulvetr.bsc.es>
[-- Attachment #1: Type: text/plain, Size: 717 bytes --]
On 06/21/2016 07:23 AM, Lluís Vilanova wrote:
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
> linux-user/main.c | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> + {"trace-enable", "QEMU_TRACE_ENABLE",true, handle_arg_trace_enable,
> + "name", "enable tracing of specified event names (pass '?' to show a list of events)"},
? is a shell metacharacter, and it requires quoting to be safe against
globbing against any single-letter files in the current directory. A
better suggestion would be to pass 'help' to show a list of events.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-06-21 22:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 13:23 [Qemu-devel] [PATCH 0/2] trace: [*-user] Add commandline arguments to control tracing Lluís Vilanova
2016-06-21 13:23 ` [Qemu-devel] [PATCH 1/2] trace: [linux-user] Commandline " Lluís Vilanova
2016-06-21 22:08 ` Eric Blake [this message]
2016-06-22 9:53 ` Lluís Vilanova
2016-06-21 13:23 ` [Qemu-devel] [PATCH 2/2] trace: [bsd-user] " Lluís Vilanova
2016-06-21 22:09 ` Eric Blake
2016-06-22 9:54 ` Lluís Vilanova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5769BAE0.1040105@redhat.com \
--to=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=stefanha@redhat.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.