Re: [Qemu-devel] [PATCH 2/2] trace: [bsd-user] Commandline arguments to control tracing

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1178 bytes --]

On 06/21/2016 07:23 AM, Lluís Vilanova wrote:
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
>  bsd-user/main.c |   21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/bsd-user/main.c b/bsd-user/main.c
> index 9f592be..ce2cc17 100644
> --- a/bsd-user/main.c
> +++ b/bsd-user/main.c
> @@ -30,6 +30,7 @@
>  #include "qemu/timer.h"
>  #include "qemu/envlist.h"
>  #include "exec/log.h"
> +#include "trace/control.h"
>  
>  int singlestep;
>  unsigned long mmap_min_addr;
> @@ -687,6 +688,14 @@ static void usage(void)
>             "-p pagesize       set the host page size to 'pagesize'\n"
>             "-singlestep       always run in singlestep mode\n"
>             "-strace           log system calls\n"
> +           "-trace-enable name\n"
> +           "                  enable tracing of specified event names\n"
> +           "                  (pass '?' to show a list of events)\n"

Same complaint as in 1/2.  Also, why does this one split into two lines,
while that one had long lines?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]