From: Yisen.zhuang@huawei.com (Yisen Zhuang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH net-next 16/19] net: hns: fix bug that alloc skb fail lead to port unavailable
Date: Wed, 22 Jun 2016 09:41:43 +0800 [thread overview]
Message-ID: <5769ECD7.8080303@huawei.com> (raw)
In-Reply-To: <097b1147-3587-9579-0f94-f42be130773c@cogentembedded.com>
? 2016/6/21 21:25, Sergei Shtylyov ??:
> Hello.
>
> On 6/21/2016 6:56 AM, Yisen Zhuang wrote:
>
>> From: Jun He <hjat2005@huawei.com>
>>
>> When hns_nic_poll_rx_skb alloc skb fail, it will break receive cycle and
>> read new fbd_num to start new receive cycle. It recomputes cycle num is
>> fbd_num minus clean_count, actually this cycle num is too big because
>> it drop out receive cycle. It brings about the port unavailable.
>>
>> So we will goto out when alloc skb fail to fix this bug.
>>
>> Signed-off-by: Jun He <hjat2005@huawei.com>
>> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
>> Signed-off-by: Yisen Zhuang <Yisen.Zhuang@huawei.com>
>> ---
>> drivers/net/ethernet/hisilicon/hns/hns_enet.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
>> index f49246d..c0ce37b 100644
>> --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c
>> +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
>> @@ -768,10 +768,10 @@ recv:
>> clean_count = 0;
>> }
>>
>> - /* poll one pkg*/
>> + /* poll one pkt*/
I will fix it with a new patch.
Thanks,
Yisen
>
> How about adding a space before */?
>
> [...]
>
> MBR, Sergei
>
>
> .
>
WARNING: multiple messages have this Message-ID (diff)
From: Yisen Zhuang <Yisen.zhuang@huawei.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
<davem@davemloft.net>, <salil.mehta@huawei.com>,
<yankejian@huawei.com>
Cc: <liguozhu@huawei.com>, <huangdaode@hisilicon.com>,
<arnd@arndb.de>, <andriy.shevchenko@linux.intel.com>,
<andrew@lunn.ch>, <geliangtang@163.com>, <ivecera@redhat.com>,
<fengguang.wu@intel.com>, <charles.chenxin@huawei.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <linuxarm@huawei.com>
Subject: Re: [PATCH net-next 16/19] net: hns: fix bug that alloc skb fail lead to port unavailable
Date: Wed, 22 Jun 2016 09:41:43 +0800 [thread overview]
Message-ID: <5769ECD7.8080303@huawei.com> (raw)
In-Reply-To: <097b1147-3587-9579-0f94-f42be130773c@cogentembedded.com>
在 2016/6/21 21:25, Sergei Shtylyov 写道:
> Hello.
>
> On 6/21/2016 6:56 AM, Yisen Zhuang wrote:
>
>> From: Jun He <hjat2005@huawei.com>
>>
>> When hns_nic_poll_rx_skb alloc skb fail, it will break receive cycle and
>> read new fbd_num to start new receive cycle. It recomputes cycle num is
>> fbd_num minus clean_count, actually this cycle num is too big because
>> it drop out receive cycle. It brings about the port unavailable.
>>
>> So we will goto out when alloc skb fail to fix this bug.
>>
>> Signed-off-by: Jun He <hjat2005@huawei.com>
>> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
>> Signed-off-by: Yisen Zhuang <Yisen.Zhuang@huawei.com>
>> ---
>> drivers/net/ethernet/hisilicon/hns/hns_enet.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
>> index f49246d..c0ce37b 100644
>> --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c
>> +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
>> @@ -768,10 +768,10 @@ recv:
>> clean_count = 0;
>> }
>>
>> - /* poll one pkg*/
>> + /* poll one pkt*/
I will fix it with a new patch.
Thanks,
Yisen
>
> How about adding a space before */?
>
> [...]
>
> MBR, Sergei
>
>
> .
>
WARNING: multiple messages have this Message-ID (diff)
From: Yisen Zhuang <Yisen.zhuang@huawei.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
<davem@davemloft.net>, <salil.mehta@huawei.com>,
<yankejian@huawei.com>
Cc: ivecera@redhat.com, andrew@lunn.ch, fengguang.wu@intel.com,
liguozhu@huawei.com, arnd@arndb.de, charles.chenxin@huawei.com,
linux-kernel@vger.kernel.org, linuxarm@huawei.com,
geliangtang@163.com, huangdaode@hisilicon.com,
netdev@vger.kernel.org, andriy.shevchenko@linux.intel.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next 16/19] net: hns: fix bug that alloc skb fail lead to port unavailable
Date: Wed, 22 Jun 2016 09:41:43 +0800 [thread overview]
Message-ID: <5769ECD7.8080303@huawei.com> (raw)
In-Reply-To: <097b1147-3587-9579-0f94-f42be130773c@cogentembedded.com>
在 2016/6/21 21:25, Sergei Shtylyov 写道:
> Hello.
>
> On 6/21/2016 6:56 AM, Yisen Zhuang wrote:
>
>> From: Jun He <hjat2005@huawei.com>
>>
>> When hns_nic_poll_rx_skb alloc skb fail, it will break receive cycle and
>> read new fbd_num to start new receive cycle. It recomputes cycle num is
>> fbd_num minus clean_count, actually this cycle num is too big because
>> it drop out receive cycle. It brings about the port unavailable.
>>
>> So we will goto out when alloc skb fail to fix this bug.
>>
>> Signed-off-by: Jun He <hjat2005@huawei.com>
>> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
>> Signed-off-by: Yisen Zhuang <Yisen.Zhuang@huawei.com>
>> ---
>> drivers/net/ethernet/hisilicon/hns/hns_enet.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
>> index f49246d..c0ce37b 100644
>> --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c
>> +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
>> @@ -768,10 +768,10 @@ recv:
>> clean_count = 0;
>> }
>>
>> - /* poll one pkg*/
>> + /* poll one pkt*/
I will fix it with a new patch.
Thanks,
Yisen
>
> How about adding a space before */?
>
> [...]
>
> MBR, Sergei
>
>
> .
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2016-06-22 1:41 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 3:56 [PATCH net-next 00/19] net: hns: fix some bugs in hns driver Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 3:56 ` [PATCH net-next 01/19] net: hns: bug fix of ge reset sequence Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 10:35 ` Andy Shevchenko
2016-06-21 10:35 ` Andy Shevchenko
2016-06-22 1:33 ` Yisen Zhuang
2016-06-22 1:33 ` Yisen Zhuang
2016-06-22 1:33 ` Yisen Zhuang
2016-06-21 3:56 ` [PATCH net-next 02/19] net: hns: fix hns dsaf v1 dont support tx_pause close Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 3:56 ` [PATCH net-next 03/19] net: hns: add skb_reset_mac_header() after skb being alloc Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 3:56 ` [PATCH net-next 04/19] net: hns: typo fix of annotation info for hns_nic_reset_subtask() Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 3:56 ` [PATCH net-next 05/19] net: hns: Remove unnecessary device resource free Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 3:56 ` [PATCH net-next 06/19] net: hns: fix the error info when dma_set_mask_and_coherent fail Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 3:56 ` [PATCH net-next 07/19] net: hns: select Hilink before serdes loopback for HNS V2 Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 3:56 ` [PATCH net-next 08/19] net: hns: fix ethtool loopback fail bug Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 3:56 ` [PATCH net-next 09/19] net: hns: fix the wrong speed for bond Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 3:56 ` [PATCH net-next 10/19] net: hns: bugfix about pfc pause frame statistics Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 10:32 ` Andy Shevchenko
2016-06-21 10:32 ` Andy Shevchenko
2016-06-21 10:32 ` Andy Shevchenko
2016-06-22 1:43 ` Yisen Zhuang
2016-06-22 1:43 ` Yisen Zhuang
2016-06-22 9:41 ` Andy Shevchenko
2016-06-22 9:41 ` Andy Shevchenko
2016-06-23 5:42 ` Yisen Zhuang
2016-06-23 5:42 ` Yisen Zhuang
2016-06-21 3:56 ` [PATCH net-next 11/19] net: hns: add spin lock for tcam table operation Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 3:56 ` [PATCH net-next 12/19] net: hns: fix bug of getting the wrong tcam data Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 3:56 ` [PATCH net-next 13/19] net: hns: add get_coalesce_range api for hns Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 3:56 ` [PATCH net-next 14/19] net: hns: delete redundancy ring enable operations Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 3:56 ` [PATCH net-next 15/19] net: hns: bug fix about led control logic when link down Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 3:56 ` [PATCH net-next 16/19] net: hns: fix bug that alloc skb fail lead to port unavailable Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 13:25 ` Sergei Shtylyov
2016-06-21 13:25 ` Sergei Shtylyov
2016-06-22 1:41 ` Yisen Zhuang [this message]
2016-06-22 1:41 ` Yisen Zhuang
2016-06-22 1:41 ` Yisen Zhuang
2016-06-21 3:56 ` [PATCH net-next 17/19] net: hns: fix sbm default parameters config error Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 3:56 ` [PATCH net-next 18/19] net: hns: change the default coalesce usecs Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 3:56 ` [PATCH net-next 19/19] net: hns: bug fix about TSO on|off when there is traffic Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 3:56 ` Yisen Zhuang
2016-06-21 8:54 ` [PATCH net-next 00/19] net: hns: fix some bugs in hns driver David Miller
2016-06-21 8:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5769ECD7.8080303@huawei.com \
--to=yisen.zhuang@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.