All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org, hannes@cmpxchg.org,
	mgorman@techsingularity.net, n-horiguchi@ah.jp.nec.com,
	mhocko@suse.com, kirill.shutemov@linux.intel.com,
	hughd@google.com, vbabka@suse.cz, adrian.hunter@intel.com,
	dedekind1@gmail.com, hch@infradead.org,
	linux-fsdevel@vger.kernel.org,
	boris.brezillon@free-electrons.com,
	maxime.ripard@free-electrons.com, david@sigma-star.at,
	david@fromorbit.com, alex@nextthing.co, sasha.levin@oracle.com,
	iamjoonsoo.kim@lge.com, rvaswani@codeaurora.org,
	tony.luck@intel.com, shailendra.capricorn@gmail.com
Subject: Re: [PATCH 1/3] mm: Don't blindly assign fallback_migrate_page()
Date: Thu, 23 Jun 2016 00:21:11 +0200	[thread overview]
Message-ID: <576B0F57.3030700@nod.at> (raw)
In-Reply-To: <20160616161121.35ee5183b9ef9f7b7dcbc815@linux-foundation.org>

Am 17.06.2016 um 01:11 schrieb Andrew Morton:
> On Thu, 16 Jun 2016 23:26:13 +0200 Richard Weinberger <richard@nod.at> wrote:
> 
>> While block oriented filesystems use buffer_migrate_page()
>> as page migration function other filesystems which don't
>> implement ->migratepage() will automatically get fallback_migrate_page()
>> assigned. fallback_migrate_page() is not as generic as is should
>> be. Page migration is filesystem specific and a one-fits-all function
>> is hard to achieve. UBIFS leaned this lection the hard way.
>> It uses various page flags and fallback_migrate_page() does not
>> handle these flags as UBIFS expected.
>>
>> To make sure that no further filesystem will get confused by
>> fallback_migrate_page() disable the automatic assignment and
>> allow filesystems to use this function explicitly if it is
>> really suitable.
> 
> hm, is there really much point in doing this?  I assume it doesn't
> actually affect any current filesystems?
> 
> [2/3] is of course OK - please add it to the UBIFS tree.

Pushed 2/3 and 3/3 into UBIFS next tree.

Thanks,
//richard

WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org, hannes@cmpxchg.org,
	mgorman@techsingularity.net, n-horiguchi@ah.jp.nec.com,
	mhocko@suse.com, kirill.shutemov@linux.intel.com,
	hughd@google.com, vbabka@suse.cz, adrian.hunter@intel.com,
	dedekind1@gmail.com, hch@infradead.org,
	linux-fsdevel@vger.kernel.org,
	boris.brezillon@free-electrons.com,
	maxime.ripard@free-electrons.com, david@sigma-star.at,
	david@fromorbit.com, alex@nextthing.co, sasha.levin@oracle.com,
	iamjoonsoo.kim@lge.com, rvaswani@codeaurora.org,
	tony.luck@intel.com, shailendra.capricorn@gmail.com
Subject: Re: [PATCH 1/3] mm: Don't blindly assign fallback_migrate_page()
Date: Thu, 23 Jun 2016 00:21:11 +0200	[thread overview]
Message-ID: <576B0F57.3030700@nod.at> (raw)
In-Reply-To: <20160616161121.35ee5183b9ef9f7b7dcbc815@linux-foundation.org>

Am 17.06.2016 um 01:11 schrieb Andrew Morton:
> On Thu, 16 Jun 2016 23:26:13 +0200 Richard Weinberger <richard@nod.at> wrote:
> 
>> While block oriented filesystems use buffer_migrate_page()
>> as page migration function other filesystems which don't
>> implement ->migratepage() will automatically get fallback_migrate_page()
>> assigned. fallback_migrate_page() is not as generic as is should
>> be. Page migration is filesystem specific and a one-fits-all function
>> is hard to achieve. UBIFS leaned this lection the hard way.
>> It uses various page flags and fallback_migrate_page() does not
>> handle these flags as UBIFS expected.
>>
>> To make sure that no further filesystem will get confused by
>> fallback_migrate_page() disable the automatic assignment and
>> allow filesystems to use this function explicitly if it is
>> really suitable.
> 
> hm, is there really much point in doing this?  I assume it doesn't
> actually affect any current filesystems?
> 
> [2/3] is of course OK - please add it to the UBIFS tree.

Pushed 2/3 and 3/3 into UBIFS next tree.

Thanks,
//richard

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2016-06-22 22:21 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-16 21:26 Remove page migration fallback (was: UBIFS and page migration) Richard Weinberger
2016-06-16 21:26 ` Richard Weinberger
2016-06-16 21:26 ` [PATCH 1/3] mm: Don't blindly assign fallback_migrate_page() Richard Weinberger
2016-06-16 21:26   ` Richard Weinberger
2016-06-16 23:11   ` Andrew Morton
2016-06-16 23:11     ` Andrew Morton
2016-06-17  7:41     ` Richard Weinberger
2016-06-17  7:41       ` Richard Weinberger
2016-06-17 16:28       ` Michal Hocko
2016-06-17 16:28         ` Michal Hocko
2016-06-17 16:55         ` Richard Weinberger
2016-06-17 16:55           ` Richard Weinberger
2016-06-17 18:27           ` Michal Hocko
2016-06-17 18:27             ` Michal Hocko
2016-06-17 19:36             ` Richard Weinberger
2016-06-17 19:36               ` Richard Weinberger
2016-06-17 20:03               ` Michal Hocko
2016-06-17 20:03                 ` Michal Hocko
2016-06-22 22:21     ` Richard Weinberger [this message]
2016-06-22 22:21       ` Richard Weinberger
2016-06-16 21:26 ` [PATCH 2/3] mm: Export migrate_page_move_mapping and migrate_page_copy Richard Weinberger
2016-06-16 21:26   ` Richard Weinberger
2016-06-16 21:26 ` [PATCH 3/3] UBIFS: Implement ->migratepage() Richard Weinberger
2016-06-16 21:26   ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=576B0F57.3030700@nod.at \
    --to=richard@nod.at \
    --cc=adrian.hunter@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=alex@nextthing.co \
    --cc=boris.brezillon@free-electrons.com \
    --cc=david@fromorbit.com \
    --cc=david@sigma-star.at \
    --cc=dedekind1@gmail.com \
    --cc=hannes@cmpxchg.org \
    --cc=hch@infradead.org \
    --cc=hughd@google.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=maxime.ripard@free-electrons.com \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@suse.com \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=rvaswani@codeaurora.org \
    --cc=sasha.levin@oracle.com \
    --cc=shailendra.capricorn@gmail.com \
    --cc=tony.luck@intel.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.