* [PATCH] selftests/lib: set printf.sh executable
@ 2016-06-18 9:28 SeongJae Park
2016-06-18 17:50 ` Kees Cook
0 siblings, 1 reply; 4+ messages in thread
From: SeongJae Park @ 2016-06-18 9:28 UTC (permalink / raw)
To: shuahkh
Cc: keescook, adriy.shevchenko, linux-kselftest, linux-kernel,
SeongJae Park
Test for test_printf module fails always because the test program,
printf.sh, has no execution permission. This commit adds execution
permission to it.
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
tools/testing/selftests/lib/printf.sh | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100644 => 100755 tools/testing/selftests/lib/printf.sh
diff --git a/tools/testing/selftests/lib/printf.sh b/tools/testing/selftests/lib/printf.sh
old mode 100644
new mode 100755
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/lib: set printf.sh executable
2016-06-18 9:28 [PATCH] selftests/lib: set printf.sh executable SeongJae Park
@ 2016-06-18 17:50 ` Kees Cook
2016-06-24 23:56 ` SeongJae Park
0 siblings, 1 reply; 4+ messages in thread
From: Kees Cook @ 2016-06-18 17:50 UTC (permalink / raw)
To: SeongJae Park; +Cc: Shuah Khan, adriy.shevchenko, linux-kselftest, LKML
On Sat, Jun 18, 2016 at 2:28 AM, SeongJae Park <sj38.park@gmail.com> wrote:
> Test for test_printf module fails always because the test program,
> printf.sh, has no execution permission. This commit adds execution
> permission to it.
>
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
Acked-by: Kees Cook <keescook@chromium.org>
(Is this mode change sufficient, or does the selftest infrastructure
need to explicitly set it executable when running?)
-Kees
> ---
> tools/testing/selftests/lib/printf.sh | 0
> 1 file changed, 0 insertions(+), 0 deletions(-)
> mode change 100644 => 100755 tools/testing/selftests/lib/printf.sh
>
> diff --git a/tools/testing/selftests/lib/printf.sh b/tools/testing/selftests/lib/printf.sh
> old mode 100644
> new mode 100755
> --
> 1.9.1
>
--
Kees Cook
Chrome OS & Brillo Security
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/lib: set printf.sh executable
2016-06-18 17:50 ` Kees Cook
@ 2016-06-24 23:56 ` SeongJae Park
2016-06-25 0:08 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: SeongJae Park @ 2016-06-24 23:56 UTC (permalink / raw)
To: Shuah Khan; +Cc: Kees Cook, adriy.shevchenko, linux-kselftest, LKML
Shuah,
May I ask your opinion about this patch?
Thanks,
SeongJae Park
On Sun, Jun 19, 2016 at 2:50 AM, Kees Cook <keescook@chromium.org> wrote:
> On Sat, Jun 18, 2016 at 2:28 AM, SeongJae Park <sj38.park@gmail.com> wrote:
>> Test for test_printf module fails always because the test program,
>> printf.sh, has no execution permission. This commit adds execution
>> permission to it.
>>
>> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
>
> Acked-by: Kees Cook <keescook@chromium.org>
>
> (Is this mode change sufficient, or does the selftest infrastructure
> need to explicitly set it executable when running?)
>
> -Kees
>
>
>> ---
>> tools/testing/selftests/lib/printf.sh | 0
>> 1 file changed, 0 insertions(+), 0 deletions(-)
>> mode change 100644 => 100755 tools/testing/selftests/lib/printf.sh
>>
>> diff --git a/tools/testing/selftests/lib/printf.sh b/tools/testing/selftests/lib/printf.sh
>> old mode 100644
>> new mode 100755
>> --
>> 1.9.1
>>
>
>
>
> --
> Kees Cook
> Chrome OS & Brillo Security
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/lib: set printf.sh executable
2016-06-24 23:56 ` SeongJae Park
@ 2016-06-25 0:08 ` Shuah Khan
0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2016-06-25 0:08 UTC (permalink / raw)
To: SeongJae Park, Kees Cook
Cc: adriy.shevchenko, linux-kselftest, LKML, shuah Khan
Hi SeongJae Park,
Thanks for the ping.
On 06/24/2016 05:56 PM, SeongJae Park wrote:
> Shuah,
>
>
> May I ask your opinion about this patch?
>
>
> Thanks,
> SeongJae Park
>
> On Sun, Jun 19, 2016 at 2:50 AM, Kees Cook <keescook@chromium.org> wrote:
>> On Sat, Jun 18, 2016 at 2:28 AM, SeongJae Park <sj38.park@gmail.com> wrote:
>>> Test for test_printf module fails always because the test program,
>>> printf.sh, has no execution permission. This commit adds execution
>>> permission to it.
>>>
>>> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
>>
>> Acked-by: Kees Cook <keescook@chromium.org>
>>
>> (Is this mode change sufficient, or does the selftest infrastructure
>> need to explicitly set it executable when running?)
This is good and makes it consistent with bitmap.sh the other
shell script in this test suite. I will get this into 4.8-rc1
thanks,
-- Shuah
>>
>> -Kees
>>
>>
>>> ---
>>> tools/testing/selftests/lib/printf.sh | 0
>>> 1 file changed, 0 insertions(+), 0 deletions(-)
>>> mode change 100644 => 100755 tools/testing/selftests/lib/printf.sh
>>>
>>> diff --git a/tools/testing/selftests/lib/printf.sh b/tools/testing/selftests/lib/printf.sh
>>> old mode 100644
>>> new mode 100755
>>> --
>>> 1.9.1
>>>
>>
>>
>>
>> --
>> Kees Cook
>> Chrome OS & Brillo Security
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-06-25 0:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-18 9:28 [PATCH] selftests/lib: set printf.sh executable SeongJae Park
2016-06-18 17:50 ` Kees Cook
2016-06-24 23:56 ` SeongJae Park
2016-06-25 0:08 ` Shuah Khan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.