All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@codeaurora.org>
To: Christopher Covington <cov@codeaurora.org>,
	Andy Gross <andy.gross@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
	linux-arm-msm@vger.kernel.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: pelcan@codeaurora.org, okaya@codeaurora.org
Subject: Re: [PATCH] arm64: defconfig: Enable QDF2432 config options
Date: Fri, 1 Jul 2016 09:14:25 -0500	[thread overview]
Message-ID: <57767AC1.3070209@codeaurora.org> (raw)
In-Reply-To: <1467382327-9726-1-git-send-email-cov@codeaurora.org>

Christopher Covington wrote:
>   arch/arm64/configs/defconfig |  4 ++++
>   scripts/patch-details.sh     | 21 ++++++++++++++++++---

I don't think these two files should be combined.

>  CONFIG_PINCTRL_SINGLE=y
>  CONFIG_PINCTRL_MSM8916=y
> +CONFIG_PINCTRL_QDF2XXX=m
>  CONFIG_PINCTRL_QCOM_SPMI_PMIC=y
>  CONFIG_GPIO_SYSFS=y
>  CONFIG_GPIO_DWAPB=y
> @@ -245,6 +246,7 @@ CONFIG_MMC=y
>  CONFIG_MMC_BLOCK_MINORS=32
>  CONFIG_MMC_ARMMMCI=y
>  CONFIG_MMC_SDHCI=y
> +CONFIG_MMC_SDHCI_ACPI=m
>  CONFIG_MMC_SDHCI_PLTFM=y

Why are these =m when all the others are =y?

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.

WARNING: multiple messages have this Message-ID (diff)
From: timur@codeaurora.org (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: defconfig: Enable QDF2432 config options
Date: Fri, 1 Jul 2016 09:14:25 -0500	[thread overview]
Message-ID: <57767AC1.3070209@codeaurora.org> (raw)
In-Reply-To: <1467382327-9726-1-git-send-email-cov@codeaurora.org>

Christopher Covington wrote:
>   arch/arm64/configs/defconfig |  4 ++++
>   scripts/patch-details.sh     | 21 ++++++++++++++++++---

I don't think these two files should be combined.

>  CONFIG_PINCTRL_SINGLE=y
>  CONFIG_PINCTRL_MSM8916=y
> +CONFIG_PINCTRL_QDF2XXX=m
>  CONFIG_PINCTRL_QCOM_SPMI_PMIC=y
>  CONFIG_GPIO_SYSFS=y
>  CONFIG_GPIO_DWAPB=y
> @@ -245,6 +246,7 @@ CONFIG_MMC=y
>  CONFIG_MMC_BLOCK_MINORS=32
>  CONFIG_MMC_ARMMMCI=y
>  CONFIG_MMC_SDHCI=y
> +CONFIG_MMC_SDHCI_ACPI=m
>  CONFIG_MMC_SDHCI_PLTFM=y

Why are these =m when all the others are =y?

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.

  reply	other threads:[~2016-07-01 14:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-01 14:12 [PATCH] arm64: defconfig: Enable QDF2432 config options Christopher Covington
2016-07-01 14:12 ` Christopher Covington
2016-07-01 14:14 ` Timur Tabi [this message]
2016-07-01 14:14   ` Timur Tabi
2016-07-01 15:06   ` Christopher Covington
2016-07-01 15:06     ` Christopher Covington
2016-07-01 15:11     ` Timur Tabi
2016-07-01 15:11       ` Timur Tabi
2016-08-23 20:36       ` Andy Gross
2016-08-23 20:36         ` Andy Gross
2016-08-23 20:36         ` Timur Tabi
2016-08-23 20:36           ` Timur Tabi
2016-08-23 20:36           ` Timur Tabi
2016-07-01 14:27 ` [PATCH v2] " Christopher Covington
2016-07-01 14:27   ` Christopher Covington

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57767AC1.3070209@codeaurora.org \
    --to=timur@codeaurora.org \
    --cc=andy.gross@linaro.org \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=cov@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=okaya@codeaurora.org \
    --cc=pelcan@codeaurora.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.