From: Christopher Covington <cov@codeaurora.org>
To: Timur Tabi <timur@codeaurora.org>,
Andy Gross <andy.gross@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
linux-arm-msm@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: pelcan@codeaurora.org, okaya@codeaurora.org
Subject: Re: [PATCH] arm64: defconfig: Enable QDF2432 config options
Date: Fri, 1 Jul 2016 11:06:35 -0400 [thread overview]
Message-ID: <577686FB.5040709@codeaurora.org> (raw)
In-Reply-To: <57767AC1.3070209@codeaurora.org>
On 07/01/2016 10:14 AM, Timur Tabi wrote:
> Christopher Covington wrote:
>> arch/arm64/configs/defconfig | 4 ++++
>> scripts/patch-details.sh | 21 ++++++++++++++++++---
>
> I don't think these two files should be combined.
Oops, sorry. Fixed in v2.
>> CONFIG_PINCTRL_SINGLE=y
>> CONFIG_PINCTRL_MSM8916=y
>> +CONFIG_PINCTRL_QDF2XXX=m
>> CONFIG_PINCTRL_QCOM_SPMI_PMIC=y
>> CONFIG_GPIO_SYSFS=y
>> CONFIG_GPIO_DWAPB=y
>> @@ -245,6 +246,7 @@ CONFIG_MMC=y
>> CONFIG_MMC_BLOCK_MINORS=32
>> CONFIG_MMC_ARMMMCI=y
>> CONFIG_MMC_SDHCI=y
>> +CONFIG_MMC_SDHCI_ACPI=m
>> CONFIG_MMC_SDHCI_PLTFM=y
>
> Why are these =m when all the others are =y?
Due to distribution differences [1][2], I see =y built-in as the default
on mobile platforms and =m modular as the default on server platforms.
But thinking about it, we could get a poweroff, reset, over-temperature,
or other interrupt before we get to the initramfs. So the pin controller
driver should be =y built-in.
One might make rootfs media =y built-in to make testing easier, but I
prefer to put my rootfs on SATA, as SD/MMC is much slower and smaller by
comparison.
Thanks,
Cov
Examples I found to spot check my recollection:
1.
https://github.com/CyanogenMod/android_kernel_lge_hammerhead/blob/cm-13.0/arch/arm/configs/cyanogenmod_hammerhead_defconfig
2.
https://git.centos.org/blob/sig-altarch!kernel.git/c3cb6cc6edb5400321fd9d83413add4cf61d942e/SOURCES!config-arm64
--
Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: cov@codeaurora.org (Christopher Covington)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: defconfig: Enable QDF2432 config options
Date: Fri, 1 Jul 2016 11:06:35 -0400 [thread overview]
Message-ID: <577686FB.5040709@codeaurora.org> (raw)
In-Reply-To: <57767AC1.3070209@codeaurora.org>
On 07/01/2016 10:14 AM, Timur Tabi wrote:
> Christopher Covington wrote:
>> arch/arm64/configs/defconfig | 4 ++++
>> scripts/patch-details.sh | 21 ++++++++++++++++++---
>
> I don't think these two files should be combined.
Oops, sorry. Fixed in v2.
>> CONFIG_PINCTRL_SINGLE=y
>> CONFIG_PINCTRL_MSM8916=y
>> +CONFIG_PINCTRL_QDF2XXX=m
>> CONFIG_PINCTRL_QCOM_SPMI_PMIC=y
>> CONFIG_GPIO_SYSFS=y
>> CONFIG_GPIO_DWAPB=y
>> @@ -245,6 +246,7 @@ CONFIG_MMC=y
>> CONFIG_MMC_BLOCK_MINORS=32
>> CONFIG_MMC_ARMMMCI=y
>> CONFIG_MMC_SDHCI=y
>> +CONFIG_MMC_SDHCI_ACPI=m
>> CONFIG_MMC_SDHCI_PLTFM=y
>
> Why are these =m when all the others are =y?
Due to distribution differences [1][2], I see =y built-in as the default
on mobile platforms and =m modular as the default on server platforms.
But thinking about it, we could get a poweroff, reset, over-temperature,
or other interrupt before we get to the initramfs. So the pin controller
driver should be =y built-in.
One might make rootfs media =y built-in to make testing easier, but I
prefer to put my rootfs on SATA, as SD/MMC is much slower and smaller by
comparison.
Thanks,
Cov
Examples I found to spot check my recollection:
1.
https://github.com/CyanogenMod/android_kernel_lge_hammerhead/blob/cm-13.0/arch/arm/configs/cyanogenmod_hammerhead_defconfig
2.
https://git.centos.org/blob/sig-altarch!kernel.git/c3cb6cc6edb5400321fd9d83413add4cf61d942e/SOURCES!config-arm64
--
Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-07-01 15:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 14:12 [PATCH] arm64: defconfig: Enable QDF2432 config options Christopher Covington
2016-07-01 14:12 ` Christopher Covington
2016-07-01 14:14 ` Timur Tabi
2016-07-01 14:14 ` Timur Tabi
2016-07-01 15:06 ` Christopher Covington [this message]
2016-07-01 15:06 ` Christopher Covington
2016-07-01 15:11 ` Timur Tabi
2016-07-01 15:11 ` Timur Tabi
2016-08-23 20:36 ` Andy Gross
2016-08-23 20:36 ` Andy Gross
2016-08-23 20:36 ` Timur Tabi
2016-08-23 20:36 ` Timur Tabi
2016-08-23 20:36 ` Timur Tabi
2016-07-01 14:27 ` [PATCH v2] " Christopher Covington
2016-07-01 14:27 ` Christopher Covington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577686FB.5040709@codeaurora.org \
--to=cov@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=pelcan@codeaurora.org \
--cc=timur@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.