From: Chanwoo Choi <cw00.choi@samsung.com>
To: Seung-Woo Kim <sw0312.kim@samsung.com>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, k.kozlowski@samsung.com,
kgene@kernel.org
Subject: Re: [PATCH] memory: samsung: exynos-srom: fix wrong count of registers
Date: Wed, 06 Jul 2016 09:12:18 +0900 [thread overview]
Message-ID: <577C4CE2.2090103@samsung.com> (raw)
In-Reply-To: <1467718817-19239-1-git-send-email-sw0312.kim@samsung.com>
On 2016년 07월 05일 20:40, Seung-Woo Kim wrote:
> This patch fixes wrong count of array for srom registers from probe
> function.
>
> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> ---
> drivers/memory/samsung/exynos-srom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memory/samsung/exynos-srom.c b/drivers/memory/samsung/exynos-srom.c
> index 96756fb..c66d2bd 100644
> --- a/drivers/memory/samsung/exynos-srom.c
> +++ b/drivers/memory/samsung/exynos-srom.c
> @@ -134,7 +134,7 @@ static int exynos_srom_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, srom);
>
> srom->reg_offset = exynos_srom_alloc_reg_dump(exynos_srom_offsets,
> - sizeof(exynos_srom_offsets));
> + ARRAY_SIZE(exynos_srom_offsets));
> if (!srom->reg_offset) {
> iounmap(srom->reg_base);
> return -ENOMEM;
>
On the exynos-srom.c, use the ARRAY_SIZE to get the number of array entry.
Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Thanks,
Chanwoo Choi
WARNING: multiple messages have this Message-ID (diff)
From: cw00.choi@samsung.com (Chanwoo Choi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] memory: samsung: exynos-srom: fix wrong count of registers
Date: Wed, 06 Jul 2016 09:12:18 +0900 [thread overview]
Message-ID: <577C4CE2.2090103@samsung.com> (raw)
In-Reply-To: <1467718817-19239-1-git-send-email-sw0312.kim@samsung.com>
On 2016? 07? 05? 20:40, Seung-Woo Kim wrote:
> This patch fixes wrong count of array for srom registers from probe
> function.
>
> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> ---
> drivers/memory/samsung/exynos-srom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memory/samsung/exynos-srom.c b/drivers/memory/samsung/exynos-srom.c
> index 96756fb..c66d2bd 100644
> --- a/drivers/memory/samsung/exynos-srom.c
> +++ b/drivers/memory/samsung/exynos-srom.c
> @@ -134,7 +134,7 @@ static int exynos_srom_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, srom);
>
> srom->reg_offset = exynos_srom_alloc_reg_dump(exynos_srom_offsets,
> - sizeof(exynos_srom_offsets));
> + ARRAY_SIZE(exynos_srom_offsets));
> if (!srom->reg_offset) {
> iounmap(srom->reg_base);
> return -ENOMEM;
>
On the exynos-srom.c, use the ARRAY_SIZE to get the number of array entry.
Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Thanks,
Chanwoo Choi
next prev parent reply other threads:[~2016-07-06 0:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20160705114058epcas1p103f3f6d7cd39bf6d99f36f0fea2493f0@epcas1p1.samsung.com>
2016-07-05 11:40 ` [PATCH] memory: samsung: exynos-srom: fix wrong count of registers Seung-Woo Kim
2016-07-05 11:40 ` Seung-Woo Kim
2016-07-06 0:12 ` Chanwoo Choi [this message]
2016-07-06 0:12 ` Chanwoo Choi
2016-07-06 6:17 ` Krzysztof Kozlowski
2016-07-06 6:17 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577C4CE2.2090103@samsung.com \
--to=cw00.choi@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.