From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Craig Gallek <kraigatgoog@gmail.com>
Cc: kvm@vger.kernel.org, Eric Dumazet <eric.dumazet@gmail.com>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
virtualization@lists.linux-foundation.org, brouer@redhat.com,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next V4 0/6] switch to use tx skb array in tun
Date: Fri, 8 Jul 2016 17:14:19 +0800 [thread overview]
Message-ID: <577F6EEB.9080908@redhat.com> (raw)
In-Reply-To: <20160708091855-mutt-send-email-mst@redhat.com>
On 2016年07月08日 14:19, Michael S. Tsirkin wrote:
> On Wed, Jul 06, 2016 at 01:45:58PM -0400, Craig Gallek wrote:
>> >On Thu, Jun 30, 2016 at 2:45 AM, Jason Wang<jasowang@redhat.com> wrote:
>>> > >Hi all:
>>> > >
>>> > >This series tries to switch to use skb array in tun. This is used to
>>> > >eliminate the spinlock contention between producer and consumer. The
>>> > >conversion was straightforward: just introdce a tx skb array and use
>>> > >it instead of sk_receive_queue.
>> >
>> >I'm seeing the splat below after this series. I'm still wrapping my
>> >head around this code, but it appears to be happening because the
>> >tun_struct passed into tun_queue_resize is uninitialized.
>> >Specifically, iteration over the disabled list_head fails because prev
>> >= next = NULL. This seems to happen when a startup script on my test
>> >machine changes the queue length. I'll try to figure out what's
>> >happening, but if it's obvious to someone else from the stack, please
>> >let me know.
> Don't see anything obvious. I'm traveling, will look at it when I'm back
> unless it's fixed by then. Jason, any idea?
>
Looks like Craig has posted a fix to this:
http://patchwork.ozlabs.org/patch/645645/
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Craig Gallek <kraigatgoog@gmail.com>
Cc: netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
Eric Dumazet <eric.dumazet@gmail.com>,
brouer@redhat.com
Subject: Re: [PATCH net-next V4 0/6] switch to use tx skb array in tun
Date: Fri, 8 Jul 2016 17:14:19 +0800 [thread overview]
Message-ID: <577F6EEB.9080908@redhat.com> (raw)
In-Reply-To: <20160708091855-mutt-send-email-mst@redhat.com>
On 2016年07月08日 14:19, Michael S. Tsirkin wrote:
> On Wed, Jul 06, 2016 at 01:45:58PM -0400, Craig Gallek wrote:
>> >On Thu, Jun 30, 2016 at 2:45 AM, Jason Wang<jasowang@redhat.com> wrote:
>>> > >Hi all:
>>> > >
>>> > >This series tries to switch to use skb array in tun. This is used to
>>> > >eliminate the spinlock contention between producer and consumer. The
>>> > >conversion was straightforward: just introdce a tx skb array and use
>>> > >it instead of sk_receive_queue.
>> >
>> >I'm seeing the splat below after this series. I'm still wrapping my
>> >head around this code, but it appears to be happening because the
>> >tun_struct passed into tun_queue_resize is uninitialized.
>> >Specifically, iteration over the disabled list_head fails because prev
>> >= next = NULL. This seems to happen when a startup script on my test
>> >machine changes the queue length. I'll try to figure out what's
>> >happening, but if it's obvious to someone else from the stack, please
>> >let me know.
> Don't see anything obvious. I'm traveling, will look at it when I'm back
> unless it's fixed by then. Jason, any idea?
>
Looks like Craig has posted a fix to this:
http://patchwork.ozlabs.org/patch/645645/
next prev parent reply other threads:[~2016-07-08 9:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 17:45 [PATCH net-next V4 0/6] switch to use tx skb array in tun Craig Gallek
2016-07-08 6:19 ` Michael S. Tsirkin
2016-07-08 6:19 ` Michael S. Tsirkin
2016-07-08 9:14 ` Jason Wang [this message]
2016-07-08 9:14 ` Jason Wang
2016-07-08 6:19 ` Michael S. Tsirkin
2016-07-08 6:19 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2016-07-06 17:45 Craig Gallek
2016-06-30 6:45 Jason Wang
2016-06-30 15:45 ` Michael S. Tsirkin
2016-07-01 6:04 ` Jason Wang
2016-07-01 6:04 ` Jason Wang
2016-06-30 15:45 ` Michael S. Tsirkin
2016-07-01 9:40 ` David Miller
2016-07-01 9:40 ` David Miller
2016-06-30 6:45 Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577F6EEB.9080908@redhat.com \
--to=jasowang@redhat.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kraigatgoog@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.