All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kvm@vger.kernel.org, eric.dumazet@gmail.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, brouer@redhat.com,
	davem@davemloft.net
Subject: Re: [PATCH net-next V4 0/6] switch to use tx skb array in tun
Date: Fri, 1 Jul 2016 14:04:01 +0800	[thread overview]
Message-ID: <577607D1.9070307@redhat.com> (raw)
In-Reply-To: <20160630184242-mutt-send-email-mst@redhat.com>



On 2016年06月30日 23:45, Michael S. Tsirkin wrote:
> On Thu, Jun 30, 2016 at 02:45:30PM +0800, Jason Wang wrote:
>> >Hi all:
>> >
>> >This series tries to switch to use skb array in tun. This is used to
>> >eliminate the spinlock contention between producer and consumer. The
>> >conversion was straightforward: just introdce a tx skb array and use
>> >it instead of sk_receive_queue.
>> >
>> >A minor issue is to keep the tx_queue_len behaviour, since tun used to
>> >use it for the length of sk_receive_queue. This is done through:
>> >
>> >- add the ability to resize multiple rings at once to avoid handling
>> >   partial resize failure for mutiple rings.
>> >- add the support for zero length ring.
>> >- introduce a notifier which was triggered when tx_queue_len was
>> >   changed for a netdev.
>> >- resize all queues during the tx_queue_len changing.
>> >
>> >Tests shows about 15% improvement on guest rx pps:
>> >
>> >Before: ~1300000pps
>> >After : ~1500000pps
> Acked-by: Michael S. Tsirkin<mst@redhat.com>
>
> Acked-from-altitude: 34697 feet.

Wow, thanks a lot!
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	davem@davemloft.net, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	eric.dumazet@gmail.com, brouer@redhat.com
Subject: Re: [PATCH net-next V4 0/6] switch to use tx skb array in tun
Date: Fri, 1 Jul 2016 14:04:01 +0800	[thread overview]
Message-ID: <577607D1.9070307@redhat.com> (raw)
In-Reply-To: <20160630184242-mutt-send-email-mst@redhat.com>



On 2016年06月30日 23:45, Michael S. Tsirkin wrote:
> On Thu, Jun 30, 2016 at 02:45:30PM +0800, Jason Wang wrote:
>> >Hi all:
>> >
>> >This series tries to switch to use skb array in tun. This is used to
>> >eliminate the spinlock contention between producer and consumer. The
>> >conversion was straightforward: just introdce a tx skb array and use
>> >it instead of sk_receive_queue.
>> >
>> >A minor issue is to keep the tx_queue_len behaviour, since tun used to
>> >use it for the length of sk_receive_queue. This is done through:
>> >
>> >- add the ability to resize multiple rings at once to avoid handling
>> >   partial resize failure for mutiple rings.
>> >- add the support for zero length ring.
>> >- introduce a notifier which was triggered when tx_queue_len was
>> >   changed for a netdev.
>> >- resize all queues during the tx_queue_len changing.
>> >
>> >Tests shows about 15% improvement on guest rx pps:
>> >
>> >Before: ~1300000pps
>> >After : ~1500000pps
> Acked-by: Michael S. Tsirkin<mst@redhat.com>
>
> Acked-from-altitude: 34697 feet.

Wow, thanks a lot!

  reply	other threads:[~2016-07-01  6:04 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-30  6:45 [PATCH net-next V4 0/6] switch to use tx skb array in tun Jason Wang
2016-06-30  6:45 ` [PATCH net-next V4 1/6] ptr_ring: support zero length ring Jason Wang
2016-06-30  6:45   ` Jason Wang
2016-06-30  6:45 ` [PATCH net-next V4 2/6] skb_array: minor tweak Jason Wang
2016-06-30  6:45   ` Jason Wang
2016-06-30  6:45 ` [PATCH net-next V4 3/6] ptr_ring: support resizing multiple queues Jason Wang
2016-06-30  6:45   ` Jason Wang
2016-06-30  6:45 ` [PATCH net-next V4 4/6] skb_array: add wrappers for resizing Jason Wang
2016-06-30  6:45   ` Jason Wang
2016-06-30  6:45 ` [PATCH net-next V4 5/6] net: introduce NETDEV_CHANGE_TX_QUEUE_LEN Jason Wang
2016-06-30  6:45   ` Jason Wang
2016-06-30 16:33   ` John Fastabend
2016-06-30 16:33   ` John Fastabend
2016-06-30  6:45 ` [PATCH net-next V4 6/6] tun: switch to use skb array for tx Jason Wang
2016-06-30  6:45 ` Jason Wang
2016-06-30 15:45 ` [PATCH net-next V4 0/6] switch to use tx skb array in tun Michael S. Tsirkin
2016-07-01  6:04   ` Jason Wang [this message]
2016-07-01  6:04     ` Jason Wang
2016-06-30 15:45 ` Michael S. Tsirkin
2016-07-01  9:40 ` David Miller
2016-07-01  9:40   ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2016-07-06 17:45 Craig Gallek
2016-07-06 17:45 Craig Gallek
2016-07-08  6:19 ` Michael S. Tsirkin
2016-07-08  6:19   ` Michael S. Tsirkin
2016-07-08  9:14   ` Jason Wang
2016-07-08  9:14     ` Jason Wang
2016-07-08  6:19 ` Michael S. Tsirkin
2016-07-08  6:19 ` Michael S. Tsirkin
2016-06-30  6:45 Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=577607D1.9070307@redhat.com \
    --to=jasowang@redhat.com \
    --cc=brouer@redhat.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.