All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luis de Bethencourt <luisbg@osg.samsung.com>
To: Samuele Baisi <ciccio87@gmail.com>, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: gdm724x: gdm_tty: Fixed a checkpatch check issue.
Date: Fri, 08 Jul 2016 19:17:41 +0100	[thread overview]
Message-ID: <577FEE45.5070509@osg.samsung.com> (raw)
In-Reply-To: <1467718439-13271-1-git-send-email-ciccio87@gmail.com>

On 05/07/16 12:33, Samuele Baisi wrote:
> Removed a blankline after an opening bracket.
> 
> Signed-off-by: Samuele Baisi <ciccio87@gmail.com>
> ---
>  drivers/staging/gdm724x/gdm_tty.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index eb7e252..ae39663 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -225,7 +225,6 @@ int register_lte_tty_device(struct tty_dev *tty_dev, struct device *device)
>  	int j;
>  
>  	for (i = 0; i < TTY_MAX_COUNT; i++) {
> -
>  		gdm = kmalloc(sizeof(*gdm), GFP_KERNEL);
>  		if (!gdm)
>  			return -ENOMEM;
> 

Patch applies cleanly and removes the checkpath issue.

Acked-by: Luis de Bethencourt <luisbg@osg.samsung.com>

Samuele,

It is a good idea to include the issue you are solving in the commit
message, in this case it would be:

Removed a blankline after an opening bracket.

CHECK: Blank lines aren't necessary after an open brace '{'
#228: FILE: drivers/staging/gdm724x/gdm_tty.c:228:
+       for (i = 0; i < TTY_MAX_COUNT; i++) {
+

Signed-off-by:
---

Thanks :)
Luis

  reply	other threads:[~2016-07-08 18:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-05 11:33 [PATCH] Staging: gdm724x: gdm_tty: Fixed a checkpatch check issue Samuele Baisi
2016-07-08 18:17 ` Luis de Bethencourt [this message]
2016-07-08 19:32   ` Samuele Baisi
2016-07-08 19:48     ` Luis de Bethencourt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=577FEE45.5070509@osg.samsung.com \
    --to=luisbg@osg.samsung.com \
    --cc=ciccio87@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.