* [PATCH] Staging: gdm724x: gdm_tty: Fixed a checkpatch check issue.
@ 2016-07-05 11:33 Samuele Baisi
2016-07-08 18:17 ` Luis de Bethencourt
0 siblings, 1 reply; 4+ messages in thread
From: Samuele Baisi @ 2016-07-05 11:33 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Samuele Baisi
Removed a blankline after an opening bracket.
Signed-off-by: Samuele Baisi <ciccio87@gmail.com>
---
drivers/staging/gdm724x/gdm_tty.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
index eb7e252..ae39663 100644
--- a/drivers/staging/gdm724x/gdm_tty.c
+++ b/drivers/staging/gdm724x/gdm_tty.c
@@ -225,7 +225,6 @@ int register_lte_tty_device(struct tty_dev *tty_dev, struct device *device)
int j;
for (i = 0; i < TTY_MAX_COUNT; i++) {
-
gdm = kmalloc(sizeof(*gdm), GFP_KERNEL);
if (!gdm)
return -ENOMEM;
--
2.8.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Staging: gdm724x: gdm_tty: Fixed a checkpatch check issue.
2016-07-05 11:33 [PATCH] Staging: gdm724x: gdm_tty: Fixed a checkpatch check issue Samuele Baisi
@ 2016-07-08 18:17 ` Luis de Bethencourt
2016-07-08 19:32 ` Samuele Baisi
0 siblings, 1 reply; 4+ messages in thread
From: Luis de Bethencourt @ 2016-07-08 18:17 UTC (permalink / raw)
To: Samuele Baisi, gregkh; +Cc: devel, linux-kernel
On 05/07/16 12:33, Samuele Baisi wrote:
> Removed a blankline after an opening bracket.
>
> Signed-off-by: Samuele Baisi <ciccio87@gmail.com>
> ---
> drivers/staging/gdm724x/gdm_tty.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index eb7e252..ae39663 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -225,7 +225,6 @@ int register_lte_tty_device(struct tty_dev *tty_dev, struct device *device)
> int j;
>
> for (i = 0; i < TTY_MAX_COUNT; i++) {
> -
> gdm = kmalloc(sizeof(*gdm), GFP_KERNEL);
> if (!gdm)
> return -ENOMEM;
>
Patch applies cleanly and removes the checkpath issue.
Acked-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Samuele,
It is a good idea to include the issue you are solving in the commit
message, in this case it would be:
Removed a blankline after an opening bracket.
CHECK: Blank lines aren't necessary after an open brace '{'
#228: FILE: drivers/staging/gdm724x/gdm_tty.c:228:
+ for (i = 0; i < TTY_MAX_COUNT; i++) {
+
Signed-off-by:
---
Thanks :)
Luis
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Staging: gdm724x: gdm_tty: Fixed a checkpatch check issue.
2016-07-08 18:17 ` Luis de Bethencourt
@ 2016-07-08 19:32 ` Samuele Baisi
2016-07-08 19:48 ` Luis de Bethencourt
0 siblings, 1 reply; 4+ messages in thread
From: Samuele Baisi @ 2016-07-08 19:32 UTC (permalink / raw)
To: Luis de Bethencourt; +Cc: gregkh, devel, linux-kernel
Il giorno ven 8 lug 2016 alle 20:17, Luis de Bethencourt
<luisbg@osg.samsung.com> ha scritto:
> On 05/07/16 12:33, Samuele Baisi wrote:
>> Removed a blankline after an opening bracket.
>>
>> Signed-off-by: Samuele Baisi <ciccio87@gmail.com>
>> ---
>> drivers/staging/gdm724x/gdm_tty.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/staging/gdm724x/gdm_tty.c
>> b/drivers/staging/gdm724x/gdm_tty.c
>> index eb7e252..ae39663 100644
>> --- a/drivers/staging/gdm724x/gdm_tty.c
>> +++ b/drivers/staging/gdm724x/gdm_tty.c
>> @@ -225,7 +225,6 @@ int register_lte_tty_device(struct tty_dev
>> *tty_dev, struct device *device)
>> int j;
>>
>> for (i = 0; i < TTY_MAX_COUNT; i++) {
>> -
>> gdm = kmalloc(sizeof(*gdm), GFP_KERNEL);
>> if (!gdm)
>> return -ENOMEM;
>>
>
> Patch applies cleanly and removes the checkpath issue.
>
> Acked-by: Luis de Bethencourt <luisbg@osg.samsung.com>
>
> Samuele,
>
> It is a good idea to include the issue you are solving in the commit
> message, in this case it would be:
>
> Removed a blankline after an opening bracket.
>
> CHECK: Blank lines aren't necessary after an open brace '{'
> #228: FILE: drivers/staging/gdm724x/gdm_tty.c:228:
> + for (i = 0; i < TTY_MAX_COUNT; i++) {
> +
>
> Signed-off-by:
> ---
>
> Thanks :)
> Luis
Ok, next time I'll try to be more clear.
Thank you very much and best regards.
Samuele
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Staging: gdm724x: gdm_tty: Fixed a checkpatch check issue.
2016-07-08 19:32 ` Samuele Baisi
@ 2016-07-08 19:48 ` Luis de Bethencourt
0 siblings, 0 replies; 4+ messages in thread
From: Luis de Bethencourt @ 2016-07-08 19:48 UTC (permalink / raw)
To: Samuele Baisi; +Cc: gregkh, devel, linux-kernel
On 08/07/16 20:32, Samuele Baisi wrote:
>
>
> Il giorno ven 8 lug 2016 alle 20:17, Luis de Bethencourt <luisbg@osg.samsung.com> ha scritto:
>> On 05/07/16 12:33, Samuele Baisi wrote:
>>> Removed a blankline after an opening bracket.
>>>
>>> Signed-off-by: Samuele Baisi <ciccio87@gmail.com>
>>> ---
>>> drivers/staging/gdm724x/gdm_tty.c | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
>>> index eb7e252..ae39663 100644
>>> --- a/drivers/staging/gdm724x/gdm_tty.c
>>> +++ b/drivers/staging/gdm724x/gdm_tty.c
>>> @@ -225,7 +225,6 @@ int register_lte_tty_device(struct tty_dev *tty_dev, struct device *device)
>>> int j;
>>>
>>> for (i = 0; i < TTY_MAX_COUNT; i++) {
>>> -
>>> gdm = kmalloc(sizeof(*gdm), GFP_KERNEL);
>>> if (!gdm)
>>> return -ENOMEM;
>>>
>>
>> Patch applies cleanly and removes the checkpath issue.
>>
>> Acked-by: Luis de Bethencourt <luisbg@osg.samsung.com>
>>
>> Samuele,
>>
>> It is a good idea to include the issue you are solving in the commit
>> message, in this case it would be:
>>
>> Removed a blankline after an opening bracket.
>>
>> CHECK: Blank lines aren't necessary after an open brace '{'
>> #228: FILE: drivers/staging/gdm724x/gdm_tty.c:228:
>> + for (i = 0; i < TTY_MAX_COUNT; i++) {
>> +
>>
>> Signed-off-by:
>> ---
>>
>> Thanks :)
>> Luis
>
> Ok, next time I'll try to be more clear.
>
> Thank you very much and best regards.
>
> Samuele
>
No problem Samuele.
Looking forward to more patches from you soon :)
Feel free to CC me in them.
Luis
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-08 19:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-05 11:33 [PATCH] Staging: gdm724x: gdm_tty: Fixed a checkpatch check issue Samuele Baisi
2016-07-08 18:17 ` Luis de Bethencourt
2016-07-08 19:32 ` Samuele Baisi
2016-07-08 19:48 ` Luis de Bethencourt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.