From: Heiko Stuebner <heiko@sntech.de>
To: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Joel Stanley" <joel@jms.id.au>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org,
"Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Subject: Re: [PATCH 3/3] iio: adc: rockchip: Simplify probe() with local 'dev'
Date: Mon, 22 Dec 2025 12:50:07 +0100 [thread overview]
Message-ID: <5782401.ejJDZkT8p0@phil> (raw)
In-Reply-To: <20251221142602.47368-6-krzysztof.kozlowski@oss.qualcomm.com>
Am Sonntag, 21. Dezember 2025, 15:26:05 Mitteleuropäische Normalzeit schrieb Krzysztof Kozlowski:
> Simplify the probe function by using a local 'dev' variable instead of
> full pointer dereference. This makes several lines shorter, which
> allows to avoid wrapping making code more readable.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Yep, makes the code definitly nicer to read
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Joel Stanley" <joel@jms.id.au>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org,
"Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Subject: Re: [PATCH 3/3] iio: adc: rockchip: Simplify probe() with local 'dev'
Date: Mon, 22 Dec 2025 12:50:07 +0100 [thread overview]
Message-ID: <5782401.ejJDZkT8p0@phil> (raw)
In-Reply-To: <20251221142602.47368-6-krzysztof.kozlowski@oss.qualcomm.com>
Am Sonntag, 21. Dezember 2025, 15:26:05 Mitteleuropäische Normalzeit schrieb Krzysztof Kozlowski:
> Simplify the probe function by using a local 'dev' variable instead of
> full pointer dereference. This makes several lines shorter, which
> allows to avoid wrapping making code more readable.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Yep, makes the code definitly nicer to read
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-12-22 12:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-21 14:26 [PATCH 1/3] iio: adc: aspeed: Simplify probe() with local 'dev' and 'np' Krzysztof Kozlowski
2025-12-21 14:26 ` Krzysztof Kozlowski
2025-12-21 14:26 ` [PATCH 2/3] iio: adc: exynos: " Krzysztof Kozlowski
2025-12-21 14:26 ` Krzysztof Kozlowski
2025-12-21 14:26 ` [PATCH 3/3] iio: adc: rockchip: Simplify probe() with local 'dev' Krzysztof Kozlowski
2025-12-21 14:26 ` Krzysztof Kozlowski
2025-12-22 11:50 ` Heiko Stuebner [this message]
2025-12-22 11:50 ` Heiko Stuebner
2025-12-27 17:43 ` [PATCH 1/3] iio: adc: aspeed: Simplify probe() with local 'dev' and 'np' Jonathan Cameron
2025-12-27 17:43 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5782401.ejJDZkT8p0@phil \
--to=heiko@sntech.de \
--cc=alim.akhtar@samsung.com \
--cc=andrew@codeconstruct.com.au \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=joel@jms.id.au \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.