From: Chanwoo Choi <cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: Lin Huang <hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org
Cc: tixy-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
typ-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
airlied-cv59FeDIM0c@public.gmane.org,
mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
dbasehore-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
sudeep.holla-5wv7dgnIgG8@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org
Subject: Re: [PATCH v5 4/8] Documentation: bindings: add dt documentation for dfi controller
Date: Wed, 10 Aug 2016 13:29:14 +0900 [thread overview]
Message-ID: <57AAAD9A.1090201@samsung.com> (raw)
In-Reply-To: <1470799604-12877-5-git-send-email-hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Hi Lin,
On 2016년 08월 10일 12:26, Lin Huang wrote:
> This patch adds the documentation for rockchip dfi devfreq-event driver.
>
> Signed-off-by: Lin Huang <hl@rock-chips.com>
> ---
> Changes in v5:
> -None
>
> Changes in v4:
> -None
>
> Changes in v3:
> -None
>
> Changes in v2:
> -None
>
> Changes in v1:
> -None
>
> .../bindings/devfreq/event/rockchip-dfi.txt | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt
>
> diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt
> new file mode 100644
> index 0000000..bf42255
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt
> @@ -0,0 +1,20 @@
> +
> +* Rockchip rk3399 DFI device
> +
> +Required properties:
> +- compatible: Must be "rockchip,rk3399-dfi".
> +- reg: physical base address of each DFI and length of memory mapped region
> +- rockchip,pmu: phandle to the syscon managing the "pmu general register files"
> +- clocks: phandles for clock specified in "clock-names" property
> +- clock-names : the name of clock used by the DFI, must be "pclk_ddr_mon";
> +
> +Example:
> + dfi: dfi@0xff630000 {
> + reg = <0x00 0xff630000 0x00 0x4000>;
> + compatible = "rockchip,rk3399-dfi";
Usually, the compatible is first entry within Device-tree node.
> + rockchip,pmu = <&pmugrf>;
> + clocks = <&cru PCLK_DDR_MON>;
> + clock-names = "pclk_ddr_mon";
> + status = "disabled";
> + };
> +
>
Looks good to me. Just I want to change the sequence
between 'compatible' and 'reg' property.
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Regards,
Chawnoo Choi
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: cw00.choi@samsung.com (Chanwoo Choi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 4/8] Documentation: bindings: add dt documentation for dfi controller
Date: Wed, 10 Aug 2016 13:29:14 +0900 [thread overview]
Message-ID: <57AAAD9A.1090201@samsung.com> (raw)
In-Reply-To: <1470799604-12877-5-git-send-email-hl@rock-chips.com>
Hi Lin,
On 2016? 08? 10? 12:26, Lin Huang wrote:
> This patch adds the documentation for rockchip dfi devfreq-event driver.
>
> Signed-off-by: Lin Huang <hl@rock-chips.com>
> ---
> Changes in v5:
> -None
>
> Changes in v4:
> -None
>
> Changes in v3:
> -None
>
> Changes in v2:
> -None
>
> Changes in v1:
> -None
>
> .../bindings/devfreq/event/rockchip-dfi.txt | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt
>
> diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt
> new file mode 100644
> index 0000000..bf42255
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt
> @@ -0,0 +1,20 @@
> +
> +* Rockchip rk3399 DFI device
> +
> +Required properties:
> +- compatible: Must be "rockchip,rk3399-dfi".
> +- reg: physical base address of each DFI and length of memory mapped region
> +- rockchip,pmu: phandle to the syscon managing the "pmu general register files"
> +- clocks: phandles for clock specified in "clock-names" property
> +- clock-names : the name of clock used by the DFI, must be "pclk_ddr_mon";
> +
> +Example:
> + dfi: dfi at 0xff630000 {
> + reg = <0x00 0xff630000 0x00 0x4000>;
> + compatible = "rockchip,rk3399-dfi";
Usually, the compatible is first entry within Device-tree node.
> + rockchip,pmu = <&pmugrf>;
> + clocks = <&cru PCLK_DDR_MON>;
> + clock-names = "pclk_ddr_mon";
> + status = "disabled";
> + };
> +
>
Looks good to me. Just I want to change the sequence
between 'compatible' and 'reg' property.
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Regards,
Chawnoo Choi
WARNING: multiple messages have this Message-ID (diff)
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Lin Huang <hl@rock-chips.com>, heiko@sntech.de
Cc: myungjoo.ham@samsung.com, mark.yao@rock-chips.com,
airlied@linux.ie, mturquette@baylibre.com,
dbasehore@chromium.org, sboyd@codeaurora.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
dianders@chromium.org, linux-rockchip@lists.infradead.org,
kyungmin.park@samsung.com, linux-arm-kernel@lists.infradead.org,
tixy@linaro.org, typ@rock-chips.com, sudeep.holla@arm.com,
mark.rutland@arm.com, linux-pm@vger.kernel.org
Subject: Re: [PATCH v5 4/8] Documentation: bindings: add dt documentation for dfi controller
Date: Wed, 10 Aug 2016 13:29:14 +0900 [thread overview]
Message-ID: <57AAAD9A.1090201@samsung.com> (raw)
In-Reply-To: <1470799604-12877-5-git-send-email-hl@rock-chips.com>
Hi Lin,
On 2016년 08월 10일 12:26, Lin Huang wrote:
> This patch adds the documentation for rockchip dfi devfreq-event driver.
>
> Signed-off-by: Lin Huang <hl@rock-chips.com>
> ---
> Changes in v5:
> -None
>
> Changes in v4:
> -None
>
> Changes in v3:
> -None
>
> Changes in v2:
> -None
>
> Changes in v1:
> -None
>
> .../bindings/devfreq/event/rockchip-dfi.txt | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt
>
> diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt
> new file mode 100644
> index 0000000..bf42255
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt
> @@ -0,0 +1,20 @@
> +
> +* Rockchip rk3399 DFI device
> +
> +Required properties:
> +- compatible: Must be "rockchip,rk3399-dfi".
> +- reg: physical base address of each DFI and length of memory mapped region
> +- rockchip,pmu: phandle to the syscon managing the "pmu general register files"
> +- clocks: phandles for clock specified in "clock-names" property
> +- clock-names : the name of clock used by the DFI, must be "pclk_ddr_mon";
> +
> +Example:
> + dfi: dfi@0xff630000 {
> + reg = <0x00 0xff630000 0x00 0x4000>;
> + compatible = "rockchip,rk3399-dfi";
Usually, the compatible is first entry within Device-tree node.
> + rockchip,pmu = <&pmugrf>;
> + clocks = <&cru PCLK_DDR_MON>;
> + clock-names = "pclk_ddr_mon";
> + status = "disabled";
> + };
> +
>
Looks good to me. Just I want to change the sequence
between 'compatible' and 'reg' property.
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Regards,
Chawnoo Choi
next prev parent reply other threads:[~2016-08-10 4:29 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 3:26 [PATCH v5 0/8] rk3399 support ddr frequency scaling Lin Huang
2016-08-10 3:26 ` Lin Huang
[not found] ` <1470799604-12877-1-git-send-email-hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-08-10 3:26 ` [PATCH v5 1/8] clk: rockchip: add new clock-type for the ddrclk Lin Huang
2016-08-10 3:26 ` Lin Huang
2016-08-10 3:26 ` Lin Huang
2016-08-10 3:26 ` [PATCH v5 2/8] clk: rockchip: rk3399: add SCLK_DDRCLK ID for ddrc Lin Huang
2016-08-10 3:26 ` Lin Huang
2016-08-10 3:26 ` Lin Huang
2016-08-10 3:26 ` [PATCH v5 4/8] Documentation: bindings: add dt documentation for dfi controller Lin Huang
2016-08-10 3:26 ` Lin Huang
2016-08-10 3:26 ` Lin Huang
[not found] ` <1470799604-12877-5-git-send-email-hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-08-10 4:29 ` Chanwoo Choi [this message]
2016-08-10 4:29 ` Chanwoo Choi
2016-08-10 4:29 ` Chanwoo Choi
2016-08-10 3:26 ` [PATCH v5 3/8] clk: rockchip: rk3399: add ddrc clock support Lin Huang
2016-08-10 3:26 ` Lin Huang
2016-08-10 3:26 ` [PATCH v5 5/8] PM / devfreq: event: support rockchip dfi controller Lin Huang
2016-08-10 3:26 ` Lin Huang
2016-08-10 3:26 ` [PATCH v5 6/8] Documentation: bindings: add dt documentation for rk3399 dmc Lin Huang
2016-08-10 3:26 ` Lin Huang
2016-08-10 4:38 ` Chanwoo Choi
2016-08-10 4:38 ` Chanwoo Choi
2016-08-10 3:26 ` [PATCH v5 7/8] PM / devfreq: rockchip: add devfreq driver " Lin Huang
2016-08-10 3:26 ` Lin Huang
2016-08-10 4:39 ` [PATCH] PM / devfreq: rockchip: fix semicolon.cocci warnings kbuild test robot
2016-08-10 4:39 ` kbuild test robot
2016-08-10 4:39 ` kbuild test robot
2016-08-10 4:39 ` [PATCH v5 7/8] PM / devfreq: rockchip: add devfreq driver for rk3399 dmc kbuild test robot
2016-08-10 4:39 ` kbuild test robot
2016-08-10 4:39 ` kbuild test robot
2016-08-10 5:01 ` Chanwoo Choi
2016-08-10 5:01 ` Chanwoo Choi
2016-08-10 9:05 ` kbuild test robot
2016-08-10 9:05 ` kbuild test robot
2016-08-10 9:05 ` kbuild test robot
2016-08-10 9:07 ` kbuild test robot
2016-08-10 9:07 ` kbuild test robot
2016-08-10 9:07 ` kbuild test robot
2016-08-10 3:26 ` [PATCH v5 8/8] drm/rockchip: Add dmc notifier in vop driver Lin Huang
2016-08-10 3:26 ` Lin Huang
[not found] ` <1470799604-12877-9-git-send-email-hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-08-10 5:07 ` Chanwoo Choi
2016-08-10 5:07 ` Chanwoo Choi
2016-08-10 5:07 ` Chanwoo Choi
2016-08-10 5:28 ` kbuild test robot
2016-08-10 5:28 ` kbuild test robot
2016-08-10 5:28 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57AAAD9A.1090201@samsung.com \
--to=cw00.choi-sze3o3uu22jbdgjk7y7tuq@public.gmane.org \
--cc=airlied-cv59FeDIM0c@public.gmane.org \
--cc=dbasehore-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
--cc=kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
--cc=mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=sudeep.holla-5wv7dgnIgG8@public.gmane.org \
--cc=tixy-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=typ-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.