All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Russell King <rmk+kernel@arm.linux.org.uk>,
	David Airlie <airlied@linux.ie>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Hans Verkuil <hansverk@cisco.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC 4/5] drm/bridge: add dw-hdmi cec driver using Hans Verkil's CEC code
Date: Tue, 23 Aug 2016 08:03:03 +0000	[thread overview]
Message-ID: <57BC0337.2080203@xs4all.nl> (raw)
In-Reply-To: <E1bYDEs-0004rs-FP@rmk-PC.armlinux.org.uk>

Hi Russell,

On 08/12/16 16:15, Russell King wrote:
> +	ret = devm_request_threaded_irq(&pdev->dev, cec->irq,
> +					dw_hdmi_cec_hardirq,
> +					dw_hdmi_cec_thread, IRQF_SHARED,
> +					DEV_NAME, cec->adap);
> +	if (ret < 0)
> +		return ret;
> +
> +	ret = cec_register_adapter(cec->adap);
> +	if (ret < 0)
> +		return ret;
> +
> +	/*
> +	 * CEC documentation says we must not call cec_delete_adapter
> +	 * after a successful call to cec_register_adapter().
> +	 */
> +	devm_remove_action(&pdev->dev, dw_hdmi_cec_del, cec);
> +
> +	hdmi_register_notifier(&cec->nb);

The notifier is registered here, but who provides CEC with the initial
physical address? As I understand it, it only tells you when things change,
not what the initial state is.

Regards,

	Hans

WARNING: multiple messages have this Message-ID (diff)
From: hverkuil@xs4all.nl (Hans Verkuil)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 4/5] drm/bridge: add dw-hdmi cec driver using Hans Verkil's CEC code
Date: Tue, 23 Aug 2016 10:03:03 +0200	[thread overview]
Message-ID: <57BC0337.2080203@xs4all.nl> (raw)
In-Reply-To: <E1bYDEs-0004rs-FP@rmk-PC.armlinux.org.uk>

Hi Russell,

On 08/12/16 16:15, Russell King wrote:
> +	ret = devm_request_threaded_irq(&pdev->dev, cec->irq,
> +					dw_hdmi_cec_hardirq,
> +					dw_hdmi_cec_thread, IRQF_SHARED,
> +					DEV_NAME, cec->adap);
> +	if (ret < 0)
> +		return ret;
> +
> +	ret = cec_register_adapter(cec->adap);
> +	if (ret < 0)
> +		return ret;
> +
> +	/*
> +	 * CEC documentation says we must not call cec_delete_adapter
> +	 * after a successful call to cec_register_adapter().
> +	 */
> +	devm_remove_action(&pdev->dev, dw_hdmi_cec_del, cec);
> +
> +	hdmi_register_notifier(&cec->nb);

The notifier is registered here, but who provides CEC with the initial
physical address? As I understand it, it only tells you when things change,
not what the initial state is.

Regards,

	Hans

WARNING: multiple messages have this Message-ID (diff)
From: Hans Verkuil <hverkuil@xs4all.nl>
To: Russell King <rmk+kernel@arm.linux.org.uk>,
	David Airlie <airlied@linux.ie>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Hans Verkuil <hansverk@cisco.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC 4/5] drm/bridge: add dw-hdmi cec driver using Hans Verkil's CEC code
Date: Tue, 23 Aug 2016 10:03:03 +0200	[thread overview]
Message-ID: <57BC0337.2080203@xs4all.nl> (raw)
In-Reply-To: <E1bYDEs-0004rs-FP@rmk-PC.armlinux.org.uk>

Hi Russell,

On 08/12/16 16:15, Russell King wrote:
> +	ret = devm_request_threaded_irq(&pdev->dev, cec->irq,
> +					dw_hdmi_cec_hardirq,
> +					dw_hdmi_cec_thread, IRQF_SHARED,
> +					DEV_NAME, cec->adap);
> +	if (ret < 0)
> +		return ret;
> +
> +	ret = cec_register_adapter(cec->adap);
> +	if (ret < 0)
> +		return ret;
> +
> +	/*
> +	 * CEC documentation says we must not call cec_delete_adapter
> +	 * after a successful call to cec_register_adapter().
> +	 */
> +	devm_remove_action(&pdev->dev, dw_hdmi_cec_del, cec);
> +
> +	hdmi_register_notifier(&cec->nb);

The notifier is registered here, but who provides CEC with the initial
physical address? As I understand it, it only tells you when things change,
not what the initial state is.

Regards,

	Hans
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2016-08-23  8:03 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-12 14:14 [PATCH RFC 0/5] CEC drivers for iMX6 and TDA9950 Russell King - ARM Linux
2016-08-12 14:14 ` Russell King - ARM Linux
2016-08-12 14:14 ` Russell King - ARM Linux
2016-08-12 14:14 ` [PATCH RFC 1/5] video: add HDMI state notifier support Russell King
2016-08-12 14:14   ` Russell King
2016-08-12 14:14   ` Russell King
2016-08-12 15:26   ` Hans Verkuil
2016-08-12 15:26     ` Hans Verkuil
2016-08-12 15:26     ` Hans Verkuil
2016-08-12 14:15 ` [PATCH RFC 2/5] drm/bridge: dw_hdmi: remove CEC engine register definitions Russell King
2016-08-12 14:15   ` Russell King
2016-08-12 14:15   ` Russell King
2016-08-12 14:15 ` [PATCH RFC 3/5] drm/bridge: dw_hdmi: add HDMI notifier support Russell King
2016-08-12 14:15   ` Russell King
2016-08-12 14:15   ` Russell King
2016-08-12 14:15 ` [PATCH RFC 4/5] drm/bridge: add dw-hdmi cec driver using Hans Verkil's CEC code Russell King
2016-08-12 14:15   ` Russell King
2016-08-12 14:15   ` Russell King
2016-08-12 14:25   ` Hans Verkuil
2016-08-12 14:25     ` Hans Verkuil
2016-08-12 14:25     ` Hans Verkuil
2016-08-12 14:26     ` Russell King - ARM Linux
2016-08-12 14:26       ` Russell King - ARM Linux
2016-08-12 14:26       ` Russell King - ARM Linux
2016-08-23  7:21   ` Hans Verkuil
2016-08-23  7:21     ` Hans Verkuil
2016-08-23  7:21     ` Hans Verkuil
2016-08-23  7:59     ` Russell King - ARM Linux
2016-08-23  7:59       ` Russell King - ARM Linux
2016-08-23  7:59       ` Russell King - ARM Linux
2016-08-23  8:05       ` Hans Verkuil
2016-08-23  8:05         ` Hans Verkuil
2016-08-23  8:05         ` Hans Verkuil
2016-08-31 12:28         ` Russell King - ARM Linux
2016-08-31 12:28           ` Russell King - ARM Linux
2016-08-31 12:28           ` Russell King - ARM Linux
2016-08-23  8:03   ` Hans Verkuil [this message]
2016-08-23  8:03     ` Hans Verkuil
2016-08-23  8:03     ` Hans Verkuil
2016-08-31 12:28     ` Russell King - ARM Linux
2016-08-31 12:28       ` Russell King - ARM Linux
2016-08-31 12:28       ` Russell King - ARM Linux
2016-08-12 14:15 ` [PATCH RFC 5/5] drm/i2c: add tda998x/tda9950 CEC driver Russell King
2016-08-12 14:15   ` Russell King
2016-08-12 14:15   ` Russell King
2016-08-12 14:38   ` Hans Verkuil
2016-08-12 14:38     ` Hans Verkuil
2016-08-12 14:38     ` Hans Verkuil
2016-08-12 14:52     ` Russell King - ARM Linux
2016-08-12 14:52       ` Russell King - ARM Linux
2016-08-12 14:52       ` Russell King - ARM Linux
2016-08-12 15:16     ` Hans Verkuil
2016-08-12 15:16       ` Hans Verkuil
2016-08-12 15:16       ` Hans Verkuil
2016-08-12 15:29       ` Russell King - ARM Linux
2016-08-12 15:29         ` Russell King - ARM Linux
2016-08-12 15:29         ` Russell King - ARM Linux
2016-08-12 15:53         ` Hans Verkuil
2016-08-12 15:53           ` Hans Verkuil
2016-08-12 15:53           ` Hans Verkuil
2016-08-12 15:59           ` Russell King - ARM Linux
2016-08-12 15:59             ` Russell King - ARM Linux
2016-08-12 15:59             ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57BC0337.2080203@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hansverk@cisco.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=plagnioj@jcrosoft.com \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.