* [PATCH 1/2] PM / devfreq: exynos-nocp: Select REGMAP_MMIO @ 2016-09-20 8:57 ` Axel Lin 2016-09-20 8:57 ` [PATCH 2/2] PM / devfreq: exynos-nocp: Remove redundant code to reset load_count/total_count Axel Lin 2016-09-20 9:30 ` [PATCH 1/2] PM / devfreq: exynos-nocp: Select REGMAP_MMIO Chanwoo Choi 0 siblings, 2 replies; 7+ messages in thread From: Axel Lin @ 2016-09-20 8:57 UTC (permalink / raw) To: Rafael J . Wysocki Cc: Chanwoo Choi, MyungJoo Ham, Kyungmin Park, linux-pm, linux-samsung-soc, Axel Lin This drvier uses devm_regmap_init_mmio(), so select REGMAP_MMIO to avoid build failure. Signed-off-by: Axel Lin <axel.lin@ingics.com> --- drivers/devfreq/event/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/devfreq/event/Kconfig b/drivers/devfreq/event/Kconfig index 0fdae86..cd94980 100644 --- a/drivers/devfreq/event/Kconfig +++ b/drivers/devfreq/event/Kconfig @@ -17,6 +17,7 @@ config DEVFREQ_EVENT_EXYNOS_NOCP tristate "EXYNOS NoC (Network On Chip) Probe DEVFREQ event Driver" depends on ARCH_EXYNOS || COMPILE_TEST select PM_OPP + select REGMAP_MMIO help This add the devfreq-event driver for Exynos SoC. It provides NoC (Network on Chip) Probe counters to measure the bandwidth of AXI bus. -- 2.7.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] PM / devfreq: exynos-nocp: Remove redundant code to reset load_count/total_count 2016-09-20 8:57 ` [PATCH 1/2] PM / devfreq: exynos-nocp: Select REGMAP_MMIO Axel Lin @ 2016-09-20 8:57 ` Axel Lin 2016-09-20 9:34 ` Chanwoo Choi 2016-09-20 9:30 ` [PATCH 1/2] PM / devfreq: exynos-nocp: Select REGMAP_MMIO Chanwoo Choi 1 sibling, 1 reply; 7+ messages in thread From: Axel Lin @ 2016-09-20 8:57 UTC (permalink / raw) To: Rafael J . Wysocki Cc: Chanwoo Choi, MyungJoo Ham, Kyungmin Park, linux-pm, linux-samsung-soc, Axel Lin This is done by devfreq_event_get_event() so remove the redundant code in exynos_nocp_get_event(). Signed-off-by: Axel Lin <axel.lin@ingics.com> --- drivers/devfreq/event/exynos-nocp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/devfreq/event/exynos-nocp.c b/drivers/devfreq/event/exynos-nocp.c index a584140..49e712a 100644 --- a/drivers/devfreq/event/exynos-nocp.c +++ b/drivers/devfreq/event/exynos-nocp.c @@ -176,9 +176,6 @@ static int exynos_nocp_get_event(struct devfreq_event_dev *edev, return 0; out: - edata->load_count = 0; - edata->total_count = 0; - dev_err(nocp->dev, "Failed to read the counter of NoC probe device\n"); return ret; -- 2.7.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] PM / devfreq: exynos-nocp: Remove redundant code to reset load_count/total_count 2016-09-20 8:57 ` [PATCH 2/2] PM / devfreq: exynos-nocp: Remove redundant code to reset load_count/total_count Axel Lin @ 2016-09-20 9:34 ` Chanwoo Choi 2016-09-20 9:38 ` Axel Lin 0 siblings, 1 reply; 7+ messages in thread From: Chanwoo Choi @ 2016-09-20 9:34 UTC (permalink / raw) To: Axel Lin, Rafael J . Wysocki Cc: MyungJoo Ham, Kyungmin Park, linux-pm, linux-samsung-soc Hi, On 2016년 09월 20일 17:57, Axel Lin wrote: > This is done by devfreq_event_get_event() so remove the redundant code in > exynos_nocp_get_event(). > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > drivers/devfreq/event/exynos-nocp.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/devfreq/event/exynos-nocp.c b/drivers/devfreq/event/exynos-nocp.c > index a584140..49e712a 100644 > --- a/drivers/devfreq/event/exynos-nocp.c > +++ b/drivers/devfreq/event/exynos-nocp.c > @@ -176,9 +176,6 @@ static int exynos_nocp_get_event(struct devfreq_event_dev *edev, > return 0; > > out: > - edata->load_count = 0; > - edata->total_count = 0; > - > dev_err(nocp->dev, "Failed to read the counter of NoC probe device\n"); > > return ret; > As you said, devfreq_event_get_event() initializes both load_count and total_count before calling edev->desc->ops->get_event(). Looks good to me. Acked-by: Chanwoo Choi <cw00.choi@samsung.com> -- Best Regards, Chanwoo Choi ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] PM / devfreq: exynos-nocp: Remove redundant code to reset load_count/total_count 2016-09-20 9:34 ` Chanwoo Choi @ 2016-09-20 9:38 ` Axel Lin 2016-09-20 9:43 ` Chanwoo Choi 0 siblings, 1 reply; 7+ messages in thread From: Axel Lin @ 2016-09-20 9:38 UTC (permalink / raw) To: Chanwoo Choi Cc: Rafael J . Wysocki, MyungJoo Ham, Kyungmin Park, linux-pm, linux-samsung-soc@vger.kernel.org 2016-09-20 17:34 GMT+08:00 Chanwoo Choi <cw00.choi@samsung.com>: > Hi, > > On 2016년 09월 20일 17:57, Axel Lin wrote: >> This is done by devfreq_event_get_event() so remove the redundant code in >> exynos_nocp_get_event(). >> >> Signed-off-by: Axel Lin <axel.lin@ingics.com> >> --- >> drivers/devfreq/event/exynos-nocp.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/drivers/devfreq/event/exynos-nocp.c b/drivers/devfreq/event/exynos-nocp.c >> index a584140..49e712a 100644 >> --- a/drivers/devfreq/event/exynos-nocp.c >> +++ b/drivers/devfreq/event/exynos-nocp.c >> @@ -176,9 +176,6 @@ static int exynos_nocp_get_event(struct devfreq_event_dev *edev, >> return 0; >> >> out: >> - edata->load_count = 0; >> - edata->total_count = 0; >> - >> dev_err(nocp->dev, "Failed to read the counter of NoC probe device\n"); >> >> return ret; >> > > As you said, devfreq_event_get_event() initializes both load_count and total_count > before calling edev->desc->ops->get_event(). Looks good to me. Actually, the point is if edev->desc->ops->get_event() fails, the code in devfreq_event_get_event() will reset edata->total_count and edata->load_count to 0. Axel ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] PM / devfreq: exynos-nocp: Remove redundant code to reset load_count/total_count 2016-09-20 9:38 ` Axel Lin @ 2016-09-20 9:43 ` Chanwoo Choi 0 siblings, 0 replies; 7+ messages in thread From: Chanwoo Choi @ 2016-09-20 9:43 UTC (permalink / raw) To: Axel Lin Cc: Rafael J . Wysocki, MyungJoo Ham, Kyungmin Park, linux-pm, linux-samsung-soc@vger.kernel.org On 2016년 09월 20일 18:38, Axel Lin wrote: > 2016-09-20 17:34 GMT+08:00 Chanwoo Choi <cw00.choi@samsung.com>: >> Hi, >> >> On 2016년 09월 20일 17:57, Axel Lin wrote: >>> This is done by devfreq_event_get_event() so remove the redundant code in >>> exynos_nocp_get_event(). >>> >>> Signed-off-by: Axel Lin <axel.lin@ingics.com> >>> --- >>> drivers/devfreq/event/exynos-nocp.c | 3 --- >>> 1 file changed, 3 deletions(-) >>> >>> diff --git a/drivers/devfreq/event/exynos-nocp.c b/drivers/devfreq/event/exynos-nocp.c >>> index a584140..49e712a 100644 >>> --- a/drivers/devfreq/event/exynos-nocp.c >>> +++ b/drivers/devfreq/event/exynos-nocp.c >>> @@ -176,9 +176,6 @@ static int exynos_nocp_get_event(struct devfreq_event_dev *edev, >>> return 0; >>> >>> out: >>> - edata->load_count = 0; >>> - edata->total_count = 0; >>> - >>> dev_err(nocp->dev, "Failed to read the counter of NoC probe device\n"); >>> >>> return ret; >>> >> >> As you said, devfreq_event_get_event() initializes both load_count and total_count >> before calling edev->desc->ops->get_event(). Looks good to me. > > Actually, the point is if edev->desc->ops->get_event() fails, > the code in devfreq_event_get_event() will reset > edata->total_count and edata->load_count to 0. You're right. devfreq_event_get_event() initializes the data when before calling edev->desc->ops->get_event() or fail happen. -- Best Regards, Chanwoo Choi ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] PM / devfreq: exynos-nocp: Select REGMAP_MMIO 2016-09-20 8:57 ` [PATCH 1/2] PM / devfreq: exynos-nocp: Select REGMAP_MMIO Axel Lin 2016-09-20 8:57 ` [PATCH 2/2] PM / devfreq: exynos-nocp: Remove redundant code to reset load_count/total_count Axel Lin @ 2016-09-20 9:30 ` Chanwoo Choi 2016-09-30 14:11 ` MyungJoo Ham 1 sibling, 1 reply; 7+ messages in thread From: Chanwoo Choi @ 2016-09-20 9:30 UTC (permalink / raw) To: Axel Lin, Rafael J . Wysocki Cc: MyungJoo Ham, Kyungmin Park, linux-pm, linux-samsung-soc Hi, On 2016년 09월 20일 17:57, Axel Lin wrote: > This drvier uses devm_regmap_init_mmio(), so select REGMAP_MMIO to avoid > build failure. s/drvier/driver > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > drivers/devfreq/event/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/devfreq/event/Kconfig b/drivers/devfreq/event/Kconfig > index 0fdae86..cd94980 100644 > --- a/drivers/devfreq/event/Kconfig > +++ b/drivers/devfreq/event/Kconfig > @@ -17,6 +17,7 @@ config DEVFREQ_EVENT_EXYNOS_NOCP > tristate "EXYNOS NoC (Network On Chip) Probe DEVFREQ event Driver" > depends on ARCH_EXYNOS || COMPILE_TEST > select PM_OPP > + select REGMAP_MMIO > help > This add the devfreq-event driver for Exynos SoC. It provides NoC > (Network on Chip) Probe counters to measure the bandwidth of AXI bus. > Acked-by: Chanwoo Choi <cw00.choi@samsung.com> -- Best Regards, Chanwoo Choi ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] PM / devfreq: exynos-nocp: Select REGMAP_MMIO 2016-09-20 9:30 ` [PATCH 1/2] PM / devfreq: exynos-nocp: Select REGMAP_MMIO Chanwoo Choi @ 2016-09-30 14:11 ` MyungJoo Ham 0 siblings, 0 replies; 7+ messages in thread From: MyungJoo Ham @ 2016-09-30 14:11 UTC (permalink / raw) To: Chanwoo Choi Cc: Axel Lin, Rafael J . Wysocki, Kyungmin Park, Linux PM list, Linux Samsung SoC On Tue, Sep 20, 2016 at 6:30 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote: > Hi, > > On 2016년 09월 20일 17:57, Axel Lin wrote: >> This drvier uses devm_regmap_init_mmio(), so select REGMAP_MMIO to avoid >> build failure. > > s/drvier/driver > >> >> Signed-off-by: Axel Lin <axel.lin@ingics.com> >> --- >> drivers/devfreq/event/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/devfreq/event/Kconfig b/drivers/devfreq/event/Kconfig >> index 0fdae86..cd94980 100644 >> --- a/drivers/devfreq/event/Kconfig >> +++ b/drivers/devfreq/event/Kconfig >> @@ -17,6 +17,7 @@ config DEVFREQ_EVENT_EXYNOS_NOCP >> tristate "EXYNOS NoC (Network On Chip) Probe DEVFREQ event Driver" >> depends on ARCH_EXYNOS || COMPILE_TEST >> select PM_OPP >> + select REGMAP_MMIO >> help >> This add the devfreq-event driver for Exynos SoC. It provides NoC >> (Network on Chip) Probe counters to measure the bandwidth of AXI bus. >> > > Acked-by: Chanwoo Choi <cw00.choi@samsung.com> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com> > > -- > Best Regards, > Chanwoo Choi > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- MyungJoo Ham, Ph.D. Frontier CS Lab, S/W Center, Samsung Electronics ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-09-30 14:11 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20160920085823epcas1p1f0fed4f248efcccccbce71438c03a9a1@epcas1p1.samsung.com>
2016-09-20 8:57 ` [PATCH 1/2] PM / devfreq: exynos-nocp: Select REGMAP_MMIO Axel Lin
2016-09-20 8:57 ` [PATCH 2/2] PM / devfreq: exynos-nocp: Remove redundant code to reset load_count/total_count Axel Lin
2016-09-20 9:34 ` Chanwoo Choi
2016-09-20 9:38 ` Axel Lin
2016-09-20 9:43 ` Chanwoo Choi
2016-09-20 9:30 ` [PATCH 1/2] PM / devfreq: exynos-nocp: Select REGMAP_MMIO Chanwoo Choi
2016-09-30 14:11 ` MyungJoo Ham
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.