All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Daney <ddaney.cavm@gmail.com>
To: Robert Richter <rrichter@cavium.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-efi@vger.kernel.org, David Daney <david.daney@cavium.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	linux-kernel@vger.kernel.org, Hanjun Guo <hanjun.guo@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: mm: Fix memmap to be initialized for the entire section
Date: Mon, 10 Oct 2016 08:33:50 -0700	[thread overview]
Message-ID: <57FBB4DE.2090502@gmail.com> (raw)
In-Reply-To: <1475747527-32387-1-git-send-email-rrichter@cavium.com>

On 10/06/2016 02:52 AM, Robert Richter wrote:
> There is a memory setup problem on ThunderX systems with certain
> memory configurations. The symptom is
>
>   kernel BUG at mm/page_alloc.c:1848!
>
> This happens for some configs with 64k page size enabled. The bug
> triggers for page zones with some pages in the zone not assigned to
> this particular zone. In my case some pages that are marked as nomap
> were not reassigned to the new zone of node 1, so those are still
> assigned to node 0.
>
> The reason for the mis-configuration is a change in pfn_valid() which
> reports pages marked nomap as invalid:
>
>   68709f45385a arm64: only consider memblocks with NOMAP cleared for linear mapping
>
> This causes pages marked as nomap being no long reassigned to the new
> zone in memmap_init_zone() by calling __init_single_pfn().
>
> Fixing this by restoring the old behavior of pfn_valid() to use
> memblock_is_memory(). Also changing users of pfn_valid() in arm64 code
> to use memblock_is_map_memory() where necessary. This only affects
> code in ioremap.c. The code in mmu.c still can use the new version of
> pfn_valid().
>
> Should be marked stable v4.5..

In that case you should add:

Cc: <stable@vger.kernel.org> # 4.5.x-

here.


>
> Signed-off-by: Robert Richter <rrichter@cavium.com>
[...]

WARNING: multiple messages have this Message-ID (diff)
From: ddaney.cavm@gmail.com (David Daney)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: mm: Fix memmap to be initialized for the entire section
Date: Mon, 10 Oct 2016 08:33:50 -0700	[thread overview]
Message-ID: <57FBB4DE.2090502@gmail.com> (raw)
In-Reply-To: <1475747527-32387-1-git-send-email-rrichter@cavium.com>

On 10/06/2016 02:52 AM, Robert Richter wrote:
> There is a memory setup problem on ThunderX systems with certain
> memory configurations. The symptom is
>
>   kernel BUG at mm/page_alloc.c:1848!
>
> This happens for some configs with 64k page size enabled. The bug
> triggers for page zones with some pages in the zone not assigned to
> this particular zone. In my case some pages that are marked as nomap
> were not reassigned to the new zone of node 1, so those are still
> assigned to node 0.
>
> The reason for the mis-configuration is a change in pfn_valid() which
> reports pages marked nomap as invalid:
>
>   68709f45385a arm64: only consider memblocks with NOMAP cleared for linear mapping
>
> This causes pages marked as nomap being no long reassigned to the new
> zone in memmap_init_zone() by calling __init_single_pfn().
>
> Fixing this by restoring the old behavior of pfn_valid() to use
> memblock_is_memory(). Also changing users of pfn_valid() in arm64 code
> to use memblock_is_map_memory() where necessary. This only affects
> code in ioremap.c. The code in mmu.c still can use the new version of
> pfn_valid().
>
> Should be marked stable v4.5..

In that case you should add:

Cc: <stable@vger.kernel.org> # 4.5.x-

here.


>
> Signed-off-by: Robert Richter <rrichter@cavium.com>
[...]

  parent reply	other threads:[~2016-10-10 15:33 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-06  9:52 [PATCH] arm64: mm: Fix memmap to be initialized for the entire section Robert Richter
2016-10-06  9:52 ` Robert Richter
2016-10-06  9:52 ` Robert Richter
     [not found] ` <1475747527-32387-1-git-send-email-rrichter-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2016-10-06 10:00   ` Ard Biesheuvel
2016-10-06 10:00     ` Ard Biesheuvel
2016-10-06 10:00     ` Ard Biesheuvel
     [not found]     ` <CAKv+Gu-oYzSn_eeqaX3QVFeQjBGkaX-Wh7+oPcQFcXv7J6GOFQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-06 16:11       ` Robert Richter
2016-10-06 16:11         ` Robert Richter
2016-10-06 16:11         ` Robert Richter
     [not found]         ` <20161006161114.GH22012-vWBEXY7mpu582hYKe6nXyg@public.gmane.org>
2016-10-17 18:58           ` Robert Richter
2016-10-17 18:58             ` Robert Richter
2016-10-17 18:58             ` Robert Richter
     [not found]             ` <20161017185801.GT25086-vWBEXY7mpu582hYKe6nXyg@public.gmane.org>
2016-10-27 16:01               ` Will Deacon
2016-10-27 16:01                 ` Will Deacon
2016-10-27 16:01                 ` Will Deacon
     [not found]                 ` <20161027160136.GD24290-5wv7dgnIgG8@public.gmane.org>
2016-10-28  9:19                   ` Robert Richter
2016-10-28  9:19                     ` Robert Richter
2016-10-28  9:19                     ` Robert Richter
2016-11-07 21:05                     ` Will Deacon
2016-11-07 21:05                       ` Will Deacon
2016-11-09 19:51                       ` Robert Richter
2016-11-09 19:51                         ` Robert Richter
     [not found]                         ` <20161109195132.GZ22012-vWBEXY7mpu582hYKe6nXyg@public.gmane.org>
2016-11-17 14:25                           ` Will Deacon
2016-11-17 14:25                             ` Will Deacon
2016-11-17 14:25                             ` Will Deacon
2016-11-17 15:18                             ` Robert Richter
2016-11-17 15:18                               ` Robert Richter
2016-11-17 15:18                               ` Robert Richter
     [not found]                               ` <20161117151805.GJ2151-vWBEXY7mpu582hYKe6nXyg@public.gmane.org>
2016-11-20 17:07                                 ` Ard Biesheuvel
2016-11-20 17:07                                   ` Ard Biesheuvel
2016-11-20 17:07                                   ` Ard Biesheuvel
2016-11-23 21:15                                   ` Robert Richter
2016-11-23 21:15                                     ` Robert Richter
2016-11-23 21:15                                     ` Robert Richter
     [not found]                                     ` <20161123211538.GH10776-vWBEXY7mpu582hYKe6nXyg@public.gmane.org>
2016-11-23 21:25                                       ` Ard Biesheuvel
2016-11-23 21:25                                         ` Ard Biesheuvel
2016-11-23 21:25                                         ` Ard Biesheuvel
2016-11-24 13:42                                         ` Robert Richter
2016-11-24 13:42                                           ` Robert Richter
2016-11-24 13:42                                           ` Robert Richter
     [not found]                                           ` <20161124134238.GI10776-vWBEXY7mpu582hYKe6nXyg@public.gmane.org>
2016-11-24 13:44                                             ` Ard Biesheuvel
2016-11-24 13:44                                               ` Ard Biesheuvel
2016-11-24 13:44                                               ` Ard Biesheuvel
2016-11-24 13:51                                               ` Robert Richter
2016-11-24 13:51                                                 ` Robert Richter
     [not found]                                                 ` <20161124135151.GJ10776-vWBEXY7mpu582hYKe6nXyg@public.gmane.org>
2016-11-24 13:58                                                   ` Ard Biesheuvel
2016-11-24 13:58                                                     ` Ard Biesheuvel
2016-11-24 13:58                                                     ` Ard Biesheuvel
2016-11-24 14:11                                                     ` Robert Richter
2016-11-24 14:11                                                       ` Robert Richter
2016-11-24 14:11                                                       ` Robert Richter
2016-11-24 14:23                                                       ` Ard Biesheuvel
2016-11-24 14:23                                                         ` Ard Biesheuvel
2016-11-24 14:23                                                         ` Ard Biesheuvel
2016-11-24 15:09                                                         ` Robert Richter
2016-11-24 15:09                                                           ` Robert Richter
     [not found]                                                           ` <20161124150918.GF2213-vWBEXY7mpu582hYKe6nXyg@public.gmane.org>
2016-11-24 19:26                                                             ` Robert Richter
2016-11-24 19:26                                                               ` Robert Richter
2016-11-24 19:26                                                               ` Robert Richter
2016-11-24 19:42                                                               ` Ard Biesheuvel
2016-11-24 19:42                                                                 ` Ard Biesheuvel
     [not found]                                                                 ` <CAKv+Gu_C_17RtAiw2U0OOzVik3G7KkwUTo5eiGK-HDo-maQ-bA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-11-25 11:29                                                                   ` Robert Richter
2016-11-25 11:29                                                                     ` Robert Richter
2016-11-25 11:29                                                                     ` Robert Richter
     [not found]                                                                     ` <20161125112914.GI2213-vWBEXY7mpu582hYKe6nXyg@public.gmane.org>
2016-11-25 12:28                                                                       ` Ard Biesheuvel
2016-11-25 12:28                                                                         ` Ard Biesheuvel
2016-11-25 12:28                                                                         ` Ard Biesheuvel
2016-11-25 17:01                                                                         ` Ard Biesheuvel
2016-11-25 17:01                                                                           ` Ard Biesheuvel
2016-11-25 17:01                                                                           ` Ard Biesheuvel
2016-10-18 10:18           ` Mark Rutland
2016-10-18 10:18             ` Mark Rutland
2016-10-18 10:18             ` Mark Rutland
2016-10-18 15:02             ` Robert Richter
2016-10-18 15:02               ` Robert Richter
2016-10-18 15:02               ` Robert Richter
2016-11-01 16:55   ` Robert Richter
2016-11-01 16:55     ` Robert Richter
2016-11-01 16:55     ` Robert Richter
2016-10-10 15:33 ` David Daney [this message]
2016-10-10 15:33   ` David Daney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57FBB4DE.2090502@gmail.com \
    --to=ddaney.cavm@gmail.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=david.daney@cavium.com \
    --cc=hanjun.guo@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=rrichter@cavium.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.