All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rahul Bedarkar <Rahul.Bedarkar@imgtec.com>
To: Rob Herring <robh@kernel.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
	Mark Rutland <mark.rutland@arm.com>,
	James Hartley <james.hartley@imgtec.com>,
	<linux-mips@linux-mips.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] MIPS: DTS: img: add device tree for Marduk board
Date: Thu, 13 Oct 2016 12:32:10 +0530	[thread overview]
Message-ID: <57FF3172.4010709@imgtec.com> (raw)
In-Reply-To: <20161010142152.GA7920@rob-hp-laptop>

Hi,

On Monday 10 October 2016 07:51 PM, Rob Herring wrote:
>> +
>> +	memory {
>
> Is 0 the actual base, or that gets filled in by bootloader? If the
> formet, add unit address.
>

Bootloader (uboot) can override or fixup memory node. But with version 
of bootloader I tested with, base address is hardcoded to 0 and only 
size may get changed. But since booloader can override or fixup memory 
node, I assume we don't add unit address in this case.

>> +		device_type = "memory";
>> +		reg =  <0x00000000 0x08000000>;

I now realized that size is incorrectly specified in memory node. It 
should be 256MB and not 128MB. I will fix this in v2.

Thanks,
Rahul

WARNING: multiple messages have this Message-ID (diff)
From: Rahul Bedarkar <Rahul.Bedarkar@imgtec.com>
To: Rob Herring <robh@kernel.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
	Mark Rutland <mark.rutland@arm.com>,
	James Hartley <james.hartley@imgtec.com>,
	linux-mips@linux-mips.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] MIPS: DTS: img: add device tree for Marduk board
Date: Thu, 13 Oct 2016 12:32:10 +0530	[thread overview]
Message-ID: <57FF3172.4010709@imgtec.com> (raw)
Message-ID: <20161013070210.nr_hpY979FfEA6vEHi9v8aXO2TcDuQ2U_xRDsX5JcK0@z> (raw)
In-Reply-To: <20161010142152.GA7920@rob-hp-laptop>

Hi,

On Monday 10 October 2016 07:51 PM, Rob Herring wrote:
>> +
>> +	memory {
>
> Is 0 the actual base, or that gets filled in by bootloader? If the
> formet, add unit address.
>

Bootloader (uboot) can override or fixup memory node. But with version 
of bootloader I tested with, base address is hardcoded to 0 and only 
size may get changed. But since booloader can override or fixup memory 
node, I assume we don't add unit address in this case.

>> +		device_type = "memory";
>> +		reg =  <0x00000000 0x08000000>;

I now realized that size is incorrectly specified in memory node. It 
should be 256MB and not 128MB. I will fix this in v2.

Thanks,
Rahul

  reply	other threads:[~2016-10-13  7:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-06 12:31 [PATCH 1/2] MIPS: DTS: add base device tree for Pistachio SoC Rahul Bedarkar
2016-10-06 12:31 ` Rahul Bedarkar
2016-10-06 12:31 ` Rahul Bedarkar
2016-10-06 12:31 ` [PATCH 2/2] MIPS: DTS: img: add device tree for Marduk board Rahul Bedarkar
2016-10-06 12:31   ` Rahul Bedarkar
2016-10-06 12:31   ` Rahul Bedarkar
2016-10-10 14:21   ` Rob Herring
2016-10-10 14:21     ` Rob Herring
2016-10-13  7:02     ` Rahul Bedarkar [this message]
2016-10-13  7:02       ` Rahul Bedarkar
2016-10-13  8:49       ` James Hartley
2016-10-13  8:49         ` James Hartley
2016-10-13 13:49         ` James Hartley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57FF3172.4010709@imgtec.com \
    --to=rahul.bedarkar@imgtec.com \
    --cc=devicetree@vger.kernel.org \
    --cc=james.hartley@imgtec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=mark.rutland@arm.com \
    --cc=ralf@linux-mips.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.