All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: maxims@google.com
Cc: sjg@google.com, u-boot@lists.denx.de, openbmc@lists.ozlabs.org
Subject: Re: [U-Boot] [PATCH u-boot 0/5] Aspeed I2C driver, using Driver Model.
Date: Wed, 23 Nov 2016 13:28:03 +0100	[thread overview]
Message-ID: <58358B53.5030702@denx.de> (raw)
In-Reply-To: <1479858976-139210-1-git-send-email-maxims@google.com>

Hello Maxim,

Am 23.11.2016 um 00:56 schrieb maxims@google.com:
> From: Maxim Sloyko <maxims@google.com>
>
> This series of patches is only meant for openbmc/u-boot tree.

If this series is not for U-Boot mainline, why do you post this patches
on the U-Boot Mailinglist?

bye,
Heiko
> It adds basic support for aspeed i2c. Only single master
> mode is supported with synchronous transfer.
>
> The style is inconsistent with U-Boot style guide in few places,
> but follows local style in those files.
>
> Maxim Sloyko (5):
>    aspeed/g5: Device Tree for ast2500, copied from openbmc/linux (include
>      file), plus minimal device tree configuration for ast2500 eval
>      board.
>    aspeed: Fixed incosistency in some SCU registers naming.
>    aspeed: Added function to calculate APB Clock frequency.
>    aspeed: Added function to configure pins for I2C devices.
>    aspeed: I2C driver.
>
>   arch/arm/dts/Makefile                       |    2 +
>   arch/arm/dts/aspeed-g5-evb.dts              |   28 +
>   arch/arm/dts/aspeed-g5.dtsi                 | 1278 +++++++++++++++++++++++++++
>   arch/arm/include/asm/arch-aspeed/ast_scu.h  |    6 +
>   arch/arm/include/asm/arch-aspeed/regs-scu.h |   73 +-
>   arch/arm/mach-aspeed/ast-scu.c              |   41 +-
>   drivers/i2c/Kconfig                         |    7 +
>   drivers/i2c/Makefile                        |    1 +
>   drivers/i2c/ast_i2c.c                       |  305 +++++++
>   drivers/i2c/ast_i2c.h                       |  143 +++
>   10 files changed, 1851 insertions(+), 33 deletions(-)
>   create mode 100644 arch/arm/dts/aspeed-g5-evb.dts
>   create mode 100644 arch/arm/dts/aspeed-g5.dtsi
>   create mode 100644 drivers/i2c/ast_i2c.c
>   create mode 100644 drivers/i2c/ast_i2c.h
>
> --
> 2.8.0.rc3.226.g39d4020
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH u-boot 0/5] Aspeed I2C driver, using Driver Model.
Date: Wed, 23 Nov 2016 13:28:03 +0100	[thread overview]
Message-ID: <58358B53.5030702@denx.de> (raw)
In-Reply-To: <1479858976-139210-1-git-send-email-maxims@google.com>

Hello Maxim,

Am 23.11.2016 um 00:56 schrieb maxims at google.com:
> From: Maxim Sloyko <maxims@google.com>
>
> This series of patches is only meant for openbmc/u-boot tree.

If this series is not for U-Boot mainline, why do you post this patches
on the U-Boot Mailinglist?

bye,
Heiko
> It adds basic support for aspeed i2c. Only single master
> mode is supported with synchronous transfer.
>
> The style is inconsistent with U-Boot style guide in few places,
> but follows local style in those files.
>
> Maxim Sloyko (5):
>    aspeed/g5: Device Tree for ast2500, copied from openbmc/linux (include
>      file), plus minimal device tree configuration for ast2500 eval
>      board.
>    aspeed: Fixed incosistency in some SCU registers naming.
>    aspeed: Added function to calculate APB Clock frequency.
>    aspeed: Added function to configure pins for I2C devices.
>    aspeed: I2C driver.
>
>   arch/arm/dts/Makefile                       |    2 +
>   arch/arm/dts/aspeed-g5-evb.dts              |   28 +
>   arch/arm/dts/aspeed-g5.dtsi                 | 1278 +++++++++++++++++++++++++++
>   arch/arm/include/asm/arch-aspeed/ast_scu.h  |    6 +
>   arch/arm/include/asm/arch-aspeed/regs-scu.h |   73 +-
>   arch/arm/mach-aspeed/ast-scu.c              |   41 +-
>   drivers/i2c/Kconfig                         |    7 +
>   drivers/i2c/Makefile                        |    1 +
>   drivers/i2c/ast_i2c.c                       |  305 +++++++
>   drivers/i2c/ast_i2c.h                       |  143 +++
>   10 files changed, 1851 insertions(+), 33 deletions(-)
>   create mode 100644 arch/arm/dts/aspeed-g5-evb.dts
>   create mode 100644 arch/arm/dts/aspeed-g5.dtsi
>   create mode 100644 drivers/i2c/ast_i2c.c
>   create mode 100644 drivers/i2c/ast_i2c.h
>
> --
> 2.8.0.rc3.226.g39d4020
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  parent reply	other threads:[~2016-11-23 12:38 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-22 23:56 [PATCH u-boot 0/5] Aspeed I2C driver, using Driver Model maxims
2016-11-22 23:56 ` [U-Boot] " maxims at google.com
2016-11-22 23:56 ` [PATCH u-boot 1/5] aspeed/g5: Device Tree for ast2500, copied from openbmc/linux (include file), plus minimal device tree configuration for ast2500 eval board maxims
2016-11-22 23:56   ` [U-Boot] " maxims at google.com
2016-11-23 16:13   ` Simon Glass
2016-11-23 16:23     ` Simon Glass
2016-11-23 16:23       ` [U-Boot] " Simon Glass
2016-11-22 23:56 ` [PATCH u-boot 2/5] aspeed: Fixed incosistency in some SCU registers naming maxims
2016-11-22 23:56   ` [U-Boot] " maxims at google.com
2016-11-23 16:13   ` Simon Glass
2016-11-23 16:24     ` Simon Glass
2016-11-23 16:24       ` [U-Boot] " Simon Glass
2016-11-22 23:56 ` [PATCH u-boot 3/5] aspeed: Added function to calculate APB Clock frequency maxims
2016-11-22 23:56   ` [U-Boot] " maxims at google.com
2016-11-23 16:13   ` Simon Glass
2016-11-23 16:24     ` Simon Glass
2016-11-23 16:24       ` [U-Boot] " Simon Glass
2016-11-23 17:59       ` Maxim Sloyko
2016-11-22 23:56 ` [PATCH u-boot 4/5] aspeed: Added function to configure pins for I2C devices maxims
2016-11-22 23:56   ` [U-Boot] " maxims at google.com
2016-11-23 16:13   ` Simon Glass
2016-11-23 16:24     ` Simon Glass
2016-11-23 16:24       ` [U-Boot] " Simon Glass
2016-11-23 18:06       ` Maxim Sloyko
2016-11-22 23:56 ` [PATCH u-boot 5/5] aspeed: I2C driver maxims
2016-11-22 23:56   ` [U-Boot] " maxims at google.com
2016-11-23 16:13   ` Simon Glass
2016-11-23 16:24     ` Simon Glass
2016-11-23 16:24       ` [U-Boot] " Simon Glass
2016-11-23 19:15       ` Maxim Sloyko
2016-11-23 12:28 ` Heiko Schocher [this message]
2016-11-23 12:28   ` [U-Boot] [PATCH u-boot 0/5] Aspeed I2C driver, using Driver Model Heiko Schocher
2016-11-23 16:40   ` Maxim Sloyko
2016-11-24  5:19     ` Heiko Schocher
2016-11-23 19:49 ` [PATCH u-boot v1 1/6] aspeed/g5: Device Tree for ast2500, copied from openbmc/linux (include file), plus minimal device tree configuration for ast2500 eval board Maxim Sloyko
2016-11-23 19:49   ` [PATCH u-boot v1 2/6] aspeed: Fix FUC/FUN typo in SCU Maxim Sloyko
2016-11-23 20:26     ` Simon Glass
2016-11-23 19:49   ` [PATCH u-boot v1 3/6] aspeed/scu: Add definitions needed to configure pins for I2C Maxim Sloyko
2016-11-23 20:26     ` Simon Glass
2016-11-23 19:50   ` [PATCH u-boot v1 4/6] aspeed: Add function to calculate APB Clock frequency Maxim Sloyko
2016-11-23 20:26     ` Simon Glass
2016-11-23 19:50   ` [PATCH u-boot v1 5/6] aspeed: Add function to configure pins for I2C devices Maxim Sloyko
2016-11-23 20:26     ` Simon Glass
2016-11-23 19:50   ` [PATCH u-boot v1 6/6] aspeed: I2C driver Maxim Sloyko
2016-11-23 20:26     ` Simon Glass
2016-11-24  0:04       ` Maxim Sloyko
2016-11-23 20:26   ` [PATCH u-boot v1 1/6] aspeed/g5: Device Tree for ast2500, copied from openbmc/linux (include file), plus minimal device tree configuration for ast2500 eval board Simon Glass
2016-11-24  0:28 ` [PATCH u-boot v2 " Maxim Sloyko
2016-11-24  0:28   ` [PATCH u-boot v2 2/6] aspeed: Fix FUC/FUN typo in SCU Maxim Sloyko
2016-11-24  0:28   ` [PATCH u-boot v2 3/6] aspeed/scu: Add definitions needed to configure pins for I2C Maxim Sloyko
2016-11-27 17:02     ` Simon Glass
2016-11-24  0:28   ` [PATCH u-boot v2 4/6] aspeed: Add function to calculate APB Clock frequency Maxim Sloyko
2016-11-27 17:02     ` Simon Glass
2016-11-24  0:28   ` [PATCH u-boot v2 5/6] aspeed: Add function to configure pins for I2C devices Maxim Sloyko
2016-11-24  0:28   ` [PATCH u-boot v2 6/6] aspeed: I2C driver Maxim Sloyko
2016-11-27 17:02     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58358B53.5030702@denx.de \
    --to=hs@denx.de \
    --cc=maxims@google.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=sjg@google.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.