All of lore.kernel.org
 help / color / mirror / Atom feed
From: frowand.list@gmail.com (Frank Rowand)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver
Date: Wed, 23 Nov 2016 10:23:03 -0800	[thread overview]
Message-ID: <5835DE87.6060208@gmail.com> (raw)
In-Reply-To: <5835DC2D.5080606@gmail.com>

On 11/23/16 10:13, Frank Rowand wrote:
> On 11/22/16 21:55, Sekhar Nori wrote:
>> On Tuesday 22 November 2016 11:51 PM, Frank Rowand wrote:
>>> Please note that the compatible property might contain several strings, not just
>>> a single string.
>>
>> So I guess the best thing to do is to use
>> of_property_read_string_index() and print the sting at index 0.
>>
>> Thanks,
>> Sekhar
> 
> If you want to print just one compatible value, you could use that method.
> 
> To give all of the information needed to understand the problem, the error
> message would need to include all of the strings contained in the compatible
> property and all of the .board values in the da8xx_ddrctl_board_confs[] array
> (currently only one entry, but coded to allow additional entries in the
> future).
> 
> It is hard to justify an error message that complex.
> 
> I would just print an error that no match was found.
> 
> -Frank

I just needed to read some more emails.  I see this approach was taken
in the "[PATCH v4 0/2] da8xx: fix section mismatch in new drivers"
series.

-Frank

WARNING: multiple messages have this Message-ID (diff)
From: Frank Rowand <frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>,
	Bartosz Golaszewski
	<bgolaszewski-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	Kevin Hilman <khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	Michael Turquette
	<mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>,
	Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>
Cc: LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	arm-soc
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	linux-drm
	<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	linux-devicetree
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Jyri Sarha <jsarha-l0cyMroinI0@public.gmane.org>,
	Tomi Valkeinen <tomi.valkeinen-l0cyMroinI0@public.gmane.org>,
	David Airlie <airlied-cv59FeDIM0c@public.gmane.org>,
	Laurent Pinchart
	<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
	Sudeep Holla <sudeep.holla-5wv7dgnIgG8@public.gmane.org>
Subject: Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver
Date: Wed, 23 Nov 2016 10:23:03 -0800	[thread overview]
Message-ID: <5835DE87.6060208@gmail.com> (raw)
In-Reply-To: <5835DC2D.5080606-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On 11/23/16 10:13, Frank Rowand wrote:
> On 11/22/16 21:55, Sekhar Nori wrote:
>> On Tuesday 22 November 2016 11:51 PM, Frank Rowand wrote:
>>> Please note that the compatible property might contain several strings, not just
>>> a single string.
>>
>> So I guess the best thing to do is to use
>> of_property_read_string_index() and print the sting at index 0.
>>
>> Thanks,
>> Sekhar
> 
> If you want to print just one compatible value, you could use that method.
> 
> To give all of the information needed to understand the problem, the error
> message would need to include all of the strings contained in the compatible
> property and all of the .board values in the da8xx_ddrctl_board_confs[] array
> (currently only one entry, but coded to allow additional entries in the
> future).
> 
> It is hard to justify an error message that complex.
> 
> I would just print an error that no match was found.
> 
> -Frank

I just needed to read some more emails.  I see this approach was taken
in the "[PATCH v4 0/2] da8xx: fix section mismatch in new drivers"
series.

-Frank
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Frank Rowand <frowand.list@gmail.com>
To: Sekhar Nori <nsekhar@ti.com>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Russell King <linux@armlinux.org.uk>
Cc: LKML <linux-kernel@vger.kernel.org>,
	arm-soc <linux-arm-kernel@lists.infradead.org>,
	linux-drm <dri-devel@lists.freedesktop.org>,
	linux-devicetree <devicetree@vger.kernel.org>,
	Jyri Sarha <jsarha@ti.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	David Airlie <airlied@linux.ie>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver
Date: Wed, 23 Nov 2016 10:23:03 -0800	[thread overview]
Message-ID: <5835DE87.6060208@gmail.com> (raw)
In-Reply-To: <5835DC2D.5080606@gmail.com>

On 11/23/16 10:13, Frank Rowand wrote:
> On 11/22/16 21:55, Sekhar Nori wrote:
>> On Tuesday 22 November 2016 11:51 PM, Frank Rowand wrote:
>>> Please note that the compatible property might contain several strings, not just
>>> a single string.
>>
>> So I guess the best thing to do is to use
>> of_property_read_string_index() and print the sting at index 0.
>>
>> Thanks,
>> Sekhar
> 
> If you want to print just one compatible value, you could use that method.
> 
> To give all of the information needed to understand the problem, the error
> message would need to include all of the strings contained in the compatible
> property and all of the .board values in the da8xx_ddrctl_board_confs[] array
> (currently only one entry, but coded to allow additional entries in the
> future).
> 
> It is hard to justify an error message that complex.
> 
> I would just print an error that no match was found.
> 
> -Frank

I just needed to read some more emails.  I see this approach was taken
in the "[PATCH v4 0/2] da8xx: fix section mismatch in new drivers"
series.

-Frank

  reply	other threads:[~2016-11-23 18:23 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-31 14:45 [PATCH v2 0/5] ARM: da850: new drivers for better LCDC support Bartosz Golaszewski
2016-10-31 14:45 ` Bartosz Golaszewski
2016-10-31 14:45 ` Bartosz Golaszewski
2016-10-31 14:45 ` [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver Bartosz Golaszewski
2016-10-31 14:45   ` Bartosz Golaszewski
2016-10-31 14:45   ` Bartosz Golaszewski
2016-11-01 10:10   ` Sekhar Nori
2016-11-01 10:10     ` Sekhar Nori
2016-11-01 10:10     ` Sekhar Nori
2016-11-04 20:41   ` Kevin Hilman
2016-11-04 20:41     ` Kevin Hilman
2016-11-04 20:41     ` Kevin Hilman
2016-11-09 18:24   ` Rob Herring
2016-11-09 18:24     ` Rob Herring
2016-11-09 18:24     ` Rob Herring
2016-11-11 10:47     ` Sekhar Nori
2016-11-11 10:47       ` Sekhar Nori
2016-11-11 10:47       ` Sekhar Nori
2016-11-21 16:33   ` Sekhar Nori
2016-11-21 16:33     ` Sekhar Nori
2016-11-21 16:33     ` Sekhar Nori
2016-11-21 16:48     ` Bartosz Golaszewski
2016-11-21 16:48       ` Bartosz Golaszewski
2016-11-21 16:48       ` Bartosz Golaszewski
2016-11-21 17:47       ` Robin Murphy
2016-11-21 17:47         ` Robin Murphy
2016-11-21 17:56         ` Sudeep Holla
2016-11-21 17:56           ` Sudeep Holla
2016-11-21 17:56           ` Sudeep Holla
2016-11-22  1:43     ` Frank Rowand
2016-11-22  1:43       ` Frank Rowand
2016-11-22  1:43       ` Frank Rowand
2016-11-22  6:25       ` Sekhar Nori
2016-11-22  6:25         ` Sekhar Nori
2016-11-22  6:25         ` Sekhar Nori
2016-11-22 18:21         ` Frank Rowand
2016-11-22 18:21           ` Frank Rowand
2016-11-22 18:21           ` Frank Rowand
2016-11-23  5:55           ` Sekhar Nori
2016-11-23  5:55             ` Sekhar Nori
2016-11-23  5:55             ` Sekhar Nori
2016-11-23 18:13             ` Frank Rowand
2016-11-23 18:13               ` Frank Rowand
2016-11-23 18:13               ` Frank Rowand
2016-11-23 18:23               ` Frank Rowand [this message]
2016-11-23 18:23                 ` Frank Rowand
2016-11-23 18:23                 ` Frank Rowand
2016-11-23 10:16       ` Sudeep Holla
2016-11-23 10:16         ` Sudeep Holla
2016-10-31 14:45 ` [PATCH v2 2/5] ARM: bus: da8xx-mstpri: " Bartosz Golaszewski
2016-10-31 14:45   ` Bartosz Golaszewski
2016-10-31 14:45   ` Bartosz Golaszewski
2016-11-01 10:21   ` Sekhar Nori
2016-11-01 10:21     ` Sekhar Nori
2016-11-01 10:21     ` Sekhar Nori
2016-11-04 20:42   ` Kevin Hilman
2016-11-04 20:42     ` Kevin Hilman
2016-11-04 20:42     ` Kevin Hilman
2016-11-09 18:24   ` Rob Herring
2016-11-09 18:24     ` Rob Herring
2016-11-09 18:24     ` Rob Herring
2016-11-11 10:47     ` Sekhar Nori
2016-11-11 10:47       ` Sekhar Nori
2016-11-11 10:47       ` Sekhar Nori
2016-10-31 14:45 ` [PATCH v2 3/5] ARM: dts: da850: add the mstpri and ddrctl nodes Bartosz Golaszewski
2016-10-31 14:45   ` Bartosz Golaszewski
2016-10-31 14:45   ` Bartosz Golaszewski
2016-10-31 14:45 ` [PATCH v2 4/5] ARM: dts: da850-lcdk: enable " Bartosz Golaszewski
2016-10-31 14:45   ` Bartosz Golaszewski
2016-10-31 14:45   ` Bartosz Golaszewski
2016-10-31 20:22   ` Laurent Pinchart
2016-10-31 20:22     ` Laurent Pinchart
2016-10-31 20:22     ` Laurent Pinchart
2016-10-31 20:46     ` Kevin Hilman
2016-10-31 20:46       ` Kevin Hilman
2016-10-31 20:46       ` Kevin Hilman
2016-10-31 14:45 ` [PATCH v2 5/5] ARM: dts: da850-lcdk: add tilcdc panel node Bartosz Golaszewski
2016-10-31 14:45   ` Bartosz Golaszewski
2016-10-31 14:45   ` Bartosz Golaszewski
2016-11-01 10:26   ` Sekhar Nori
2016-11-01 10:26     ` Sekhar Nori
2016-11-01 10:26     ` Sekhar Nori
2016-11-01 10:38     ` Tomi Valkeinen
2016-11-01 10:38       ` Tomi Valkeinen
2016-11-01 10:38       ` Tomi Valkeinen
2016-11-08 14:50 ` [PATCH v2 0/5] ARM: da850: new drivers for better LCDC support Sekhar Nori
2016-11-08 14:50   ` Sekhar Nori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5835DE87.6060208@gmail.com \
    --to=frowand.list@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.