From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/5] ARM: dts: da850-lcdk: enable mstpri and ddrctl nodes
Date: Mon, 31 Oct 2016 14:46:17 -0600 [thread overview]
Message-ID: <m2mvhk1c2u.fsf@baylibre.com> (raw)
In-Reply-To: <12222113.L5elJM2tqN@avalon> (Laurent Pinchart's message of "Mon, 31 Oct 2016 22:22:54 +0200")
Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes:
> Hi Bartosz,
>
> Thank you for the patch.
>
> On Monday 31 Oct 2016 15:45:37 Bartosz Golaszewski wrote:
>> Enable the MSTPRI configuration and DDR2/mDDR memory controller
>> nodes on da850-lcdk. This is needed in order to adjust the memory
>> throughput constraints for better tilcdc support.
>
> Is there a reason not to enable these unconditionally in da850.dtsi (or rather
> not disabling them) instead of handling it per board ?
Right. They should be enabled by default in DT. The drivers already
have board-specific compatible checks.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
linux-devicetree <devicetree@vger.kernel.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Michael Turquette <mturquette@baylibre.com>,
Sekhar Nori <nsekhar@ti.com>,
Russell King <linux@armlinux.org.uk>,
linux-drm <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Rob Herring <robh+dt@kernel.org>, Jyri Sarha <jsarha@ti.com>,
Frank Rowand <frowand.list@gmail.com>,
arm-soc <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 4/5] ARM: dts: da850-lcdk: enable mstpri and ddrctl nodes
Date: Mon, 31 Oct 2016 14:46:17 -0600 [thread overview]
Message-ID: <m2mvhk1c2u.fsf@baylibre.com> (raw)
In-Reply-To: <12222113.L5elJM2tqN@avalon> (Laurent Pinchart's message of "Mon, 31 Oct 2016 22:22:54 +0200")
Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes:
> Hi Bartosz,
>
> Thank you for the patch.
>
> On Monday 31 Oct 2016 15:45:37 Bartosz Golaszewski wrote:
>> Enable the MSTPRI configuration and DDR2/mDDR memory controller
>> nodes on da850-lcdk. This is needed in order to adjust the memory
>> throughput constraints for better tilcdc support.
>
> Is there a reason not to enable these unconditionally in da850.dtsi (or rather
> not disabling them) instead of handling it per board ?
Right. They should be enabled by default in DT. The drivers already
have board-specific compatible checks.
Kevin
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Michael Turquette <mturquette@baylibre.com>,
Sekhar Nori <nsekhar@ti.com>, Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Russell King <linux@armlinux.org.uk>,
LKML <linux-kernel@vger.kernel.org>,
arm-soc <linux-arm-kernel@lists.infradead.org>,
linux-drm <dri-devel@lists.freedesktop.org>,
linux-devicetree <devicetree@vger.kernel.org>,
Jyri Sarha <jsarha@ti.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
David Airlie <airlied@linux.ie>
Subject: Re: [PATCH v2 4/5] ARM: dts: da850-lcdk: enable mstpri and ddrctl nodes
Date: Mon, 31 Oct 2016 14:46:17 -0600 [thread overview]
Message-ID: <m2mvhk1c2u.fsf@baylibre.com> (raw)
In-Reply-To: <12222113.L5elJM2tqN@avalon> (Laurent Pinchart's message of "Mon, 31 Oct 2016 22:22:54 +0200")
Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes:
> Hi Bartosz,
>
> Thank you for the patch.
>
> On Monday 31 Oct 2016 15:45:37 Bartosz Golaszewski wrote:
>> Enable the MSTPRI configuration and DDR2/mDDR memory controller
>> nodes on da850-lcdk. This is needed in order to adjust the memory
>> throughput constraints for better tilcdc support.
>
> Is there a reason not to enable these unconditionally in da850.dtsi (or rather
> not disabling them) instead of handling it per board ?
Right. They should be enabled by default in DT. The drivers already
have board-specific compatible checks.
Kevin
next prev parent reply other threads:[~2016-10-31 20:46 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 14:45 [PATCH v2 0/5] ARM: da850: new drivers for better LCDC support Bartosz Golaszewski
2016-10-31 14:45 ` Bartosz Golaszewski
2016-10-31 14:45 ` Bartosz Golaszewski
2016-10-31 14:45 ` [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver Bartosz Golaszewski
2016-10-31 14:45 ` Bartosz Golaszewski
2016-10-31 14:45 ` Bartosz Golaszewski
2016-11-01 10:10 ` Sekhar Nori
2016-11-01 10:10 ` Sekhar Nori
2016-11-01 10:10 ` Sekhar Nori
2016-11-04 20:41 ` Kevin Hilman
2016-11-04 20:41 ` Kevin Hilman
2016-11-04 20:41 ` Kevin Hilman
2016-11-09 18:24 ` Rob Herring
2016-11-09 18:24 ` Rob Herring
2016-11-09 18:24 ` Rob Herring
2016-11-11 10:47 ` Sekhar Nori
2016-11-11 10:47 ` Sekhar Nori
2016-11-11 10:47 ` Sekhar Nori
2016-11-21 16:33 ` Sekhar Nori
2016-11-21 16:33 ` Sekhar Nori
2016-11-21 16:33 ` Sekhar Nori
2016-11-21 16:48 ` Bartosz Golaszewski
2016-11-21 16:48 ` Bartosz Golaszewski
2016-11-21 16:48 ` Bartosz Golaszewski
2016-11-21 17:47 ` Robin Murphy
2016-11-21 17:47 ` Robin Murphy
2016-11-21 17:56 ` Sudeep Holla
2016-11-21 17:56 ` Sudeep Holla
2016-11-21 17:56 ` Sudeep Holla
2016-11-22 1:43 ` Frank Rowand
2016-11-22 1:43 ` Frank Rowand
2016-11-22 1:43 ` Frank Rowand
2016-11-22 6:25 ` Sekhar Nori
2016-11-22 6:25 ` Sekhar Nori
2016-11-22 6:25 ` Sekhar Nori
2016-11-22 18:21 ` Frank Rowand
2016-11-22 18:21 ` Frank Rowand
2016-11-22 18:21 ` Frank Rowand
2016-11-23 5:55 ` Sekhar Nori
2016-11-23 5:55 ` Sekhar Nori
2016-11-23 5:55 ` Sekhar Nori
2016-11-23 18:13 ` Frank Rowand
2016-11-23 18:13 ` Frank Rowand
2016-11-23 18:13 ` Frank Rowand
2016-11-23 18:23 ` Frank Rowand
2016-11-23 18:23 ` Frank Rowand
2016-11-23 18:23 ` Frank Rowand
2016-11-23 10:16 ` Sudeep Holla
2016-11-23 10:16 ` Sudeep Holla
2016-10-31 14:45 ` [PATCH v2 2/5] ARM: bus: da8xx-mstpri: " Bartosz Golaszewski
2016-10-31 14:45 ` Bartosz Golaszewski
2016-10-31 14:45 ` Bartosz Golaszewski
2016-11-01 10:21 ` Sekhar Nori
2016-11-01 10:21 ` Sekhar Nori
2016-11-01 10:21 ` Sekhar Nori
2016-11-04 20:42 ` Kevin Hilman
2016-11-04 20:42 ` Kevin Hilman
2016-11-04 20:42 ` Kevin Hilman
2016-11-09 18:24 ` Rob Herring
2016-11-09 18:24 ` Rob Herring
2016-11-09 18:24 ` Rob Herring
2016-11-11 10:47 ` Sekhar Nori
2016-11-11 10:47 ` Sekhar Nori
2016-11-11 10:47 ` Sekhar Nori
2016-10-31 14:45 ` [PATCH v2 3/5] ARM: dts: da850: add the mstpri and ddrctl nodes Bartosz Golaszewski
2016-10-31 14:45 ` Bartosz Golaszewski
2016-10-31 14:45 ` Bartosz Golaszewski
2016-10-31 14:45 ` [PATCH v2 4/5] ARM: dts: da850-lcdk: enable " Bartosz Golaszewski
2016-10-31 14:45 ` Bartosz Golaszewski
2016-10-31 14:45 ` Bartosz Golaszewski
2016-10-31 20:22 ` Laurent Pinchart
2016-10-31 20:22 ` Laurent Pinchart
2016-10-31 20:22 ` Laurent Pinchart
2016-10-31 20:46 ` Kevin Hilman [this message]
2016-10-31 20:46 ` Kevin Hilman
2016-10-31 20:46 ` Kevin Hilman
2016-10-31 14:45 ` [PATCH v2 5/5] ARM: dts: da850-lcdk: add tilcdc panel node Bartosz Golaszewski
2016-10-31 14:45 ` Bartosz Golaszewski
2016-10-31 14:45 ` Bartosz Golaszewski
2016-11-01 10:26 ` Sekhar Nori
2016-11-01 10:26 ` Sekhar Nori
2016-11-01 10:26 ` Sekhar Nori
2016-11-01 10:38 ` Tomi Valkeinen
2016-11-01 10:38 ` Tomi Valkeinen
2016-11-01 10:38 ` Tomi Valkeinen
2016-11-08 14:50 ` [PATCH v2 0/5] ARM: da850: new drivers for better LCDC support Sekhar Nori
2016-11-08 14:50 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2mvhk1c2u.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.