All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gabriele Mazzotta <gabriele.mzt@gmail.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Guenter Roeck <linux@roeck-us.net>, Arnd Bergmann <arnd@arndb.de>,
	Jean Delvare <jdelvare@suse.de>,
	Steven Honeyman <stevenhoneyman@gmail.com>,
	Valdis.Kletnieks@vt.edu,
	Jochen Eisinger <jochen@penguin-breeder.org>,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH v3 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k
Date: Sat, 27 Jun 2015 12:55:40 +0000	[thread overview]
Message-ID: <5861345.suUcko3aRb@xps13> (raw)
In-Reply-To: <201506271447.16248@pali>

On Saturday 27 June 2015 14:47:16 Pali Rohár wrote:
> On Saturday 27 June 2015 13:34:30 Gabriele Mazzotta wrote:
> > Hi Pali,
> > 
> > I've just noticed an issue with this patch. See the comment here
> > below.
> > 
> > Gabriele
> > 
> > On Wednesday 29 April 2015 13:41:26 Pali Rohár wrote:
> > > @@ -750,8 +777,8 @@ static int __init i8k_init_hwmon(void)
> > > 
> > >  	if (err >= 0)
> > >  	
> > >  		i8k_hwmon_flags |= I8K_HWMON_HAVE_FAN2;
> > > 
> > > -	i8k_hwmon_dev = hwmon_device_register_with_groups(NULL, "i8k",
> > > NULL, -							  i8k_groups);
> > > +	i8k_hwmon_dev = hwmon_device_register_with_groups(NULL,
> > > "dell-smm", +							  NULL, i8k_groups);
> > 
> > dell-smm is not a valid name, see hwmon_device_register_with_groups()
> > for more info (dash not allowed). Because of this, the driver can't
> > be loaded.
> > 
> 
> How it is possible? It worked fine on my tested dell machine...
> 
> And now I see, I probably tested this change with older kernel version 
> (ubuntu/3.13) which did not have that check for invalid characters...
> 
> Renaming dell-smm to dell_smm should fix this problem, right?

Yes, everything works just fine with the underscore.

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Gabriele Mazzotta <gabriele.mzt@gmail.com>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Guenter Roeck <linux@roeck-us.net>, Arnd Bergmann <arnd@arndb.de>,
	Jean Delvare <jdelvare@suse.de>,
	Steven Honeyman <stevenhoneyman@gmail.com>,
	Valdis.Kletnieks@vt.edu,
	Jochen Eisinger <jochen@penguin-breeder.org>,
	linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [PATCH v3 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k
Date: Sat, 27 Jun 2015 14:55:40 +0200	[thread overview]
Message-ID: <5861345.suUcko3aRb@xps13> (raw)
In-Reply-To: <201506271447.16248@pali>

On Saturday 27 June 2015 14:47:16 Pali Rohár wrote:
> On Saturday 27 June 2015 13:34:30 Gabriele Mazzotta wrote:
> > Hi Pali,
> > 
> > I've just noticed an issue with this patch. See the comment here
> > below.
> > 
> > Gabriele
> > 
> > On Wednesday 29 April 2015 13:41:26 Pali Rohár wrote:
> > > @@ -750,8 +777,8 @@ static int __init i8k_init_hwmon(void)
> > > 
> > >  	if (err >= 0)
> > >  	
> > >  		i8k_hwmon_flags |= I8K_HWMON_HAVE_FAN2;
> > > 
> > > -	i8k_hwmon_dev = hwmon_device_register_with_groups(NULL, "i8k",
> > > NULL, -							  i8k_groups);
> > > +	i8k_hwmon_dev = hwmon_device_register_with_groups(NULL,
> > > "dell-smm", +							  NULL, i8k_groups);
> > 
> > dell-smm is not a valid name, see hwmon_device_register_with_groups()
> > for more info (dash not allowed). Because of this, the driver can't
> > be loaded.
> > 
> 
> How it is possible? It worked fine on my tested dell machine...
> 
> And now I see, I probably tested this change with older kernel version 
> (ubuntu/3.13) which did not have that check for invalid characters...
> 
> Renaming dell-smm to dell_smm should fix this problem, right?

Yes, everything works just fine with the underscore.

  reply	other threads:[~2015-06-27 12:55 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-28 10:24 [lm-sensors] [PATCH 0/2] i8k.c => dell-smm-hwmon.c Pali Rohár
2015-03-28 10:24 ` Pali Rohár
2015-03-28 10:24 ` [lm-sensors] [PATCH 1/2] hwmon: Rename i8k driver to dell-smm-hwmon and move it to hwmon tree Pali Rohár
2015-03-28 10:24   ` Pali Rohár
2015-03-28 14:31   ` [lm-sensors] " Guenter Roeck
2015-03-28 14:31     ` Guenter Roeck
2015-03-28 10:24 ` [lm-sensors] [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k Pali Rohár
2015-03-28 10:24   ` Pali Rohár
2015-03-28 11:04   ` [lm-sensors] " Paul Bolle
2015-03-28 11:04     ` Paul Bolle
2015-03-28 12:54     ` [lm-sensors] " Steven Honeyman
2015-03-28 12:54       ` Steven Honeyman
2015-03-28 14:13       ` [lm-sensors] " Guenter Roeck
2015-03-28 14:13         ` Guenter Roeck
2015-03-28 22:00       ` [lm-sensors] " Pali Rohár
2015-03-28 22:00         ` Pali Rohár
2015-03-28 22:20         ` [lm-sensors] " Guenter Roeck
2015-03-28 22:20           ` Guenter Roeck
2015-03-28 22:44           ` [lm-sensors] " Paul Bolle
2015-03-28 22:44             ` Paul Bolle
2015-03-29  0:55             ` [lm-sensors] " Guenter Roeck
2015-03-29  0:55               ` Guenter Roeck
2015-03-30  8:01               ` [lm-sensors] " Paul Bolle
2015-03-30  8:01                 ` Paul Bolle
2015-03-28 21:55     ` [lm-sensors] " Pali Rohár
2015-03-28 21:55       ` Pali Rohár
2015-03-28 22:06       ` [lm-sensors] " Paul Bolle
2015-03-28 22:06         ` Paul Bolle
2015-03-28 22:19         ` [lm-sensors] " Steven Honeyman
2015-03-28 22:19           ` Steven Honeyman
2015-03-28 22:33           ` [lm-sensors] " Pali Rohár
2015-03-28 22:33             ` Pali Rohár
2015-03-30  7:44             ` [lm-sensors] " Jean Delvare
2015-03-30  7:44               ` Jean Delvare
2015-03-28 14:23   ` [lm-sensors] " Guenter Roeck
2015-03-28 14:23     ` Guenter Roeck
2015-03-28 22:04     ` [lm-sensors] " Pali Rohár
2015-03-28 22:04       ` Pali Rohár
2015-03-29 12:57 ` [lm-sensors] [PATCH v2 0/2] i8k.c => dell-smm-hwmon.c Pali Rohár
2015-03-29 12:57   ` Pali Rohár
2015-03-29 12:57   ` [lm-sensors] [PATCH v2 1/2] hwmon: Rename i8k driver to dell-smm-hwmon and move it to hwmon tree Pali Rohár
2015-03-29 12:57     ` Pali Rohár
2015-03-29 12:57   ` [lm-sensors] [PATCH v2 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k Pali Rohár
2015-03-29 12:57     ` Pali Rohár
2015-04-28 12:38     ` [lm-sensors] " Greg Kroah-Hartman
2015-04-28 12:38       ` Greg Kroah-Hartman
2015-04-29 11:41       ` [lm-sensors] [PATCH v3 1/2] hwmon: Rename i8k driver to dell-smm-hwmon and move it to hwmon tree Pali Rohár
2015-04-29 11:41         ` Pali Rohár
2015-04-29 11:41         ` [lm-sensors] [PATCH v3 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k Pali Rohár
2015-04-29 11:41           ` Pali Rohár
2015-06-27 11:34           ` [lm-sensors] " Gabriele Mazzotta
2015-06-27 11:34             ` Gabriele Mazzotta
2015-06-27 12:47             ` [lm-sensors] " Pali Rohár
2015-06-27 12:47               ` Pali Rohár
2015-06-27 12:55               ` Gabriele Mazzotta [this message]
2015-06-27 12:55                 ` Gabriele Mazzotta
2015-06-27 13:01                 ` [lm-sensors] " Pali Rohár
2015-06-27 13:01                   ` Pali Rohár
2015-06-27 13:21                   ` [lm-sensors] " Gabriele Mazzotta
2015-06-27 13:21                     ` Gabriele Mazzotta
2015-04-29 12:07         ` [lm-sensors] [PATCH v3 1/2] hwmon: Rename i8k driver to dell-smm-hwmon and move it to hwmon tree Greg Kroah-Hartman
2015-04-29 12:07           ` Greg Kroah-Hartman
2015-05-14 11:16         ` [lm-sensors] " Pali Rohár
2015-05-14 11:16           ` Pali Rohár
2015-05-14 11:16           ` [lm-sensors] [PATCH v3 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k Pali Rohár
2015-05-14 11:16             ` Pali Rohár
2015-05-21 11:42             ` [lm-sensors] " Pali Rohár
2015-05-21 11:42               ` Pali Rohár
2015-03-31  3:32   ` [lm-sensors] [PATCH v2 0/2] i8k.c => dell-smm-hwmon.c Guenter Roeck
2015-03-31  3:32     ` Guenter Roeck
2015-03-31 13:56     ` [lm-sensors] " Greg Kroah-Hartman
2015-03-31 13:56       ` Greg Kroah-Hartman
2015-04-09 14:02       ` [lm-sensors] " Pali Rohár
2015-04-09 14:02         ` Pali Rohár
2015-04-21 13:30         ` [lm-sensors] " Pali Rohár
2015-04-21 13:30           ` Pali Rohár
2015-04-21 13:40           ` [lm-sensors] " Guenter Roeck
2015-04-21 13:40             ` Guenter Roeck
2015-04-21 13:52             ` [lm-sensors] " Greg Kroah-Hartman
2015-04-21 13:52               ` Greg Kroah-Hartman
2015-04-21 15:24               ` [lm-sensors] " Guenter Roeck
2015-04-21 15:24                 ` Guenter Roeck
2015-04-21 15:30                 ` [lm-sensors] " Greg Kroah-Hartman
2015-04-21 15:30                   ` Greg Kroah-Hartman
2015-04-27 18:39                   ` [lm-sensors] " Pali Rohár
2015-04-27 18:39                     ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5861345.suUcko3aRb@xps13 \
    --to=gabriele.mzt@gmail.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=jdelvare@suse.de \
    --cc=jochen@penguin-breeder.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lm-sensors@lm-sensors.org \
    --cc=pali.rohar@gmail.com \
    --cc=stevenhoneyman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.