From: Guenter Roeck <linux@roeck-us.net>
To: Steven Honeyman <stevenhoneyman@gmail.com>,
Paul Bolle <pebolle@tiscali.nl>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jean Delvare" <jdelvare@suse.de>,
"Valdis Kletnieks" <Valdis.Kletnieks@vt.edu>,
"Jochen Eisinger" <jochen@penguin-breeder.org>,
"Gabriele Mazzotta" <gabriele.mzt@gmail.com>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k
Date: Sat, 28 Mar 2015 14:13:25 +0000 [thread overview]
Message-ID: <5516B705.1010800@roeck-us.net> (raw)
In-Reply-To: <CABz95_BkAvPoBAm_tRLH6OhCk_pDfJQ8UuwfhuEYuPNt3P-PGw@mail.gmail.com>
T24gMDMvMjgvMjAxNSAwNTo1NCBBTSwgU3RldmVuIEhvbmV5bWFuIHdyb3RlOgo+IE9uIDI4IE1h
cmNoIDIwMTUgYXQgMTE6MDQsIFBhdWwgQm9sbGUgPHBlYm9sbGVAdGlzY2FsaS5ubD4gd3JvdGU6
Cj4+IE9uIFNhdCwgMjAxNS0wMy0yOCBhdCAxMToyNCArMDEwMCwgUGFsaSBSb2jDoXIgd3JvdGU6
Cj4+PiAtLS0gYS9kcml2ZXJzL2h3bW9uL0tjb25maWcKPj4+ICsrKyBiL2RyaXZlcnMvaHdtb24v
S2NvbmZpZwo+Pj4gQEAgLTE3MDMsNiArMTcwMywxNyBAQCBjb25maWcgU0VOU09SU19VTFRSQTQ1
Cj4+PiAgICAgICAgICBUaGlzIGRyaXZlciBwcm92aWRlcyBzdXBwb3J0IGZvciB0aGUgVWx0cmE0
NSB3b3Jrc3RhdGlvbiBlbnZpcm9ubWVudGFsCj4+PiAgICAgICAgICBzZW5zb3JzLgo+Pj4KPj4+
ICtjb25maWcgU0VOU09SU19ERUxMX1NNTQo+Pj4gKyAgICAgdHJpc3RhdGUgIkRlbGwgbGFwdG9w
IFNNTSBCSU9TIGh3bW9uIGRyaXZlciIKPj4+ICsgICAgIGRlcGVuZHMgT04gWDg2Cj4+Cj4+IEhv
dyBkaWQgdGhpcyBwYXN0IHlvdXIgdGVzdGluZz8KPj4KPj4+ICsgICAgIC0tLWhlbHAtLS0KPj4+
ICsgICAgICAgVGhpcyBod21vbiBkcml2ZXIgYWRkcyBzdXBwb3J0IGZvciByZXBvcnRpbmcgdGVt
cGVyYXR1cmUgb2YgZGlmZmVyZW50Cj4+PiArICAgICAgIHNlbnNvcnMgYW5kIGNvbnRyb2xzIHRo
ZSBmYW5zIG9uIERlbGwgbGFwdG9wcyB2aWEgU3lzdGVtIE1hbmFnZW1lbnQKPj4+ICsgICAgICAg
TW9kZSBwcm92aWRlZCBieSBEZWxsIEJJT1MuCj4+PiArCj4+PiArICAgICAgIFdoZW4gb3B0aW9u
IEk4SyBpcyBhbHNvIGVuYWJsZWQgdGhpcyBkcml2ZXIgcHJvdmlkZXMgbGVnYWN5IC9wcm9jL2k4
awo+Pj4gKyAgICAgICB1c2Vyc3BhY2UgaW50ZXJmYWNlIGZvciBpOGt1dGlscyBwYWNrYWdlLgo+
Pj4gKwo+Cj4gSXQncyB3b3JraW5nIE9LIGZvciBtZSAoYWZ0ZXIgZml4aW5nIHRoZSBtaXN0YWtl
IHBvaW50ZWQgb3V0IGFib3ZlKS4KPgo+IFtMYXRpdHVkZSBlNjU0MF0KPiAtLS0tLQo+IGNvcmV0
ZW1wLWlzYS0wMDAwCj4gQWRhcHRlcjogSVNBIGFkYXB0ZXIKPiBQaHlzaWNhbCBpZCAwOiAgKzUz
LjDCsEMgIChoaWdoID0gKzg0LjDCsEMsIGNyaXQgPSArMTAwLjDCsEMpCj4gQ29yZSAwOiAgICAg
ICAgICs1MS4wwrBDICAoaGlnaCA9ICs4NC4wwrBDLCBjcml0ID0gKzEwMC4wwrBDKQo+IENvcmUg
MTogICAgICAgICArNTMuMMKwQyAgKGhpZ2ggPSArODQuMMKwQywgY3JpdCA9ICsxMDAuMMKwQykK
Pgo+IGk4ay12aXJ0dWFsLTAKPiBBZGFwdGVyOiBWaXJ0dWFsIGRldmljZQo+IFByb2Nlc3NvciBG
YW46IDMxNzEgUlBNCj4gQ1BVOiAgICAgICAgICAgICs1Mi4wwrBDCj4gQW1iaWVudDogICAgICAg
ICs0Ni4wwrBDCj4gU09ESU1NOiAgICAgICAgICs0MC4wwrBDCj4gLS0tLS0KPgo+IEFtYmllbnQg
YW5kIFNPRElNTSBsb29rIHN3YXBwZWQgLSBidXQgaXQncyBwcm9iYWJseSBqdXN0IGFub3RoZXIg
RGVsbAo+IGVycm9yLiBJIHJlYWxseSBuZWVkIHRvIGxvb2sgYXQgZ2V0dGluZyBjb3JlYm9vdCBv
biB0aGlzIHRoaW5nLgo+Cj4gT24gMjggTWFyY2ggMjAxNSBhdCAxMDoyNCwgUGFsaSBSb2jDoXIg
PHBhbGkucm9oYXJAZ21haWwuY29tPiB3cm90ZToKPiAuLi4KPj4gICBjb25maWcgSThLCj4+IC0g
ICAgICAgdHJpc3RhdGUgIkRlbGwgbGFwdG9wIHN1cHBvcnQiCj4+IC0gICAgICAgc2VsZWN0IEhX
TU9OCj4+ICsgICAgICAgYm9vbCAiRGVsbCBpOGsgbGVnYWN5IGxhcHRvcCBzdXBwb3J0Igo+PiAr
ICAgICAgIHNlbGVjdCBTRU5TT1JTX0RFTExfU01NCj4gLi4uCj4+ICtjb25maWcgU0VOU09SU19E
RUxMX1NNTQo+PiArICAgICAgIHRyaXN0YXRlICJEZWxsIGxhcHRvcCBTTU0gQklPUyBod21vbiBk
cml2ZXIiCj4KPiBUaGUgb25seSBjaGFuZ2UgSSdkIHN1Z2dlc3QgaXMgbm90IHRvIGNoYW5nZSB0
aGUgdHJpc3RhdGUgdG8gYm9vbCBmb3IKPiBJOEsuIEZvcmNpbmcgdGhhdCB0byBib29sIG1lYW5z
IHRoYXQgU0VOU09SU19ERUxMX1NNTSBjYW4ndCBiZQo+IGNvbXBpbGVkIGFzIGEgbW9kdWxlIGlm
IHRoZSB1c2VyIHdpc2hlcyB0byBrZWVwIGk4ayBoYW5naW5nIGFyb3VuZAo+ICJqdXN0IGluIGNh
c2UiLiBJdCdsbCBwcm9iYWJseSBhbm5veSBkaXN0cm8ga2VybmVsIHBhY2thZ2VycyB0b28uCj4K
CkFncmVlZC4gSXQgYWxzbyBzdGlsbCBuZWVkcyB0byBzZWxlY3QgSFdNT04gKFNFTlNPUlNfREVM
TF9TTU0gaXMKb25seSB2aXNpYmxlIGlmIEhXTU9OIGlzIHNlbGVjdGVkKS4KCkd1ZW50ZXIKCgpf
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsbS1zZW5zb3Jz
IG1haWxpbmcgbGlzdApsbS1zZW5zb3JzQGxtLXNlbnNvcnMub3JnCmh0dHA6Ly9saXN0cy5sbS1z
ZW5zb3JzLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xtLXNlbnNvcnM
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Steven Honeyman <stevenhoneyman@gmail.com>,
Paul Bolle <pebolle@tiscali.nl>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jean Delvare" <jdelvare@suse.de>,
"Valdis Kletnieks" <Valdis.Kletnieks@vt.edu>,
"Jochen Eisinger" <jochen@penguin-breeder.org>,
"Gabriele Mazzotta" <gabriele.mzt@gmail.com>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k
Date: Sat, 28 Mar 2015 07:13:25 -0700 [thread overview]
Message-ID: <5516B705.1010800@roeck-us.net> (raw)
In-Reply-To: <CABz95_BkAvPoBAm_tRLH6OhCk_pDfJQ8UuwfhuEYuPNt3P-PGw@mail.gmail.com>
On 03/28/2015 05:54 AM, Steven Honeyman wrote:
> On 28 March 2015 at 11:04, Paul Bolle <pebolle@tiscali.nl> wrote:
>> On Sat, 2015-03-28 at 11:24 +0100, Pali Rohár wrote:
>>> --- a/drivers/hwmon/Kconfig
>>> +++ b/drivers/hwmon/Kconfig
>>> @@ -1703,6 +1703,17 @@ config SENSORS_ULTRA45
>>> This driver provides support for the Ultra45 workstation environmental
>>> sensors.
>>>
>>> +config SENSORS_DELL_SMM
>>> + tristate "Dell laptop SMM BIOS hwmon driver"
>>> + depends ON X86
>>
>> How did this past your testing?
>>
>>> + ---help---
>>> + This hwmon driver adds support for reporting temperature of different
>>> + sensors and controls the fans on Dell laptops via System Management
>>> + Mode provided by Dell BIOS.
>>> +
>>> + When option I8K is also enabled this driver provides legacy /proc/i8k
>>> + userspace interface for i8kutils package.
>>> +
>
> It's working OK for me (after fixing the mistake pointed out above).
>
> [Latitude e6540]
> -----
> coretemp-isa-0000
> Adapter: ISA adapter
> Physical id 0: +53.0°C (high = +84.0°C, crit = +100.0°C)
> Core 0: +51.0°C (high = +84.0°C, crit = +100.0°C)
> Core 1: +53.0°C (high = +84.0°C, crit = +100.0°C)
>
> i8k-virtual-0
> Adapter: Virtual device
> Processor Fan: 3171 RPM
> CPU: +52.0°C
> Ambient: +46.0°C
> SODIMM: +40.0°C
> -----
>
> Ambient and SODIMM look swapped - but it's probably just another Dell
> error. I really need to look at getting coreboot on this thing.
>
> On 28 March 2015 at 10:24, Pali Rohár <pali.rohar@gmail.com> wrote:
> ...
>> config I8K
>> - tristate "Dell laptop support"
>> - select HWMON
>> + bool "Dell i8k legacy laptop support"
>> + select SENSORS_DELL_SMM
> ...
>> +config SENSORS_DELL_SMM
>> + tristate "Dell laptop SMM BIOS hwmon driver"
>
> The only change I'd suggest is not to change the tristate to bool for
> I8K. Forcing that to bool means that SENSORS_DELL_SMM can't be
> compiled as a module if the user wishes to keep i8k hanging around
> "just in case". It'll probably annoy distro kernel packagers too.
>
Agreed. It also still needs to select HWMON (SENSORS_DELL_SMM is
only visible if HWMON is selected).
Guenter
next prev parent reply other threads:[~2015-03-28 14:13 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-28 10:24 [lm-sensors] [PATCH 0/2] i8k.c => dell-smm-hwmon.c Pali Rohár
2015-03-28 10:24 ` Pali Rohár
2015-03-28 10:24 ` [lm-sensors] [PATCH 1/2] hwmon: Rename i8k driver to dell-smm-hwmon and move it to hwmon tree Pali Rohár
2015-03-28 10:24 ` Pali Rohár
2015-03-28 14:31 ` [lm-sensors] " Guenter Roeck
2015-03-28 14:31 ` Guenter Roeck
2015-03-28 10:24 ` [lm-sensors] [PATCH 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k Pali Rohár
2015-03-28 10:24 ` Pali Rohár
2015-03-28 11:04 ` [lm-sensors] " Paul Bolle
2015-03-28 11:04 ` Paul Bolle
2015-03-28 12:54 ` [lm-sensors] " Steven Honeyman
2015-03-28 12:54 ` Steven Honeyman
2015-03-28 14:13 ` Guenter Roeck [this message]
2015-03-28 14:13 ` Guenter Roeck
2015-03-28 22:00 ` [lm-sensors] " Pali Rohár
2015-03-28 22:00 ` Pali Rohár
2015-03-28 22:20 ` [lm-sensors] " Guenter Roeck
2015-03-28 22:20 ` Guenter Roeck
2015-03-28 22:44 ` [lm-sensors] " Paul Bolle
2015-03-28 22:44 ` Paul Bolle
2015-03-29 0:55 ` [lm-sensors] " Guenter Roeck
2015-03-29 0:55 ` Guenter Roeck
2015-03-30 8:01 ` [lm-sensors] " Paul Bolle
2015-03-30 8:01 ` Paul Bolle
2015-03-28 21:55 ` [lm-sensors] " Pali Rohár
2015-03-28 21:55 ` Pali Rohár
2015-03-28 22:06 ` [lm-sensors] " Paul Bolle
2015-03-28 22:06 ` Paul Bolle
2015-03-28 22:19 ` [lm-sensors] " Steven Honeyman
2015-03-28 22:19 ` Steven Honeyman
2015-03-28 22:33 ` [lm-sensors] " Pali Rohár
2015-03-28 22:33 ` Pali Rohár
2015-03-30 7:44 ` [lm-sensors] " Jean Delvare
2015-03-30 7:44 ` Jean Delvare
2015-03-28 14:23 ` [lm-sensors] " Guenter Roeck
2015-03-28 14:23 ` Guenter Roeck
2015-03-28 22:04 ` [lm-sensors] " Pali Rohár
2015-03-28 22:04 ` Pali Rohár
2015-03-29 12:57 ` [lm-sensors] [PATCH v2 0/2] i8k.c => dell-smm-hwmon.c Pali Rohár
2015-03-29 12:57 ` Pali Rohár
2015-03-29 12:57 ` [lm-sensors] [PATCH v2 1/2] hwmon: Rename i8k driver to dell-smm-hwmon and move it to hwmon tree Pali Rohár
2015-03-29 12:57 ` Pali Rohár
2015-03-29 12:57 ` [lm-sensors] [PATCH v2 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k Pali Rohár
2015-03-29 12:57 ` Pali Rohár
2015-04-28 12:38 ` [lm-sensors] " Greg Kroah-Hartman
2015-04-28 12:38 ` Greg Kroah-Hartman
2015-04-29 11:41 ` [lm-sensors] [PATCH v3 1/2] hwmon: Rename i8k driver to dell-smm-hwmon and move it to hwmon tree Pali Rohár
2015-04-29 11:41 ` Pali Rohár
2015-04-29 11:41 ` [lm-sensors] [PATCH v3 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k Pali Rohár
2015-04-29 11:41 ` Pali Rohár
2015-06-27 11:34 ` [lm-sensors] " Gabriele Mazzotta
2015-06-27 11:34 ` Gabriele Mazzotta
2015-06-27 12:47 ` [lm-sensors] " Pali Rohár
2015-06-27 12:47 ` Pali Rohár
2015-06-27 12:55 ` [lm-sensors] " Gabriele Mazzotta
2015-06-27 12:55 ` Gabriele Mazzotta
2015-06-27 13:01 ` [lm-sensors] " Pali Rohár
2015-06-27 13:01 ` Pali Rohár
2015-06-27 13:21 ` [lm-sensors] " Gabriele Mazzotta
2015-06-27 13:21 ` Gabriele Mazzotta
2015-04-29 12:07 ` [lm-sensors] [PATCH v3 1/2] hwmon: Rename i8k driver to dell-smm-hwmon and move it to hwmon tree Greg Kroah-Hartman
2015-04-29 12:07 ` Greg Kroah-Hartman
2015-05-14 11:16 ` [lm-sensors] " Pali Rohár
2015-05-14 11:16 ` Pali Rohár
2015-05-14 11:16 ` [lm-sensors] [PATCH v3 2/2] hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k Pali Rohár
2015-05-14 11:16 ` Pali Rohár
2015-05-21 11:42 ` [lm-sensors] " Pali Rohár
2015-05-21 11:42 ` Pali Rohár
2015-03-31 3:32 ` [lm-sensors] [PATCH v2 0/2] i8k.c => dell-smm-hwmon.c Guenter Roeck
2015-03-31 3:32 ` Guenter Roeck
2015-03-31 13:56 ` [lm-sensors] " Greg Kroah-Hartman
2015-03-31 13:56 ` Greg Kroah-Hartman
2015-04-09 14:02 ` [lm-sensors] " Pali Rohár
2015-04-09 14:02 ` Pali Rohár
2015-04-21 13:30 ` [lm-sensors] " Pali Rohár
2015-04-21 13:30 ` Pali Rohár
2015-04-21 13:40 ` [lm-sensors] " Guenter Roeck
2015-04-21 13:40 ` Guenter Roeck
2015-04-21 13:52 ` [lm-sensors] " Greg Kroah-Hartman
2015-04-21 13:52 ` Greg Kroah-Hartman
2015-04-21 15:24 ` [lm-sensors] " Guenter Roeck
2015-04-21 15:24 ` Guenter Roeck
2015-04-21 15:30 ` [lm-sensors] " Greg Kroah-Hartman
2015-04-21 15:30 ` Greg Kroah-Hartman
2015-04-27 18:39 ` [lm-sensors] " Pali Rohár
2015-04-27 18:39 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5516B705.1010800@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Valdis.Kletnieks@vt.edu \
--cc=arnd@arndb.de \
--cc=gabriele.mzt@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.de \
--cc=jochen@penguin-breeder.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=pali.rohar@gmail.com \
--cc=pebolle@tiscali.nl \
--cc=stevenhoneyman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.