* [patch] drm/exynos/decon5433: & vs | typo @ 2017-02-14 7:46 ` Dan Carpenter 0 siblings, 0 replies; 4+ messages in thread From: Dan Carpenter @ 2017-02-14 7:46 UTC (permalink / raw) To: Inki Dae, Andrzej Hajda Cc: Joonyoung Shim, Seung-Woo Kim, Kyungmin Park, David Airlie, Kukjin Kim, Krzysztof Kozlowski, Javier Martinez Canillas, dri-devel, linux-samsung-soc, kernel-janitors "&" was obviously intended instead of "|". The original condition is always true. Fixes: b93c2e8b5d9d ("drm/exynos/decon5433: configure sysreg in case of hardware trigger") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c index 0fd6f7a18364..cca32a4fdab3 100644 --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c @@ -678,7 +678,7 @@ static int exynos5433_decon_probe(struct platform_device *pdev) ctx->out_type |= IFTYPE_I80; } - if (ctx->out_type | I80_HW_TRG) { + if (ctx->out_type & I80_HW_TRG) { ctx->sysreg = syscon_regmap_lookup_by_phandle(dev->of_node, "samsung,disp-sysreg"); if (IS_ERR(ctx->sysreg)) { ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] drm/exynos/decon5433: & vs | typo @ 2017-02-14 7:46 ` Dan Carpenter 0 siblings, 0 replies; 4+ messages in thread From: Dan Carpenter @ 2017-02-14 7:46 UTC (permalink / raw) To: Inki Dae, Andrzej Hajda Cc: Joonyoung Shim, Seung-Woo Kim, Kyungmin Park, David Airlie, Kukjin Kim, Krzysztof Kozlowski, Javier Martinez Canillas, dri-devel, linux-samsung-soc, kernel-janitors "&" was obviously intended instead of "|". The original condition is always true. Fixes: b93c2e8b5d9d ("drm/exynos/decon5433: configure sysreg in case of hardware trigger") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c index 0fd6f7a18364..cca32a4fdab3 100644 --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c @@ -678,7 +678,7 @@ static int exynos5433_decon_probe(struct platform_device *pdev) ctx->out_type |= IFTYPE_I80; } - if (ctx->out_type | I80_HW_TRG) { + if (ctx->out_type & I80_HW_TRG) { ctx->sysreg = syscon_regmap_lookup_by_phandle(dev->of_node, "samsung,disp-sysreg"); if (IS_ERR(ctx->sysreg)) { ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] drm/exynos/decon5433: & vs | typo 2017-02-14 7:46 ` Dan Carpenter @ 2017-02-20 7:11 ` Inki Dae -1 siblings, 0 replies; 4+ messages in thread From: Inki Dae @ 2017-02-20 7:11 UTC (permalink / raw) To: Dan Carpenter, Andrzej Hajda Cc: linux-samsung-soc, kernel-janitors, Seung-Woo Kim, Krzysztof Kozlowski, Javier Martinez Canillas, Kyungmin Park, Kukjin Kim, dri-devel Merged. Thanks, Inki Dae 2017년 02월 14일 16:46에 Dan Carpenter 이(가) 쓴 글: > "&" was obviously intended instead of "|". The original condition is > always true. > > Fixes: b93c2e8b5d9d ("drm/exynos/decon5433: configure sysreg in case of hardware trigger") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c > index 0fd6f7a18364..cca32a4fdab3 100644 > --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c > +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c > @@ -678,7 +678,7 @@ static int exynos5433_decon_probe(struct platform_device *pdev) > ctx->out_type |= IFTYPE_I80; > } > > - if (ctx->out_type | I80_HW_TRG) { > + if (ctx->out_type & I80_HW_TRG) { > ctx->sysreg = syscon_regmap_lookup_by_phandle(dev->of_node, > "samsung,disp-sysreg"); > if (IS_ERR(ctx->sysreg)) { > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] drm/exynos/decon5433: & vs | typo @ 2017-02-20 7:11 ` Inki Dae 0 siblings, 0 replies; 4+ messages in thread From: Inki Dae @ 2017-02-20 7:11 UTC (permalink / raw) To: Dan Carpenter, Andrzej Hajda Cc: linux-samsung-soc, kernel-janitors, Seung-Woo Kim, Krzysztof Kozlowski, Javier Martinez Canillas, Kyungmin Park, Kukjin Kim, dri-devel Merged. Thanks, Inki Dae 2017년 02월 14일 16:46에 Dan Carpenter 이(가) 쓴 글: > "&" was obviously intended instead of "|". The original condition is > always true. > > Fixes: b93c2e8b5d9d ("drm/exynos/decon5433: configure sysreg in case of hardware trigger") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c > index 0fd6f7a18364..cca32a4fdab3 100644 > --- a/drivers/gpu/drm/exynos/exynos5433_drm_decon.c > +++ b/drivers/gpu/drm/exynos/exynos5433_drm_decon.c > @@ -678,7 +678,7 @@ static int exynos5433_decon_probe(struct platform_device *pdev) > ctx->out_type |= IFTYPE_I80; > } > > - if (ctx->out_type | I80_HW_TRG) { > + if (ctx->out_type & I80_HW_TRG) { > ctx->sysreg = syscon_regmap_lookup_by_phandle(dev->of_node, > "samsung,disp-sysreg"); > if (IS_ERR(ctx->sysreg)) { > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-20 7:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20170214074945epcas4p108ec7d0fd8042271ba25b4738e2dc8bc@epcas4p1.samsung.com>
2017-02-14 7:46 ` [patch] drm/exynos/decon5433: & vs | typo Dan Carpenter
2017-02-14 7:46 ` Dan Carpenter
2017-02-20 7:11 ` Inki Dae
2017-02-20 7:11 ` Inki Dae
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.