From: Chris Zhong <zyw@rock-chips.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: add the grf clock for dw-mipi-dsi
Date: Wed, 15 Mar 2017 17:55:23 +0800 [thread overview]
Message-ID: <58C90F8B.7070102@rock-chips.com> (raw)
In-Reply-To: <3304582.Whtjx7Nypf@diego>
Hi Heiko
On 03/15/2017 05:03 PM, Heiko Stübner wrote:
> Am Mittwoch, 15. März 2017, 16:42:30 CET schrieb Chris Zhong:
>> For RK3399, the grf clock should be controlled by dw-mipi-dsi driver,
>> add the description for this clock.
>>
>> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
>> ---
>>
>> .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 2
>> +- 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t
>> xt
>> b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t
>> xt index 188f6f7..7e17a60 100644
>> ---
>> a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t
>> xt +++
>> b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t
>> xt @@ -10,7 +10,7 @@ Required properties:
>> - interrupts: Represent the controller's interrupt to the CPU(s).
>> - clocks, clock-names: Phandles to the controller's pll reference
>> clock(ref) and APB clock(pclk). For RK3399, a phy config clock
>> - (phy_cfg) is additional required. As described in [1].
>> + (phy_cfg) and a grf clock(grf) are additional required. As described in
>> [1].
> your "grf" clock is optional, as it is not present on all socs (like the
> rk3288) so should probably move to a separate section and not be in the
> required properties
For RK3399, the grf clock is required, according to the advice provided
by rob[0],
put it into "required properties " is better.
[0] https://patchwork.kernel.org/patch/9220187/
>
> Heiko
>
>
>
--
Chris Zhong
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: zyw@rock-chips.com (Chris Zhong)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] dt-bindings: add the grf clock for dw-mipi-dsi
Date: Wed, 15 Mar 2017 17:55:23 +0800 [thread overview]
Message-ID: <58C90F8B.7070102@rock-chips.com> (raw)
In-Reply-To: <3304582.Whtjx7Nypf@diego>
Hi Heiko
On 03/15/2017 05:03 PM, Heiko St?bner wrote:
> Am Mittwoch, 15. M?rz 2017, 16:42:30 CET schrieb Chris Zhong:
>> For RK3399, the grf clock should be controlled by dw-mipi-dsi driver,
>> add the description for this clock.
>>
>> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
>> ---
>>
>> .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 2
>> +- 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t
>> xt
>> b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t
>> xt index 188f6f7..7e17a60 100644
>> ---
>> a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t
>> xt +++
>> b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t
>> xt @@ -10,7 +10,7 @@ Required properties:
>> - interrupts: Represent the controller's interrupt to the CPU(s).
>> - clocks, clock-names: Phandles to the controller's pll reference
>> clock(ref) and APB clock(pclk). For RK3399, a phy config clock
>> - (phy_cfg) is additional required. As described in [1].
>> + (phy_cfg) and a grf clock(grf) are additional required. As described in
>> [1].
> your "grf" clock is optional, as it is not present on all socs (like the
> rk3288) so should probably move to a separate section and not be in the
> required properties
For RK3399, the grf clock is required, according to the advice provided
by rob[0],
put it into "required properties " is better.
[0] https://patchwork.kernel.org/patch/9220187/
>
> Heiko
>
>
>
--
Chris Zhong
WARNING: multiple messages have this Message-ID (diff)
From: Chris Zhong <zyw@rock-chips.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: linux-rockchip@lists.infradead.org,
Mark Yao <mark.yao@rock-chips.com>,
David Airlie <airlied@linux.ie>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: add the grf clock for dw-mipi-dsi
Date: Wed, 15 Mar 2017 17:55:23 +0800 [thread overview]
Message-ID: <58C90F8B.7070102@rock-chips.com> (raw)
In-Reply-To: <3304582.Whtjx7Nypf@diego>
Hi Heiko
On 03/15/2017 05:03 PM, Heiko Stübner wrote:
> Am Mittwoch, 15. März 2017, 16:42:30 CET schrieb Chris Zhong:
>> For RK3399, the grf clock should be controlled by dw-mipi-dsi driver,
>> add the description for this clock.
>>
>> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
>> ---
>>
>> .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 2
>> +- 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t
>> xt
>> b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t
>> xt index 188f6f7..7e17a60 100644
>> ---
>> a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t
>> xt +++
>> b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.t
>> xt @@ -10,7 +10,7 @@ Required properties:
>> - interrupts: Represent the controller's interrupt to the CPU(s).
>> - clocks, clock-names: Phandles to the controller's pll reference
>> clock(ref) and APB clock(pclk). For RK3399, a phy config clock
>> - (phy_cfg) is additional required. As described in [1].
>> + (phy_cfg) and a grf clock(grf) are additional required. As described in
>> [1].
> your "grf" clock is optional, as it is not present on all socs (like the
> rk3288) so should probably move to a separate section and not be in the
> required properties
For RK3399, the grf clock is required, according to the advice provided
by rob[0],
put it into "required properties " is better.
[0] https://patchwork.kernel.org/patch/9220187/
>
> Heiko
>
>
>
--
Chris Zhong
next prev parent reply other threads:[~2017-03-15 9:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 8:42 [PATCH 1/3] dt-bindings: add the grf clock for dw-mipi-dsi Chris Zhong
2017-03-15 8:42 ` Chris Zhong
2017-03-15 8:42 ` Chris Zhong
2017-03-15 8:42 ` [PATCH 2/3] drm/rockchip/dsi: enable the grf clk before writing grf registers Chris Zhong
2017-03-15 8:42 ` Chris Zhong
2017-03-15 8:42 ` Chris Zhong
2017-03-15 16:47 ` Brian Norris
2017-03-15 16:47 ` Brian Norris
2017-03-15 16:47 ` Brian Norris
2017-03-15 16:55 ` John Keeping
2017-03-15 16:55 ` John Keeping
2017-03-15 16:55 ` John Keeping
2017-03-15 8:42 ` [PATCH 3/3] drm/rockchip/dsi: correct the grf_switch_reg name Chris Zhong
2017-03-15 8:42 ` Chris Zhong
2017-03-15 8:42 ` Chris Zhong
[not found] ` <1489567352-3333-1-git-send-email-zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-03-15 9:03 ` [PATCH 1/3] dt-bindings: add the grf clock for dw-mipi-dsi Heiko Stübner
2017-03-15 9:03 ` Heiko Stübner
2017-03-15 9:03 ` Heiko Stübner
2017-03-15 9:55 ` Chris Zhong [this message]
2017-03-15 9:55 ` Chris Zhong
2017-03-15 9:55 ` Chris Zhong
2017-03-15 10:10 ` Heiko Stübner
2017-03-15 10:10 ` Heiko Stübner
2017-03-15 10:10 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58C90F8B.7070102@rock-chips.com \
--to=zyw@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.