* [PATCH] drm/amd/amdgpu: fix Tonga S3 resume hang on rhel6.8
@ 2017-03-28 9:27 Jim Qu
[not found] ` <1490693274-11017-1-git-send-email-Jim.Qu-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Jim Qu @ 2017-03-28 9:27 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Jim Qu
1. security firmware loading has moved to sw init, so this code
is useless.
2. it seems that driver could not call request_firmware on
kernel 2.6, when S3 resume. for request firmware depends on
userspace, at this time, userspace is freeze.
Change-Id: I13977c60314ffe976924b1fdad1ab10df5d93c82
Signed-off-by: Jim Qu <Jim.Qu@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
index d6cbdbe..a1a2d44 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
@@ -840,9 +840,6 @@ static int amdgpu_cgs_get_firmware_info(struct cgs_device *cgs_device,
const struct common_firmware_header *header;
struct amdgpu_firmware_info *ucode = NULL;
- if (CGS_UCODE_ID_SMU_SK == type)
- amdgpu_cgs_rel_firmware(cgs_device, CGS_UCODE_ID_SMU);
-
if (!adev->pm.fw) {
switch (adev->asic_type) {
case CHIP_TOPAZ:
--
1.9.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1490693274-11017-1-git-send-email-Jim.Qu-5C7GfCeVMHo@public.gmane.org>]
* Re: [PATCH] drm/amd/amdgpu: fix Tonga S3 resume hang on rhel6.8 [not found] ` <1490693274-11017-1-git-send-email-Jim.Qu-5C7GfCeVMHo@public.gmane.org> @ 2017-03-28 10:27 ` Huang Rui 2017-03-29 1:56 ` Zhang, Jerry (Junwei) 1 sibling, 0 replies; 3+ messages in thread From: Huang Rui @ 2017-03-28 10:27 UTC (permalink / raw) To: Jim Qu; +Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW On Tue, Mar 28, 2017 at 05:27:54PM +0800, Jim Qu wrote: > 1. security firmware loading has moved to sw init, so this code > is useless. > 2. it seems that driver could not call request_firmware on > kernel 2.6, when S3 resume. for request firmware depends on > userspace, at this time, userspace is freeze. > > Change-Id: I13977c60314ffe976924b1fdad1ab10df5d93c82 > Signed-off-by: Jim Qu <Jim.Qu@amd.com> Yes, since smu_init is moved to sw_init, we won't meet to request firmware two times yet. Acked-by: Huang Rui <ray.huang@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c > index d6cbdbe..a1a2d44 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c > @@ -840,9 +840,6 @@ static int amdgpu_cgs_get_firmware_info(struct cgs_device *cgs_device, > const struct common_firmware_header *header; > struct amdgpu_firmware_info *ucode = NULL; > > - if (CGS_UCODE_ID_SMU_SK == type) > - amdgpu_cgs_rel_firmware(cgs_device, CGS_UCODE_ID_SMU); > - > if (!adev->pm.fw) { > switch (adev->asic_type) { > case CHIP_TOPAZ: > -- > 1.9.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd/amdgpu: fix Tonga S3 resume hang on rhel6.8 [not found] ` <1490693274-11017-1-git-send-email-Jim.Qu-5C7GfCeVMHo@public.gmane.org> 2017-03-28 10:27 ` Huang Rui @ 2017-03-29 1:56 ` Zhang, Jerry (Junwei) 1 sibling, 0 replies; 3+ messages in thread From: Zhang, Jerry (Junwei) @ 2017-03-29 1:56 UTC (permalink / raw) To: Jim Qu, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW On 03/28/2017 05:27 PM, Jim Qu wrote: > 1. security firmware loading has moved to sw init, so this code > is useless. > 2. it seems that driver could not call request_firmware on > kernel 2.6, when S3 resume. for request firmware depends on > userspace, at this time, userspace is freeze. Just confirm this fix will still work well on other OS? Jerry > > Change-Id: I13977c60314ffe976924b1fdad1ab10df5d93c82 > Signed-off-by: Jim Qu <Jim.Qu@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c > index d6cbdbe..a1a2d44 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c > @@ -840,9 +840,6 @@ static int amdgpu_cgs_get_firmware_info(struct cgs_device *cgs_device, > const struct common_firmware_header *header; > struct amdgpu_firmware_info *ucode = NULL; > > - if (CGS_UCODE_ID_SMU_SK == type) > - amdgpu_cgs_rel_firmware(cgs_device, CGS_UCODE_ID_SMU); > - > if (!adev->pm.fw) { > switch (adev->asic_type) { > case CHIP_TOPAZ: > _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-29 1:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-28 9:27 [PATCH] drm/amd/amdgpu: fix Tonga S3 resume hang on rhel6.8 Jim Qu
[not found] ` <1490693274-11017-1-git-send-email-Jim.Qu-5C7GfCeVMHo@public.gmane.org>
2017-03-28 10:27 ` Huang Rui
2017-03-29 1:56 ` Zhang, Jerry (Junwei)
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.