* [PATCH v2] drm/exynos: dsi: Remove bridge node reference in removal
@ 2017-05-26 1:02 ` Hoegeun Kwon
0 siblings, 0 replies; 6+ messages in thread
From: Hoegeun Kwon @ 2017-05-26 1:02 UTC (permalink / raw)
To: inki.dae, jy0922.shim, sw0312.kim, airlied, kgene, krzk, robh+dt,
mark.rutland, catalin.marinas, will.deacon
Cc: javier, dri-devel, linux-arm-kernel, linux-samsung-soc,
linux-kernel, devicetree, a.hajda, Hoegeun Kwon
Since bridge node is referenced during in the probe, it should be
released on removal.
Suggested-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
---
Hi Inki,
This patch seems to have been forgotten... :)
Changes for V2:
- Checked for rebase 4.12-rc2
Best regards,
Hoegeun
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index 698a824..a11b795 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -1805,6 +1805,10 @@ static int exynos_dsi_probe(struct platform_device *pdev)
static int exynos_dsi_remove(struct platform_device *pdev)
{
+ struct exynos_dsi *dsi = platform_get_drvdata(pdev);
+
+ of_node_put(dsi->bridge_node);
+
pm_runtime_disable(&pdev->dev);
component_del(&pdev->dev, &exynos_dsi_component_ops);
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2] drm/exynos: dsi: Remove bridge node reference in removal
@ 2017-05-26 1:02 ` Hoegeun Kwon
0 siblings, 0 replies; 6+ messages in thread
From: Hoegeun Kwon @ 2017-05-26 1:02 UTC (permalink / raw)
To: linux-arm-kernel
Since bridge node is referenced during in the probe, it should be
released on removal.
Suggested-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
---
Hi Inki,
This patch seems to have been forgotten... :)
Changes for V2:
- Checked for rebase 4.12-rc2
Best regards,
Hoegeun
drivers/gpu/drm/exynos/exynos_drm_dsi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
index 698a824..a11b795 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
@@ -1805,6 +1805,10 @@ static int exynos_dsi_probe(struct platform_device *pdev)
static int exynos_dsi_remove(struct platform_device *pdev)
{
+ struct exynos_dsi *dsi = platform_get_drvdata(pdev);
+
+ of_node_put(dsi->bridge_node);
+
pm_runtime_disable(&pdev->dev);
component_del(&pdev->dev, &exynos_dsi_component_ops);
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] drm/exynos: dsi: Remove bridge node reference in removal
2017-05-26 1:02 ` Hoegeun Kwon
(?)
@ 2017-05-26 1:07 ` Inki Dae
-1 siblings, 0 replies; 6+ messages in thread
From: Inki Dae @ 2017-05-26 1:07 UTC (permalink / raw)
To: Hoegeun Kwon, jy0922.shim, sw0312.kim, airlied, kgene, krzk,
robh+dt, mark.rutland, catalin.marinas, will.deacon
Cc: devicetree, linux-samsung-soc, linux-kernel, dri-devel, javier,
linux-arm-kernel
2017년 05월 26일 10:02에 Hoegeun Kwon 이(가) 쓴 글:
> Since bridge node is referenced during in the probe, it should be
> released on removal.
>
> Suggested-by: Andrzej Hajda <a.hajda@samsung.com>
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
> ---
> Hi Inki,
>
> This patch seems to have been forgotten... :)
Yeah, forgot this. Merged.
Thanks,
Inki Dae
>
> Changes for V2:
>
> - Checked for rebase 4.12-rc2
>
> Best regards,
> Hoegeun
>
> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> index 698a824..a11b795 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -1805,6 +1805,10 @@ static int exynos_dsi_probe(struct platform_device *pdev)
>
> static int exynos_dsi_remove(struct platform_device *pdev)
> {
> + struct exynos_dsi *dsi = platform_get_drvdata(pdev);
> +
> + of_node_put(dsi->bridge_node);
> +
> pm_runtime_disable(&pdev->dev);
>
> component_del(&pdev->dev, &exynos_dsi_component_ops);
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] drm/exynos: dsi: Remove bridge node reference in removal
@ 2017-05-26 1:07 ` Inki Dae
0 siblings, 0 replies; 6+ messages in thread
From: Inki Dae @ 2017-05-26 1:07 UTC (permalink / raw)
To: Hoegeun Kwon, jy0922.shim, sw0312.kim, airlied, kgene, krzk,
robh+dt, mark.rutland, catalin.marinas, will.deacon
Cc: javier, dri-devel, linux-arm-kernel, linux-samsung-soc,
linux-kernel, devicetree, a.hajda
2017년 05월 26일 10:02에 Hoegeun Kwon 이(가) 쓴 글:
> Since bridge node is referenced during in the probe, it should be
> released on removal.
>
> Suggested-by: Andrzej Hajda <a.hajda@samsung.com>
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
> ---
> Hi Inki,
>
> This patch seems to have been forgotten... :)
Yeah, forgot this. Merged.
Thanks,
Inki Dae
>
> Changes for V2:
>
> - Checked for rebase 4.12-rc2
>
> Best regards,
> Hoegeun
>
> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> index 698a824..a11b795 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -1805,6 +1805,10 @@ static int exynos_dsi_probe(struct platform_device *pdev)
>
> static int exynos_dsi_remove(struct platform_device *pdev)
> {
> + struct exynos_dsi *dsi = platform_get_drvdata(pdev);
> +
> + of_node_put(dsi->bridge_node);
> +
> pm_runtime_disable(&pdev->dev);
>
> component_del(&pdev->dev, &exynos_dsi_component_ops);
>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v2] drm/exynos: dsi: Remove bridge node reference in removal
@ 2017-05-26 1:07 ` Inki Dae
0 siblings, 0 replies; 6+ messages in thread
From: Inki Dae @ 2017-05-26 1:07 UTC (permalink / raw)
To: linux-arm-kernel
2017? 05? 26? 10:02? Hoegeun Kwon ?(?) ? ?:
> Since bridge node is referenced during in the probe, it should be
> released on removal.
>
> Suggested-by: Andrzej Hajda <a.hajda@samsung.com>
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
> ---
> Hi Inki,
>
> This patch seems to have been forgotten... :)
Yeah, forgot this. Merged.
Thanks,
Inki Dae
>
> Changes for V2:
>
> - Checked for rebase 4.12-rc2
>
> Best regards,
> Hoegeun
>
> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> index 698a824..a11b795 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -1805,6 +1805,10 @@ static int exynos_dsi_probe(struct platform_device *pdev)
>
> static int exynos_dsi_remove(struct platform_device *pdev)
> {
> + struct exynos_dsi *dsi = platform_get_drvdata(pdev);
> +
> + of_node_put(dsi->bridge_node);
> +
> pm_runtime_disable(&pdev->dev);
>
> component_del(&pdev->dev, &exynos_dsi_component_ops);
>
^ permalink raw reply [flat|nested] 6+ messages in thread