Re: [PATCH 1/2] dt-bindings: pwm: rockchip: Add rockchip,rk3528-pwm

From: Heiko Stuebner <heiko@sntech.de>
To: "Chukun Pan" <amadeus@jmu.edu.cn>,
	"Uwe Kleine-König" <ukleinek@kernel.org>
Cc: Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Jonas Karlman <jonas@kwiboo.se>, Yao Zi <ziyao@disroot.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-pwm@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: pwm: rockchip: Add rockchip,rk3528-pwm
Date: Sat, 08 Mar 2025 17:25:09 +0100	[thread overview]
Message-ID: <5942715.DvuYhMxLoT@phil> (raw)
In-Reply-To: <pnlkcc2rl7fegltovgtvp4xdxhonw72rclvhn7qmvb7xyuullm@xf5x6lcigji3>

Hi Uwe,

Am Freitag, 7. März 2025, 18:07:47 MEZ schrieb Uwe Kleine-König:
> On Fri, Mar 07, 2025 at 08:00:03PM +0800, Chukun Pan wrote:
> > Document pwm compatible for rk3528 which is fallback compatible
> > of rk3328-pwm group.
> > 
> > Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> 
> to prevent binding warnings it's probably sensible to let both patches
> go in via the same tree at the same time. Feel free to take the binding
> patch via rockchip/arm-soc.
> 
> Acked-by: Uwe Kleine-König <ukleinek@kernel.org>

You already have the rk3562 binding in your for-next branch [0], which
could create merge-conflicts later on.

This patch already contains it, so should fit neatly onto your branch.

And binding warnings only come from linux-next, so won't trigger as the
pwm will feed the binding there too :-)

So I guess it might be better to take the binding through the pwm tree
and me then picking up the dts patch.

For the binding
Reviewed-by: Heiko Stuebner <heiko@sntech.de>

[0] https://web.git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git/commit/?h=pwm/for-next&id=058210e84b48dbb670a6bf72afaed6fbd8043a37