Re: [PATCH 0/2] arm64: dts: rockchip: Add pwm nodes for RK3528

From: Heiko Stuebner <heiko@sntech.de>
To: Chukun Pan <amadeus@jmu.edu.cn>, Jonas Karlman <jonas@kwiboo.se>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
	krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 0/2] arm64: dts: rockchip: Add pwm nodes for RK3528
Date: Wed, 12 Mar 2025 20:38:31 +0100	[thread overview]
Message-ID: <7779050.EvYhyI6sBW@phil> (raw)
In-Reply-To: <b7d8d385-81ee-4947-ab8f-1da43843464b@kwiboo.se>

Am Mittwoch, 12. März 2025, 16:00:00 MEZ schrieb Jonas Karlman:
> Hi Chukun,
> 
> On 2025-03-12 15:35, Chukun Pan wrote:
> > Hi,
> > 
> >> The pinctrl-names should be changed to "default" and not "active",
> >> something you can fixup or do you want a patch?

so yes of course the pinctrl needs to be default - simply because
that's the only pinctrl state mainline supports.

But judging by the fact that you're discussing working vs. non-working
below, can you please check if we should drop the patch for 6.15 till
that is solved?

Thanks a lot
Heiko

> > Sorry I've been a bit busy this week and forgot to send the v2 patch.
> > In rk3528.dtsi, the uart and upcoming i2c nodes do not have pinctrl,
> > so I prefer to remove them.
> > 
> >>> Unlike other SoCs, pinctrl-names need to be in "active" state,
> >>> I'm not sure about this, but otherwise the pwm-regulator will
> >>> not work properly.
> > 
> > BTW, setting the pinctrl of pwm corresponding to pwm-regulator
> > to "default" will cause kernel boot suspended.
> > Sorry but do you know why?
> 
> Not an issue I have seen, do you have any more logs or details? E.g.
> what board you use, full regulator node, do you have operating points
> defined etc.
> 
> I have runtime tested a branch at [1], that use pinctrl-names = default,
> have vdd_arm and vdd_logic defined, also an opp table for cpu and gpu.
> 
> For E20C there is a commit to enable the vdd_logic, however without gpu
> enabled and a mali-supply the pwm-regulator is initialized to
> max-microvolt by Linux. Have instead updated U-Boot to initialize the
> pwm-regulator's:
> 
> ```
> &vdd_arm {
> 	regulator-init-microvolt = <953000>;
> };
> 
> &vdd_logic {
> 	regulator-init-microvolt = <900000>;
> };
> ```
> 
> [1] https://github.com/Kwiboo/linux-rockchip/commits/next-20250311-rk3528/
> 
> Regards,
> Jonas
> 
> > 
> > e.g.
> > ```
> > vdd_arm: regulator-vdd-arm {
> > 	compatible = "pwm-regulator";
> > 	pwms = <&pwm1 0 5000 1>;
> > 	...
> > };
> > 
> > &pwm1 {
> > 	pinctrl-0 = <&pwm1m0_pins>;
> > 	pinctrl-names = "default";
> > 	status = "okay";
> > };
> > ```
> > 
> > Thanks,
> > Chukun
> > 
> > --
> > 2.25.1
> > 
> 
> 