All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark yao <mark.yao@rock-chips.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3.1 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support
Date: Thu, 22 Jun 2017 16:02:44 +0800	[thread overview]
Message-ID: <594B79A4.1000509@rock-chips.com> (raw)
In-Reply-To: <1751555.73cFbViMXZ@phil>

On 2017年06月22日 15:31, Heiko Stuebner wrote:
>> +
>> >+/**
>> >+ * struct rockchip_hdmi_chip_data - splite the grf setting of kind of chips
>> >+ * @lcdsel_grf_reg: grf register offset of lcdc select
>> >+ * @lcdsel_big: reg value of selecting vop big for HDMI
>> >+ * @lcdsel_lit: reg value of selecting vop little for HDMI
>> >+ */
>> >+struct rockchip_hdmi_chip_data {
>> >+	u32	lcdsel_grf_reg;
> How do you plan on handling the rk3368 (with only one VOP and thus
> no selection happening)? I'd just make the above an int, so we could
> set it to -1 for that case. (value 0 is after all a valid reg).

It's a problem handling on rk3368, using -1 to judge means that we need
initial the lcdsel_grf_reg to -1 on rk3368 platform, we need always add a platform
data to handle it, seems not good enough.

Since the hdmi chip data only use for vop selection, maybe we can judge with
checking hdmi->chip_data == NULL for the case.

Mark.

>
> Heiko
>
>

-- 
Ｍark Yao


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: mark.yao@rock-chips.com (Mark yao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3.1 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support
Date: Thu, 22 Jun 2017 16:02:44 +0800	[thread overview]
Message-ID: <594B79A4.1000509@rock-chips.com> (raw)
In-Reply-To: <1751555.73cFbViMXZ@phil>

On 2017?06?22? 15:31, Heiko Stuebner wrote:
>> +
>> >+/**
>> >+ * struct rockchip_hdmi_chip_data - splite the grf setting of kind of chips
>> >+ * @lcdsel_grf_reg: grf register offset of lcdc select
>> >+ * @lcdsel_big: reg value of selecting vop big for HDMI
>> >+ * @lcdsel_lit: reg value of selecting vop little for HDMI
>> >+ */
>> >+struct rockchip_hdmi_chip_data {
>> >+	u32	lcdsel_grf_reg;
> How do you plan on handling the rk3368 (with only one VOP and thus
> no selection happening)? I'd just make the above an int, so we could
> set it to -1 for that case. (value 0 is after all a valid reg).

It's a problem handling on rk3368, using -1 to judge means that we need
initial the lcdsel_grf_reg to -1 on rk3368 platform, we need always add a platform
data to handle it, seems not good enough.

Since the hdmi chip data only use for vop selection, maybe we can judge with
checking hdmi->chip_data == NULL for the case.

Mark.

>
> Heiko
>
>

-- 
?ark Yao

WARNING: multiple messages have this Message-ID (diff)
From: Mark yao <mark.yao@rock-chips.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3.1 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support
Date: Thu, 22 Jun 2017 16:02:44 +0800	[thread overview]
Message-ID: <594B79A4.1000509@rock-chips.com> (raw)
In-Reply-To: <1751555.73cFbViMXZ@phil>

On 2017年06月22日 15:31, Heiko Stuebner wrote:
>> +
>> >+/**
>> >+ * struct rockchip_hdmi_chip_data - splite the grf setting of kind of chips
>> >+ * @lcdsel_grf_reg: grf register offset of lcdc select
>> >+ * @lcdsel_big: reg value of selecting vop big for HDMI
>> >+ * @lcdsel_lit: reg value of selecting vop little for HDMI
>> >+ */
>> >+struct rockchip_hdmi_chip_data {
>> >+	u32	lcdsel_grf_reg;
> How do you plan on handling the rk3368 (with only one VOP and thus
> no selection happening)? I'd just make the above an int, so we could
> set it to -1 for that case. (value 0 is after all a valid reg).

It's a problem handling on rk3368, using -1 to judge means that we need
initial the lcdsel_grf_reg to -1 on rk3368 platform, we need always add a platform
data to handle it, seems not good enough.

Since the hdmi chip data only use for vop selection, maybe we can judge with
checking hdmi->chip_data == NULL for the case.

Mark.

>
> Heiko
>
>

-- 
Ｍark Yao

  reply	other threads:[~2017-06-22  8:02 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-09  7:10 [PATCH v3 0/3] Add RK3399 HDMI Support Mark Yao
2017-06-09  7:10 ` Mark Yao
2017-06-09  7:10 ` Mark Yao
2017-06-09  7:10 ` [PATCH v3 1/3] drm/rockchip: dw_hdmi: add RK3399 HDMI support Mark Yao
2017-06-09  7:10   ` Mark Yao
2017-06-09  7:10   ` Mark Yao
2017-06-14 15:32   ` Rob Herring
2017-06-14 15:32     ` Rob Herring
2017-06-14 15:32     ` Rob Herring
     [not found]   ` <1496992236-10634-1-git-send-email-mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-06-22  7:17     ` [PATCH v3.1 " Mark Yao
2017-06-22  7:17       ` Mark Yao
2017-06-22  7:17       ` Mark Yao
2017-06-22  7:31       ` Heiko Stuebner
2017-06-22  7:31         ` Heiko Stuebner
2017-06-22  7:31         ` Heiko Stuebner
2017-06-22  8:02         ` Mark yao [this message]
2017-06-22  8:02           ` Mark yao
2017-06-22  8:02           ` Mark yao
2017-06-22  8:25           ` Heiko Stuebner
2017-06-22  8:25             ` Heiko Stuebner
2017-06-22  8:25             ` Heiko Stuebner
2017-06-22 17:04       ` Rob Herring
2017-06-22 17:04         ` Rob Herring
2017-06-09  7:10 ` [PATCH v3 2/3] drm/rockchip: dw_hdmi: introduce the VPLL clock setting Mark Yao
2017-06-09  7:10   ` Mark Yao
2017-06-09  7:10   ` Mark Yao
2017-06-14 15:35   ` Rob Herring
2017-06-14 15:35     ` Rob Herring
2017-06-14 15:35     ` Rob Herring
2017-06-09  7:10 ` [PATCH v3 3/3] drm/rockchip: dw_hdmi: introduce the pclk for grf Mark Yao
2017-06-09  7:10   ` Mark Yao
2017-06-09  7:10   ` Mark Yao
     [not found]   ` <1496992247-10727-1-git-send-email-mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-06-14 18:38     ` Rob Herring
2017-06-14 18:38       ` Rob Herring
2017-06-14 18:38       ` Rob Herring
     [not found] ` <1496992228-10582-1-git-send-email-mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-06-23  1:04   ` [PATCH v3 0/3] Add RK3399 HDMI Support Mark yao
2017-06-23  1:04     ` Mark yao
2017-06-23  1:04     ` Mark yao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=594B79A4.1000509@rock-chips.com \
    --to=mark.yao@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.