From: Mark yao <mark.yao@rock-chips.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/5] dt-bindings: display: fill Documents for series of vop
Date: Wed, 12 Jul 2017 08:21:00 +0800 [thread overview]
Message-ID: <59656B6C.5020308@rock-chips.com> (raw)
In-Reply-To: <7391489.lxuf2bMt0N@diego>
On 2017年07月11日 20:45, Heiko Stübner wrote:
> Hi Mark,
>
> Am Dienstag, 11. Juli 2017, 20:42:38 CEST schrieb Mark Yao:
>> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
>> ---
>> Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 4
>> ++++ 1 file changed, 4 insertions(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
>> b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt index
>> 9eb3f0a..11fa3b0 100644
>> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
>> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
>> @@ -8,8 +8,12 @@ Required properties:
>> - compatible: value should be one of the following
>> "rockchip,rk3036-vop";
>> "rockchip,rk3288-vop";
>> + "rockchip,rk3368-vop";
>> + "rockchip,rk3366-vop";
>> "rockchip,rk3399-vop-big";
>> "rockchip,rk3399-vop-lit";
>> + "rockchip,rk322x-vop";
> please don't use wildcards in devicetree compatibles. We've somehow
> standardized on using rk3228 for both the rk3228 and rk3229 (which are
> nearly the same soc with some speed adjustments)
>
> So,
> + "rockchip,rk3228-vop";
> please
>
>
> Thanks
> Heiko
Got it, I will fix it at next version
Thanks
Mark
>
>> + "rockchip,rk3328-vop";
>>
>> - interrupts: should contain a list of all VOP IP block interrupts in the
>> order: VSYNC, LCD_SYSTEM. The interrupt specifier
>
>
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: mark.yao@rock-chips.com (Mark yao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] dt-bindings: display: fill Documents for series of vop
Date: Wed, 12 Jul 2017 08:21:00 +0800 [thread overview]
Message-ID: <59656B6C.5020308@rock-chips.com> (raw)
In-Reply-To: <7391489.lxuf2bMt0N@diego>
On 2017?07?11? 20:45, Heiko St?bner wrote:
> Hi Mark,
>
> Am Dienstag, 11. Juli 2017, 20:42:38 CEST schrieb Mark Yao:
>> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
>> ---
>> Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 4
>> ++++ 1 file changed, 4 insertions(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
>> b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt index
>> 9eb3f0a..11fa3b0 100644
>> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
>> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
>> @@ -8,8 +8,12 @@ Required properties:
>> - compatible: value should be one of the following
>> "rockchip,rk3036-vop";
>> "rockchip,rk3288-vop";
>> + "rockchip,rk3368-vop";
>> + "rockchip,rk3366-vop";
>> "rockchip,rk3399-vop-big";
>> "rockchip,rk3399-vop-lit";
>> + "rockchip,rk322x-vop";
> please don't use wildcards in devicetree compatibles. We've somehow
> standardized on using rk3228 for both the rk3228 and rk3229 (which are
> nearly the same soc with some speed adjustments)
>
> So,
> + "rockchip,rk3228-vop";
> please
>
>
> Thanks
> Heiko
Got it, I will fix it at next version
Thanks
Mark
>
>> + "rockchip,rk3328-vop";
>>
>> - interrupts: should contain a list of all VOP IP block interrupts in the
>> order: VSYNC, LCD_SYSTEM. The interrupt specifier
>
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Mark yao <mark.yao@rock-chips.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: David Airlie <airlied@linux.ie>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] dt-bindings: display: fill Documents for series of vop
Date: Wed, 12 Jul 2017 08:21:00 +0800 [thread overview]
Message-ID: <59656B6C.5020308@rock-chips.com> (raw)
In-Reply-To: <7391489.lxuf2bMt0N@diego>
On 2017年07月11日 20:45, Heiko Stübner wrote:
> Hi Mark,
>
> Am Dienstag, 11. Juli 2017, 20:42:38 CEST schrieb Mark Yao:
>> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
>> ---
>> Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 4
>> ++++ 1 file changed, 4 insertions(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
>> b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt index
>> 9eb3f0a..11fa3b0 100644
>> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
>> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
>> @@ -8,8 +8,12 @@ Required properties:
>> - compatible: value should be one of the following
>> "rockchip,rk3036-vop";
>> "rockchip,rk3288-vop";
>> + "rockchip,rk3368-vop";
>> + "rockchip,rk3366-vop";
>> "rockchip,rk3399-vop-big";
>> "rockchip,rk3399-vop-lit";
>> + "rockchip,rk322x-vop";
> please don't use wildcards in devicetree compatibles. We've somehow
> standardized on using rk3228 for both the rk3228 and rk3229 (which are
> nearly the same soc with some speed adjustments)
>
> So,
> + "rockchip,rk3228-vop";
> please
>
>
> Thanks
> Heiko
Got it, I will fix it at next version
Thanks
Mark
>
>> + "rockchip,rk3328-vop";
>>
>> - interrupts: should contain a list of all VOP IP block interrupts in the
>> order: VSYNC, LCD_SYSTEM. The interrupt specifier
>
>
>
>
next prev parent reply other threads:[~2017-07-12 0:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 12:41 [PATCH 0/5] drm/rockchip: add all full framework vop support Mark Yao
2017-07-11 12:41 ` Mark Yao
2017-07-11 12:41 ` Mark Yao
2017-07-11 12:42 ` [PATCH 1/5] drm/rockchip: vop: get rid of register init table Mark Yao
2017-07-11 12:42 ` Mark Yao
2017-07-11 12:42 ` Mark Yao
2017-07-11 12:42 ` [PATCH 2/5] drm/rockchip: vop: support verify registers with vop version Mark Yao
2017-07-11 12:42 ` Mark Yao
2017-07-11 12:42 ` Mark Yao
2017-07-11 12:42 ` [PATCH 3/5] drm/rockchip: vop: move line_flag_num to interrupt registers Mark Yao
2017-07-11 12:42 ` Mark Yao
2017-07-11 12:42 ` Mark Yao
2017-07-11 12:42 ` [PATCH 4/5] drm/rockchip: vop: add a series of vop support Mark Yao
2017-07-11 12:42 ` Mark Yao
2017-07-11 12:42 ` Mark Yao
2017-07-11 12:42 ` [PATCH 5/5] dt-bindings: display: fill Documents for series of vop Mark Yao
2017-07-11 12:42 ` Mark Yao
2017-07-11 12:42 ` Mark Yao
[not found] ` <1499776958-17062-1-git-send-email-mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-07-11 12:45 ` Heiko Stübner
2017-07-11 12:45 ` Heiko Stübner
2017-07-11 12:45 ` Heiko Stübner
2017-07-12 0:21 ` Mark yao [this message]
2017-07-12 0:21 ` Mark yao
2017-07-12 0:21 ` Mark yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59656B6C.5020308@rock-chips.com \
--to=mark.yao@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.