All of lore.kernel.org
 help / color / mirror / Atom feed
From: wangyijing <wangyijing@huawei.com>
To: John Garry <john.garry@huawei.com>,
	jejb@linux.vnet.ibm.com, martin.petersen@oracle.com
Cc: chenqilin2@huawei.com, hare@suse.com, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org, chenxiang66@hisilicon.com,
	huangdaode@hisilicon.com, wangkefeng.wang@huawei.com,
	zhaohongjiang@huawei.com, dingtianhong@huawei.com,
	guohanjun@huawei.com, yanaijie@huawei.com, hch@lst.de,
	dan.j.williams@intel.com, emilne@redhat.com, thenzl@redhat.com,
	wefu@redhat.com, charles.chenxin@huawei.com,
	chenweilong@huawei.com, Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH v3 2/7] libsas: remove unused port_gone_completion
Date: Wed, 12 Jul 2017 10:18:31 +0800	[thread overview]
Message-ID: <596586F7.80307@huawei.com> (raw)
In-Reply-To: <e76b392c-8fd7-9907-9a10-87b8c5b737dc@huawei.com>



在 2017/7/11 23:54, John Garry 写道:
> On 10/07/2017 08:06, Yijing Wang wrote:
>> No one uses the port_gone_completion in struct asd_sas_port,
>> clean it out.
> 
> This seems like a reasonable tidy-up patch which could be taken in isolation, having no dependency on the rest of the series.

Yes.

> 
>>
>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>> ---
>>  include/scsi/libsas.h | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h
>> index c41328d..628f48b 100644
>> --- a/include/scsi/libsas.h
>> +++ b/include/scsi/libsas.h
>> @@ -263,8 +263,6 @@ struct sas_discovery {
>>  /* The port struct is Class:RW, driver:RO */
>>  struct asd_sas_port {
>>  /* private: */
>> -    struct completion port_gone_completion;
>> -
>>      struct sas_discovery disc;
>>      struct domain_device *port_dev;
>>      spinlock_t dev_list_lock;
>>
> 
> 
> 
> .
> 

WARNING: multiple messages have this Message-ID (diff)
From: wangyijing <wangyijing@huawei.com>
To: John Garry <john.garry@huawei.com>, <jejb@linux.vnet.ibm.com>,
	<martin.petersen@oracle.com>
Cc: <chenqilin2@huawei.com>, <hare@suse.com>,
	<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<chenxiang66@hisilicon.com>, <huangdaode@hisilicon.com>,
	<wangkefeng.wang@huawei.com>, <zhaohongjiang@huawei.com>,
	<dingtianhong@huawei.com>, <guohanjun@huawei.com>,
	<yanaijie@huawei.com>, <hch@lst.de>, <dan.j.williams@intel.com>,
	<emilne@redhat.com>, <thenzl@redhat.com>, <wefu@redhat.com>,
	<charles.chenxin@huawei.com>, <chenweilong@huawei.com>,
	Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH v3 2/7] libsas: remove unused port_gone_completion
Date: Wed, 12 Jul 2017 10:18:31 +0800	[thread overview]
Message-ID: <596586F7.80307@huawei.com> (raw)
In-Reply-To: <e76b392c-8fd7-9907-9a10-87b8c5b737dc@huawei.com>



在 2017/7/11 23:54, John Garry 写道:
> On 10/07/2017 08:06, Yijing Wang wrote:
>> No one uses the port_gone_completion in struct asd_sas_port,
>> clean it out.
> 
> This seems like a reasonable tidy-up patch which could be taken in isolation, having no dependency on the rest of the series.

Yes.

> 
>>
>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>> ---
>>  include/scsi/libsas.h | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h
>> index c41328d..628f48b 100644
>> --- a/include/scsi/libsas.h
>> +++ b/include/scsi/libsas.h
>> @@ -263,8 +263,6 @@ struct sas_discovery {
>>  /* The port struct is Class:RW, driver:RO */
>>  struct asd_sas_port {
>>  /* private: */
>> -    struct completion port_gone_completion;
>> -
>>      struct sas_discovery disc;
>>      struct domain_device *port_dev;
>>      spinlock_t dev_list_lock;
>>
> 
> 
> 
> .
> 

  reply	other threads:[~2017-07-12  2:18 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-10  7:06 [PATCH v3 0/7] Enhance libsas hotplug feature Yijing Wang
2017-07-10  7:06 ` Yijing Wang
2017-07-10  7:06 ` [PATCH v3 1/7] libsas: Use static sas event pool to appease sas event lost Yijing Wang
2017-07-10  7:06   ` Yijing Wang
2017-07-11 15:37   ` John Garry
2017-07-11 15:37     ` John Garry
2017-07-12  2:06     ` wangyijing
2017-07-12  2:06       ` wangyijing
2017-07-12  8:17       ` John Garry
2017-07-12  8:17         ` John Garry
2017-07-12  8:47         ` wangyijing
2017-07-12  8:47           ` wangyijing
2017-07-12 10:13           ` John Garry
2017-07-12 10:13             ` John Garry
2017-07-13  2:13             ` wangyijing
2017-07-13  2:13               ` wangyijing
2017-07-14  6:40   ` Hannes Reinecke
2017-07-10  7:06 ` [PATCH v3 2/7] libsas: remove unused port_gone_completion Yijing Wang
2017-07-10  7:06   ` Yijing Wang
2017-07-11 15:54   ` John Garry
2017-07-11 15:54     ` John Garry
2017-07-12  2:18     ` wangyijing [this message]
2017-07-12  2:18       ` wangyijing
2017-07-14  6:40   ` Hannes Reinecke
2017-07-10  7:06 ` [PATCH v3 3/7] libsas: Use new workqueue to run sas event Yijing Wang
2017-07-10  7:06   ` Yijing Wang
2017-07-14  6:42   ` Hannes Reinecke
2017-07-10  7:06 ` [PATCH v3 4/7] libsas: add sas event wait-complete support Yijing Wang
2017-07-10  7:06   ` Yijing Wang
2017-07-14  6:51   ` Hannes Reinecke
2017-07-14  7:46     ` wangyijing
2017-07-14  7:46       ` wangyijing
2017-07-14  8:42     ` John Garry
2017-07-14  8:42       ` John Garry
2017-07-10  7:06 ` [PATCH v3 5/7] libsas: add a new workqueue to run probe/destruct discovery event Yijing Wang
2017-07-10  7:06   ` Yijing Wang
2017-07-12 16:50   ` John Garry
2017-07-12 16:50     ` John Garry
2017-07-13  2:36     ` wangyijing
2017-07-13  2:36       ` wangyijing
2017-07-14  6:52   ` Hannes Reinecke
2017-07-10  7:06 ` [PATCH v3 6/7] libsas: add wait-complete support to sync " Yijing Wang
2017-07-10  7:06   ` Yijing Wang
2017-07-12 13:51   ` John Garry
2017-07-12 13:51     ` John Garry
2017-07-13  2:19     ` wangyijing
2017-07-13  2:19       ` wangyijing
2017-07-14  6:53   ` Hannes Reinecke
2017-07-10  7:06 ` [PATCH v3 7/7] libsas: release disco mutex during waiting in sas_ex_discover_end_dev Yijing Wang
2017-07-10  7:06   ` Yijing Wang
2017-07-13 16:10   ` John Garry
2017-07-13 16:10     ` John Garry
2017-07-14  1:44     ` wangyijing
2017-07-14  1:44       ` wangyijing
2017-07-14  8:26       ` John Garry
2017-07-14  8:26         ` John Garry
2017-07-14  6:55   ` Hannes Reinecke
2017-07-12  9:59 ` [PATCH v3 0/7] Enhance libsas hotplug feature John Garry
2017-07-12  9:59   ` John Garry
2017-07-12 11:56   ` Johannes Thumshirn
2017-07-13  1:27   ` wangyijing
2017-07-13  1:27     ` wangyijing
2017-07-13  1:37   ` wangyijing
2017-07-13  1:37     ` wangyijing
2017-07-13  8:08     ` John Garry
2017-07-13  8:08       ` John Garry
2017-07-13  8:38       ` wangyijing
2017-07-13  8:38         ` wangyijing
2017-07-14  8:19 ` wangyijing
2017-07-14  8:19   ` wangyijing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=596586F7.80307@huawei.com \
    --to=wangyijing@huawei.com \
    --cc=charles.chenxin@huawei.com \
    --cc=chenqilin2@huawei.com \
    --cc=chenweilong@huawei.com \
    --cc=chenxiang66@hisilicon.com \
    --cc=dan.j.williams@intel.com \
    --cc=dingtianhong@huawei.com \
    --cc=emilne@redhat.com \
    --cc=guohanjun@huawei.com \
    --cc=hare@suse.com \
    --cc=hch@lst.de \
    --cc=huangdaode@hisilicon.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=john.garry@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=martin.petersen@oracle.com \
    --cc=thenzl@redhat.com \
    --cc=wangkefeng.wang@huawei.com \
    --cc=wefu@redhat.com \
    --cc=yanaijie@huawei.com \
    --cc=zhaohongjiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.