From: Mark yao <mark.yao@rock-chips.com>
To: Arnd Bergmann <arnd@arndb.de>, David Airlie <airlied@linux.ie>,
Heiko Stuebner <heiko@sntech.de>
Cc: Jeffy Chen <jeffy.chen@rock-chips.com>,
linux-rockchip@lists.infradead.org,
Stephen Boyd <stephen.boyd@linaro.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Chris Zhong <zyw@rock-chips.com>,
Guenter Roeck <groeck@chromium.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] [RESEND] drm/rockchip: fix Kconfig dependencies
Date: Mon, 24 Jul 2017 09:58:18 +0800 [thread overview]
Message-ID: <5975543A.80407@rock-chips.com> (raw)
In-Reply-To: <20170721211214.3386387-1-arnd@arndb.de>
On 2017年07月22日 05:12, Arnd Bergmann wrote:
> A bug that I had fixed earlier just came back, with CONFIG_EXTCON=m,
> the rockchip drm driver will fail to link:
>
> drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes':
> cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x30): undefined reference to `extcon_get_state'
> cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x6c): undefined reference to `extcon_get_property'
> drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_check_sink_connection':
> cdn-dp-core.c:(.text.cdn_dp_check_sink_connection+0x80): undefined reference to `extcon_get_state'
> drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_enable':
> cdn-dp-core.c:(.text.cdn_dp_enable+0x748): undefined reference to `extcon_get_property'
>
> The problem is that that the sub-drivers are now all linked into the
> main rockchip drm module, which breaks all the Kconfig dependencies
> that are specified in the options for those sub-drivers.
>
> This clarifies the dependency to ensure that we can only turn on the DP
> driver when EXTCON is reachable. As the 'select' statements can now
> cause additional options to become built-in when they should be
> loadable modules, I'm moving those into the main driver config option.
> The dependency on DRM_ROCKCHIP can be reduced into a single 'if'
> statement here for brevity, but this has no functional effect.
>
> Fixes: b6705157b2db ("drm/rockchip: add extcon dependency for DP")
> Fixes: 8820b68bd378 ("drm/rockchip: Refactor the component match logic.")
> Link:https://patchwork.kernel.org/patch/9648761/
> Acked-by: Guenter Roeck<groeck@chromium.org>
> Tested-by: Jeffy Chen<jeffy.chen@rock-chips.com>
> Signed-off-by: Arnd Bergmann<arnd@arndb.de>
Pushed to drm-misc-fixes.
Thanks.
--
Ｍark Yao
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: mark.yao@rock-chips.com (Mark yao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [RESEND] drm/rockchip: fix Kconfig dependencies
Date: Mon, 24 Jul 2017 09:58:18 +0800 [thread overview]
Message-ID: <5975543A.80407@rock-chips.com> (raw)
In-Reply-To: <20170721211214.3386387-1-arnd@arndb.de>
On 2017?07?22? 05:12, Arnd Bergmann wrote:
> A bug that I had fixed earlier just came back, with CONFIG_EXTCON=m,
> the rockchip drm driver will fail to link:
>
> drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes':
> cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x30): undefined reference to `extcon_get_state'
> cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x6c): undefined reference to `extcon_get_property'
> drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_check_sink_connection':
> cdn-dp-core.c:(.text.cdn_dp_check_sink_connection+0x80): undefined reference to `extcon_get_state'
> drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_enable':
> cdn-dp-core.c:(.text.cdn_dp_enable+0x748): undefined reference to `extcon_get_property'
>
> The problem is that that the sub-drivers are now all linked into the
> main rockchip drm module, which breaks all the Kconfig dependencies
> that are specified in the options for those sub-drivers.
>
> This clarifies the dependency to ensure that we can only turn on the DP
> driver when EXTCON is reachable. As the 'select' statements can now
> cause additional options to become built-in when they should be
> loadable modules, I'm moving those into the main driver config option.
> The dependency on DRM_ROCKCHIP can be reduced into a single 'if'
> statement here for brevity, but this has no functional effect.
>
> Fixes: b6705157b2db ("drm/rockchip: add extcon dependency for DP")
> Fixes: 8820b68bd378 ("drm/rockchip: Refactor the component match logic.")
> Link:https://patchwork.kernel.org/patch/9648761/
> Acked-by: Guenter Roeck<groeck@chromium.org>
> Tested-by: Jeffy Chen<jeffy.chen@rock-chips.com>
> Signed-off-by: Arnd Bergmann<arnd@arndb.de>
Pushed to drm-misc-fixes.
Thanks.
--
?ark Yao
WARNING: multiple messages have this Message-ID (diff)
From: Mark yao <mark.yao@rock-chips.com>
To: Arnd Bergmann <arnd@arndb.de>, David Airlie <airlied@linux.ie>,
Heiko Stuebner <heiko@sntech.de>
Cc: Guenter Roeck <groeck@chromium.org>,
Sean Paul <seanpaul@chromium.org>,
robdclark@gmail.com, Jeffy Chen <jeffy.chen@rock-chips.com>,
Stephen Boyd <stephen.boyd@linaro.org>,
Chris Zhong <zyw@rock-chips.com>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RESEND] drm/rockchip: fix Kconfig dependencies
Date: Mon, 24 Jul 2017 09:58:18 +0800 [thread overview]
Message-ID: <5975543A.80407@rock-chips.com> (raw)
In-Reply-To: <20170721211214.3386387-1-arnd@arndb.de>
On 2017年07月22日 05:12, Arnd Bergmann wrote:
> A bug that I had fixed earlier just came back, with CONFIG_EXTCON=m,
> the rockchip drm driver will fail to link:
>
> drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes':
> cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x30): undefined reference to `extcon_get_state'
> cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x6c): undefined reference to `extcon_get_property'
> drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_check_sink_connection':
> cdn-dp-core.c:(.text.cdn_dp_check_sink_connection+0x80): undefined reference to `extcon_get_state'
> drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_enable':
> cdn-dp-core.c:(.text.cdn_dp_enable+0x748): undefined reference to `extcon_get_property'
>
> The problem is that that the sub-drivers are now all linked into the
> main rockchip drm module, which breaks all the Kconfig dependencies
> that are specified in the options for those sub-drivers.
>
> This clarifies the dependency to ensure that we can only turn on the DP
> driver when EXTCON is reachable. As the 'select' statements can now
> cause additional options to become built-in when they should be
> loadable modules, I'm moving those into the main driver config option.
> The dependency on DRM_ROCKCHIP can be reduced into a single 'if'
> statement here for brevity, but this has no functional effect.
>
> Fixes: b6705157b2db ("drm/rockchip: add extcon dependency for DP")
> Fixes: 8820b68bd378 ("drm/rockchip: Refactor the component match logic.")
> Link:https://patchwork.kernel.org/patch/9648761/
> Acked-by: Guenter Roeck<groeck@chromium.org>
> Tested-by: Jeffy Chen<jeffy.chen@rock-chips.com>
> Signed-off-by: Arnd Bergmann<arnd@arndb.de>
Pushed to drm-misc-fixes.
Thanks.
--
Ｍark Yao
next prev parent reply other threads:[~2017-07-24 1:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 21:12 [PATCH] [RESEND] drm/rockchip: fix Kconfig dependencies Arnd Bergmann
2017-07-21 21:12 ` Arnd Bergmann
2017-07-21 21:12 ` Arnd Bergmann
2017-07-24 1:58 ` Mark yao [this message]
2017-07-24 1:58 ` Mark yao
2017-07-24 1:58 ` Mark yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5975543A.80407@rock-chips.com \
--to=mark.yao@rock-chips.com \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=groeck@chromium.org \
--cc=heiko@sntech.de \
--cc=jeffy.chen@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=stephen.boyd@linaro.org \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.