From: Daniel Borkmann <daniel@iogearbox.net>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Alexei Starovoitov <ast@kernel.org>,
John Fastabend <john.fastabend@gmail.com>
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] bpf: fix a return in sockmap_get_from_fd()
Date: Fri, 18 Aug 2017 08:21:16 +0000 [thread overview]
Message-ID: <5996A37C.2050502@iogearbox.net> (raw)
In-Reply-To: <20170818071210.wyq37kura6wz6bx6@mwanda>
On 08/18/2017 09:27 AM, Dan Carpenter wrote:
> "map" is a valid pointer. We wanted to return "err" instead. Also
> let's return a zero literal at the end.
>
> Fixes: 174a79ff9515 ("bpf: sockmap with sk redirect support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Borkmann <daniel@iogearbox.net>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Alexei Starovoitov <ast@kernel.org>,
John Fastabend <john.fastabend@gmail.com>
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] bpf: fix a return in sockmap_get_from_fd()
Date: Fri, 18 Aug 2017 10:21:16 +0200 [thread overview]
Message-ID: <5996A37C.2050502@iogearbox.net> (raw)
In-Reply-To: <20170818071210.wyq37kura6wz6bx6@mwanda>
On 08/18/2017 09:27 AM, Dan Carpenter wrote:
> "map" is a valid pointer. We wanted to return "err" instead. Also
> let's return a zero literal at the end.
>
> Fixes: 174a79ff9515 ("bpf: sockmap with sk redirect support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
next prev parent reply other threads:[~2017-08-18 8:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 7:27 [PATCH net-next] bpf: fix a return in sockmap_get_from_fd() Dan Carpenter
2017-08-18 7:27 ` Dan Carpenter
2017-08-18 7:40 ` John Fastabend
2017-08-18 7:40 ` John Fastabend
2017-08-18 8:21 ` Daniel Borkmann [this message]
2017-08-18 8:21 ` Daniel Borkmann
2017-08-18 17:18 ` David Miller
2017-08-18 17:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5996A37C.2050502@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=john.fastabend@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.