All of lore.kernel.org
 help / color / mirror / Atom feed
From: james.morse@arm.com (James Morse)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] arm: vdso: Rewrite gettimeofday to more closely match arm64 variant
Date: Wed, 11 Oct 2017 16:34:45 +0100	[thread overview]
Message-ID: <59DE3A15.90800@arm.com> (raw)
In-Reply-To: <20170911161827.112786-1-salyzyn@android.com>

Hi Mark,

On 11/09/17 17:18, Mark Salyzyn wrote:
> Take an effort to recode the arm64 vdso code from assembler to C
> previously submitted by Andrew Pinski <apinski@cavium.com>, rework
> it for use in both arm and arm64, overlapping any optimizations
> for each architecture.
> 
> Side effects include renaming some vdso_datapage.h variables, adding
> a few more to enhance features and functionality to match.

There are quite a lot of different things going on here, all of which are
interleaved in this patch. Could you split them out into smaller simpler changes?

The bits I count are:
* Pulling 32bit specific eabi and fallback macro out into compiler.h,
* Adding support for __vdso_clock_getres,
* Flipping tk_is_cntvct's logic to become use_syscall,
* Variable renames to align 32/64 bit,

...are those 'coarse' versions of the timer calls being added, or just moved around?


Thanks,

James

WARNING: multiple messages have this Message-ID (diff)
From: James Morse <james.morse@arm.com>
To: Mark Salyzyn <salyzyn@android.com>
Cc: linux-kernel@vger.kernel.org, kevin.brodsky@arm.com,
	catalin.marinas@arm.com, will.deacon@arm.com, mingo@kernel.org,
	borntraeger@de.ibm.com, peterz@infradead.org,
	Dave.Martin@arm.com, credmonster@gmail.com, zijun_hu@htc.com,
	mark.rutland@arm.com, jszhang@marvell.com, labbott@redhat.com,
	john.stultz@linaro.org, keescook@chromium.org,
	linux-arm-kernel@lists.infradead.org, takahiro.akashi@linaro.org,
	mmarek@suse.com, ard.biesheuvel@linaro.org,
	Russell King <linux@armlinux.org.uk>,
	Mark Salyzyn <salyzyn@google.com>,
	Andy Lutomirski <luto@amacapital.net>,
	Scott Wood <oss@buserror.net>,
	Dmitry Safonov <dsafonov@virtuozzo.com>
Subject: Re: [PATCH 1/3] arm: vdso: Rewrite gettimeofday to more closely match arm64 variant
Date: Wed, 11 Oct 2017 16:34:45 +0100	[thread overview]
Message-ID: <59DE3A15.90800@arm.com> (raw)
In-Reply-To: <20170911161827.112786-1-salyzyn@android.com>

Hi Mark,

On 11/09/17 17:18, Mark Salyzyn wrote:
> Take an effort to recode the arm64 vdso code from assembler to C
> previously submitted by Andrew Pinski <apinski@cavium.com>, rework
> it for use in both arm and arm64, overlapping any optimizations
> for each architecture.
> 
> Side effects include renaming some vdso_datapage.h variables, adding
> a few more to enhance features and functionality to match.

There are quite a lot of different things going on here, all of which are
interleaved in this patch. Could you split them out into smaller simpler changes?

The bits I count are:
* Pulling 32bit specific eabi and fallback macro out into compiler.h,
* Adding support for __vdso_clock_getres,
* Flipping tk_is_cntvct's logic to become use_syscall,
* Variable renames to align 32/64 bit,

...are those 'coarse' versions of the timer calls being added, or just moved around?


Thanks,

James

  reply	other threads:[~2017-10-11 15:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-11 16:18 [PATCH 1/3] arm: vdso: Rewrite gettimeofday to more closely match arm64 variant Mark Salyzyn
2017-09-11 16:18 ` Mark Salyzyn
2017-10-11 15:34 ` James Morse [this message]
2017-10-11 15:34   ` James Morse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59DE3A15.90800@arm.com \
    --to=james.morse@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.