From: jeffy <jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 1/2] spi: rockchip: Convert to late and early system PM callbacks
Date: Fri, 13 Oct 2017 18:47:18 +0800 [thread overview]
Message-ID: <59E099B6.1000804@rock-chips.com> (raw)
In-Reply-To: <20171013101719.bophbiz7qb5wi7n2-7j8lgAiuQgnQXOPxS62xeg@public.gmane.org>
Hi Mark,
On 10/13/2017 06:17 PM, Mark Brown wrote:
> On Fri, Oct 13, 2017 at 06:01:15PM +0800, Jeffy Chen wrote:
>> Currently we are suspending the spi master in it's ->suspend callback,
>> which is racy as some other drivers may still want to transmit messages
>> on the bus(e.g. spi based pwm backlight).
>
> I'm missing patch 2/2.
>
Sorry, i'll resend them...
This patch is to defer suspend_spi_master to late suspend.
Since we put display-subsystem dt node above spi dt node, which makes
spi suspend been called before display driver. Then the display driver
would fail to set pwm backlight through spi in it's suspend/resume.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: jeffy.chen@rock-chips.com (jeffy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] spi: rockchip: Convert to late and early system PM callbacks
Date: Fri, 13 Oct 2017 18:47:18 +0800 [thread overview]
Message-ID: <59E099B6.1000804@rock-chips.com> (raw)
In-Reply-To: <20171013101719.bophbiz7qb5wi7n2@sirena.co.uk>
Hi Mark,
On 10/13/2017 06:17 PM, Mark Brown wrote:
> On Fri, Oct 13, 2017 at 06:01:15PM +0800, Jeffy Chen wrote:
>> Currently we are suspending the spi master in it's ->suspend callback,
>> which is racy as some other drivers may still want to transmit messages
>> on the bus(e.g. spi based pwm backlight).
>
> I'm missing patch 2/2.
>
Sorry, i'll resend them...
This patch is to defer suspend_spi_master to late suspend.
Since we put display-subsystem dt node above spi dt node, which makes
spi suspend been called before display driver. Then the display driver
would fail to set pwm backlight through spi in it's suspend/resume.
WARNING: multiple messages have this Message-ID (diff)
From: jeffy <jeffy.chen@rock-chips.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, briannorris@chromium.org,
dianders@chromium.org, Heiko Stuebner <heiko@sntech.de>,
linux-spi@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] spi: rockchip: Convert to late and early system PM callbacks
Date: Fri, 13 Oct 2017 18:47:18 +0800 [thread overview]
Message-ID: <59E099B6.1000804@rock-chips.com> (raw)
In-Reply-To: <20171013101719.bophbiz7qb5wi7n2@sirena.co.uk>
Hi Mark,
On 10/13/2017 06:17 PM, Mark Brown wrote:
> On Fri, Oct 13, 2017 at 06:01:15PM +0800, Jeffy Chen wrote:
>> Currently we are suspending the spi master in it's ->suspend callback,
>> which is racy as some other drivers may still want to transmit messages
>> on the bus(e.g. spi based pwm backlight).
>
> I'm missing patch 2/2.
>
Sorry, i'll resend them...
This patch is to defer suspend_spi_master to late suspend.
Since we put display-subsystem dt node above spi dt node, which makes
spi suspend been called before display driver. Then the display driver
would fail to set pwm backlight through spi in it's suspend/resume.
next prev parent reply other threads:[~2017-10-13 10:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 10:01 [PATCH 1/2] spi: rockchip: Convert to late and early system PM callbacks Jeffy Chen
2017-10-13 10:01 ` Jeffy Chen
2017-10-13 10:01 ` Jeffy Chen
2017-10-13 10:01 ` [PATCH 2/2] arm64: dts: rockchip: Enable edp disaplay on kevin Jeffy Chen
2017-10-13 10:01 ` Jeffy Chen
[not found] ` <20171013100116.8271-1-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-10-13 10:17 ` [PATCH 1/2] spi: rockchip: Convert to late and early system PM callbacks Mark Brown
2017-10-13 10:17 ` Mark Brown
2017-10-13 10:17 ` Mark Brown
[not found] ` <20171013101719.bophbiz7qb5wi7n2-7j8lgAiuQgnQXOPxS62xeg@public.gmane.org>
2017-10-13 10:47 ` jeffy [this message]
2017-10-13 10:47 ` jeffy
2017-10-13 10:47 ` jeffy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59E099B6.1000804@rock-chips.com \
--to=jeffy.chen-tnx95d0mmh7dzftrwevzcw@public.gmane.org \
--cc=briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.