* [PATCH] selinux: remove extraneous initialization of slots_used and max_chain_len
@ 2017-10-14 14:52 ` Colin King
0 siblings, 0 replies; 9+ messages in thread
From: Colin King @ 2017-10-14 14:52 UTC (permalink / raw)
To: Paul Moore, Stephen Smalley, Eric Paris, James Morris,
Serge E . Hallyn, Markus Elfring, selinux, linux-security-module
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Variables slots_used and max_chain_len are being initialized to zero
twice. Remove the first set of initializations. Cleans up the
clang warnings:
Value stored to 'slots_used' is never read
Value stored to 'max_chain_len' is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
security/selinux/ss/hashtab.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/security/selinux/ss/hashtab.c b/security/selinux/ss/hashtab.c
index bef7577d1270..622fd50c8b9c 100644
--- a/security/selinux/ss/hashtab.c
+++ b/security/selinux/ss/hashtab.c
@@ -148,8 +148,6 @@ void hashtab_stat(struct hashtab *h, struct hashtab_info *info)
u32 i, chain_len, slots_used, max_chain_len;
struct hashtab_node *cur;
- slots_used = 0;
- max_chain_len = 0;
for (slots_used = max_chain_len = i = 0; i < h->size; i++) {
cur = h->htable[i];
if (cur) {
--
2.14.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] selinux: remove extraneous initialization of slots_used and max_chain_len
@ 2017-10-14 14:52 ` Colin King
0 siblings, 0 replies; 9+ messages in thread
From: Colin King @ 2017-10-14 14:52 UTC (permalink / raw)
To: linux-security-module
From: Colin Ian King <colin.king@canonical.com>
Variables slots_used and max_chain_len are being initialized to zero
twice. Remove the first set of initializations. Cleans up the
clang warnings:
Value stored to 'slots_used' is never read
Value stored to 'max_chain_len' is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
security/selinux/ss/hashtab.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/security/selinux/ss/hashtab.c b/security/selinux/ss/hashtab.c
index bef7577d1270..622fd50c8b9c 100644
--- a/security/selinux/ss/hashtab.c
+++ b/security/selinux/ss/hashtab.c
@@ -148,8 +148,6 @@ void hashtab_stat(struct hashtab *h, struct hashtab_info *info)
u32 i, chain_len, slots_used, max_chain_len;
struct hashtab_node *cur;
- slots_used = 0;
- max_chain_len = 0;
for (slots_used = max_chain_len = i = 0; i < h->size; i++) {
cur = h->htable[i];
if (cur) {
--
2.14.1
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] selinux: remove extraneous initialization of slots_used and max_chain_len
2017-10-14 14:52 ` Colin King
(?)
@ 2017-10-14 15:07 ` walter harms
-1 siblings, 0 replies; 9+ messages in thread
From: walter harms @ 2017-10-14 15:07 UTC (permalink / raw)
To: linux-security-module
Am 14.10.2017 16:52, schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variables slots_used and max_chain_len are being initialized to zero
> twice. Remove the first set of initializations. Cleans up the
> clang warnings:
>
> Value stored to 'slots_used' is never read
> Value stored to 'max_chain_len' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> security/selinux/ss/hashtab.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/security/selinux/ss/hashtab.c b/security/selinux/ss/hashtab.c
> index bef7577d1270..622fd50c8b9c 100644
> --- a/security/selinux/ss/hashtab.c
> +++ b/security/selinux/ss/hashtab.c
> @@ -148,8 +148,6 @@ void hashtab_stat(struct hashtab *h, struct hashtab_info *info)
> u32 i, chain_len, slots_used, max_chain_len;
> struct hashtab_node *cur;
>
> - slots_used = 0;
> - max_chain_len = 0;
> for (slots_used = max_chain_len = i = 0; i < h->size; i++) {
> cur = h->htable[i];
> if (cur) {
personally i would remove it from the for() loop. for(i=0;) is a common pattern
but setting variables this way is at least uncommon and does not improve the
readability of the code. not a good example for security related code.
just my 2 cents,
re,
wh
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] selinux: remove extraneous initialization of slots_used and max_chain_len
@ 2017-10-14 15:07 ` walter harms
0 siblings, 0 replies; 9+ messages in thread
From: walter harms @ 2017-10-14 15:07 UTC (permalink / raw)
To: Colin King
Cc: Paul Moore, Stephen Smalley, Eric Paris, James Morris,
Serge E . Hallyn, Markus Elfring, selinux, linux-security-module,
kernel-janitors, linux-kernel
Am 14.10.2017 16:52, schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variables slots_used and max_chain_len are being initialized to zero
> twice. Remove the first set of initializations. Cleans up the
> clang warnings:
>
> Value stored to 'slots_used' is never read
> Value stored to 'max_chain_len' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> security/selinux/ss/hashtab.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/security/selinux/ss/hashtab.c b/security/selinux/ss/hashtab.c
> index bef7577d1270..622fd50c8b9c 100644
> --- a/security/selinux/ss/hashtab.c
> +++ b/security/selinux/ss/hashtab.c
> @@ -148,8 +148,6 @@ void hashtab_stat(struct hashtab *h, struct hashtab_info *info)
> u32 i, chain_len, slots_used, max_chain_len;
> struct hashtab_node *cur;
>
> - slots_used = 0;
> - max_chain_len = 0;
> for (slots_used = max_chain_len = i = 0; i < h->size; i++) {
> cur = h->htable[i];
> if (cur) {
personally i would remove it from the for() loop. for(i=0;) is a common pattern
but setting variables this way is at least uncommon and does not improve the
readability of the code. not a good example for security related code.
just my 2 cents,
re,
wh
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH] selinux: remove extraneous initialization of slots_used and max_chain_len
@ 2017-10-14 15:07 ` walter harms
0 siblings, 0 replies; 9+ messages in thread
From: walter harms @ 2017-10-14 15:07 UTC (permalink / raw)
To: linux-security-module
Am 14.10.2017 16:52, schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variables slots_used and max_chain_len are being initialized to zero
> twice. Remove the first set of initializations. Cleans up the
> clang warnings:
>
> Value stored to 'slots_used' is never read
> Value stored to 'max_chain_len' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> security/selinux/ss/hashtab.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/security/selinux/ss/hashtab.c b/security/selinux/ss/hashtab.c
> index bef7577d1270..622fd50c8b9c 100644
> --- a/security/selinux/ss/hashtab.c
> +++ b/security/selinux/ss/hashtab.c
> @@ -148,8 +148,6 @@ void hashtab_stat(struct hashtab *h, struct hashtab_info *info)
> u32 i, chain_len, slots_used, max_chain_len;
> struct hashtab_node *cur;
>
> - slots_used = 0;
> - max_chain_len = 0;
> for (slots_used = max_chain_len = i = 0; i < h->size; i++) {
> cur = h->htable[i];
> if (cur) {
personally i would remove it from the for() loop. for(i=0;) is a common pattern
but setting variables this way is at least uncommon and does not improve the
readability of the code. not a good example for security related code.
just my 2 cents,
re,
wh
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] selinux: remove extraneous initialization of slots_used and max_chain_len
2017-10-14 14:52 ` Colin King
(?)
@ 2017-10-14 15:22 ` Joe Perches
-1 siblings, 0 replies; 9+ messages in thread
From: Joe Perches @ 2017-10-14 15:22 UTC (permalink / raw)
To: linux-security-module
On Sat, 2017-10-14 at 15:52 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variables slots_used and max_chain_len are being initialized to zero
> twice. Remove the first set of initializations. Cleans up the
> clang warnings:
>
> Value stored to 'slots_used' is never read
> Value stored to 'max_chain_len' is never read
[]
> diff --git a/security/selinux/ss/hashtab.c b/security/selinux/ss/hashtab.c
[]
> @@ -148,8 +148,6 @@ void hashtab_stat(struct hashtab *h, struct hashtab_info *info)
> u32 i, chain_len, slots_used, max_chain_len;
> struct hashtab_node *cur;
>
> - slots_used = 0;
> - max_chain_len = 0;
> for (slots_used = max_chain_len = i = 0; i < h->size; i++) {
> cur = h->htable[i];
> if (cur) {
I think it'd be nicer if the assignments in the loop
were removed instead.
slots_used = 0;
max_chain_len = 0;
for (i = 0; i < h->size; i++) {
etc...
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] selinux: remove extraneous initialization of slots_used and max_chain_len
@ 2017-10-14 15:22 ` Joe Perches
0 siblings, 0 replies; 9+ messages in thread
From: Joe Perches @ 2017-10-14 15:22 UTC (permalink / raw)
To: Colin King, Paul Moore, Stephen Smalley, Eric Paris, James Morris,
Serge E . Hallyn, Markus Elfring, selinux, linux-security-module
Cc: kernel-janitors, linux-kernel
On Sat, 2017-10-14 at 15:52 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variables slots_used and max_chain_len are being initialized to zero
> twice. Remove the first set of initializations. Cleans up the
> clang warnings:
>
> Value stored to 'slots_used' is never read
> Value stored to 'max_chain_len' is never read
[]
> diff --git a/security/selinux/ss/hashtab.c b/security/selinux/ss/hashtab.c
[]
> @@ -148,8 +148,6 @@ void hashtab_stat(struct hashtab *h, struct hashtab_info *info)
> u32 i, chain_len, slots_used, max_chain_len;
> struct hashtab_node *cur;
>
> - slots_used = 0;
> - max_chain_len = 0;
> for (slots_used = max_chain_len = i = 0; i < h->size; i++) {
> cur = h->htable[i];
> if (cur) {
I think it'd be nicer if the assignments in the loop
were removed instead.
slots_used = 0;
max_chain_len = 0;
for (i = 0; i < h->size; i++) {
etc...
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH] selinux: remove extraneous initialization of slots_used and max_chain_len
@ 2017-10-14 15:22 ` Joe Perches
0 siblings, 0 replies; 9+ messages in thread
From: Joe Perches @ 2017-10-14 15:22 UTC (permalink / raw)
To: linux-security-module
On Sat, 2017-10-14 at 15:52 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variables slots_used and max_chain_len are being initialized to zero
> twice. Remove the first set of initializations. Cleans up the
> clang warnings:
>
> Value stored to 'slots_used' is never read
> Value stored to 'max_chain_len' is never read
[]
> diff --git a/security/selinux/ss/hashtab.c b/security/selinux/ss/hashtab.c
[]
> @@ -148,8 +148,6 @@ void hashtab_stat(struct hashtab *h, struct hashtab_info *info)
> u32 i, chain_len, slots_used, max_chain_len;
> struct hashtab_node *cur;
>
> - slots_used = 0;
> - max_chain_len = 0;
> for (slots_used = max_chain_len = i = 0; i < h->size; i++) {
> cur = h->htable[i];
> if (cur) {
I think it'd be nicer if the assignments in the loop
were removed instead.
slots_used = 0;
max_chain_len = 0;
for (i = 0; i < h->size; i++) {
etc...
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread