From: Frank Rowand <frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
atull-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org,
Pantelis Antoniou
<panto-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] of: overlay: pr_err from return NOTIFY_OK to overlay apply/remove
Date: Thu, 19 Oct 2017 14:49:20 -0700 [thread overview]
Message-ID: <59E91DE0.5090106@gmail.com> (raw)
In-Reply-To: <1508447907-4462-1-git-send-email-frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On 10/19/17 14:18, frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> From: Frank Rowand <frank.rowand-7U/KSKJipcs@public.gmane.org>
>
> A device tree overlay notifier can return NOTIFY_OK, NOTIFY_STOP,
> or an embedded errno. overlay_notify() incorrectly reports an
> error for NOTIFY_OK.
>
> Reported-by: atull-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
> Signed-off-by: Frank Rowand <frank.rowand-7U/KSKJipcs@public.gmane.org>
> ---
> drivers/of/overlay.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
> index c99842bb4b09..f5fce0fea40b 100644
> --- a/drivers/of/overlay.c
> +++ b/drivers/of/overlay.c
> @@ -133,7 +133,7 @@ static int overlay_notify(struct overlay_changeset *ovcs,
>
> ret = blocking_notifier_call_chain(&overlay_notify_chain,
> action, &nd);
> - if (ret == NOTIFY_STOP)
> + if (ret == NOTIFY_OK || ret == NOTIFY_STOP)
> return 0;
> if (ret) {
> ret = notifier_to_errno(ret);
>
Not needed in any stable kernel. This is caused by
"[PATCH v3 00/12] of: overlay: clean up device tree overlay code".
-Frank
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Frank Rowand <frowand.list@gmail.com>
To: Rob Herring <robh+dt@kernel.org>,
atull@kernel.org, pantelis.antoniou@konsulko.com,
Pantelis Antoniou <panto@antoniou-consulting.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of: overlay: pr_err from return NOTIFY_OK to overlay apply/remove
Date: Thu, 19 Oct 2017 14:49:20 -0700 [thread overview]
Message-ID: <59E91DE0.5090106@gmail.com> (raw)
In-Reply-To: <1508447907-4462-1-git-send-email-frowand.list@gmail.com>
On 10/19/17 14:18, frowand.list@gmail.com wrote:
> From: Frank Rowand <frank.rowand@sony.com>
>
> A device tree overlay notifier can return NOTIFY_OK, NOTIFY_STOP,
> or an embedded errno. overlay_notify() incorrectly reports an
> error for NOTIFY_OK.
>
> Reported-by: atull@kernel.org
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---
> drivers/of/overlay.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
> index c99842bb4b09..f5fce0fea40b 100644
> --- a/drivers/of/overlay.c
> +++ b/drivers/of/overlay.c
> @@ -133,7 +133,7 @@ static int overlay_notify(struct overlay_changeset *ovcs,
>
> ret = blocking_notifier_call_chain(&overlay_notify_chain,
> action, &nd);
> - if (ret == NOTIFY_STOP)
> + if (ret == NOTIFY_OK || ret == NOTIFY_STOP)
> return 0;
> if (ret) {
> ret = notifier_to_errno(ret);
>
Not needed in any stable kernel. This is caused by
"[PATCH v3 00/12] of: overlay: clean up device tree overlay code".
-Frank
next prev parent reply other threads:[~2017-10-19 21:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 21:18 [PATCH] of: overlay: pr_err from return NOTIFY_OK to overlay apply/remove frowand.list-Re5JQEeQqe8AvxtiuMwx3w
2017-10-19 21:18 ` frowand.list
[not found] ` <1508447907-4462-1-git-send-email-frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-10-19 21:49 ` Frank Rowand [this message]
2017-10-19 21:49 ` Frank Rowand
2017-10-19 22:13 ` Rob Herring
2017-10-19 22:13 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59E91DE0.5090106@gmail.com \
--to=frowand.list-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=atull-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org \
--cc=panto-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.