From: Chanwoo Choi <cw00.choi@samsung.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
kernel-janitors@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] extcon: max77693: Delete an unnecessary variable initialisation in max77693_muic_set_pat
Date: Thu, 09 Nov 2017 09:16:02 +0000 [thread overview]
Message-ID: <5A041CD2.7090600@samsung.com> (raw)
In-Reply-To: <4fbe6f7c-3ff4-6dbd-2980-8010dcc9548e@users.sourceforge.net>
Hi,
On 2017년 11월 09일 17:49, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 9 Nov 2017 09:40:59 +0100
>
> The variable "ret" will be set to an appropriate value a bit later.
> Thus omit the explicit initialisation at the beginning.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/extcon/extcon-max77693.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c
> index 643411066ad9..227651ff9666 100644
> --- a/drivers/extcon/extcon-max77693.c
> +++ b/drivers/extcon/extcon-max77693.c
> @@ -266,7 +266,7 @@ static int max77693_muic_set_debounce_time(struct max77693_muic_info *info,
> static int max77693_muic_set_path(struct max77693_muic_info *info,
> u8 val, bool attached)
> {
> - int ret = 0;
> + int ret;
> unsigned int ctrl1, ctrl2 = 0;
>
> if (attached)
>
Applied it. But, it will be merged to v4.16-rc1.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
WARNING: multiple messages have this Message-ID (diff)
From: Chanwoo Choi <cw00.choi@samsung.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
kernel-janitors@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] extcon: max77693: Delete an unnecessary variable initialisation in max77693_muic_set_path()
Date: Thu, 09 Nov 2017 18:16:02 +0900 [thread overview]
Message-ID: <5A041CD2.7090600@samsung.com> (raw)
In-Reply-To: <4fbe6f7c-3ff4-6dbd-2980-8010dcc9548e@users.sourceforge.net>
Hi,
On 2017년 11월 09일 17:49, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 9 Nov 2017 09:40:59 +0100
>
> The variable "ret" will be set to an appropriate value a bit later.
> Thus omit the explicit initialisation at the beginning.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/extcon/extcon-max77693.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c
> index 643411066ad9..227651ff9666 100644
> --- a/drivers/extcon/extcon-max77693.c
> +++ b/drivers/extcon/extcon-max77693.c
> @@ -266,7 +266,7 @@ static int max77693_muic_set_debounce_time(struct max77693_muic_info *info,
> static int max77693_muic_set_path(struct max77693_muic_info *info,
> u8 val, bool attached)
> {
> - int ret = 0;
> + int ret;
> unsigned int ctrl1, ctrl2 = 0;
>
> if (attached)
>
Applied it. But, it will be merged to v4.16-rc1.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2017-11-09 9:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171109084920epcas2p1a711136b29d823b7ce7d4bc56be69bb9@epcas2p1.samsung.com>
2017-11-09 8:49 ` [PATCH] extcon: max77693: Delete an unnecessary variable initialisation in max77693_muic_set_path() SF Markus Elfring
2017-11-09 8:49 ` SF Markus Elfring
2017-11-09 9:16 ` Chanwoo Choi [this message]
2017-11-09 9:16 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A041CD2.7090600@samsung.com \
--to=cw00.choi@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.