From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Omar Sandoval <osandov@osandov.com>, Eryu Guan <eguan@redhat.com>,
fstests@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH] generic/473: test return EBUSY from BLKRRPART for mounted whole-dev
Date: Tue, 19 Dec 2017 18:59:12 +0800 [thread overview]
Message-ID: <5A38F100.5090305@cn.fujitsu.com> (raw)
In-Reply-To: <mqd3747at09.fsf@linux-x5ow.site>
On 2017/12/19 18:53, Johannes Thumshirn wrote:
> Xiao Yang<yangx.jy@cn.fujitsu.com> writes:
>> [root@RHEL6U9GA_Intel64 blktests]# make
>> make -C src all
>> make[1]: Entering directory `/root/blktests/src'
>> cc -Wall -o sg/syzkaller1 -O2 sg/syzkaller1.c
>> sg/syzkaller1.c: In function ‘segv_handler’:
>> sg/syzkaller1.c:118: warning: implicit declaration of function
>> ‘__atomic_load_n’
>> sg/syzkaller1.c:118: error: ‘__ATOMIC_RELAXED’ undeclared (first use
>> in this function)
>> sg/syzkaller1.c:118: error: (Each undeclared identifier is reported
>> only once
>> sg/syzkaller1.c:118: error: for each function it appears in.)
>> sg/syzkaller1.c: In function ‘syz_open_dev’:
>> sg/syzkaller1.c:204: warning: implicit declaration of function
>> ‘__atomic_fetch_add’
>> sg/syzkaller1.c:204: error: ‘__ATOMIC_SEQ_CST’ undeclared (first use
>> in this function)
>> sg/syzkaller1.c:204: warning: implicit declaration of function
>> ‘__atomic_fetch_sub’
>> sg/syzkaller1.c: In function ‘test’:
>> sg/syzkaller1.c:406: error: ‘__ATOMIC_SEQ_CST’ undeclared (first use
>> in this function)
>> make[1]: *** [sg/syzkaller1] Error 1
>> make[1]: Leaving directory `/root/blktests/src'
>> make: *** [all] Error 2
>> -----------------------------------------------------------------------------------------------------------------------
>>
>> It seems that __atomic_* functions are not available, and could you
>> tell me how to fix
>> the compiler error?
> It seems like gcc 4.4 is too old to handle __ATOMIC_*. The oldest
> version of gcc I tried was 4.8 which could handle this code perfectly
> fine.
>
> I think we need hacks in the makefile to see which compiler version we
> have and conditionally compile the code.
Hi Johannes,
Thanks for your quick reply. i will try to fix it as you suggested.
Thanks,
Xiao Yang
> Byte,
> Johannes
>
WARNING: multiple messages have this Message-ID (diff)
From: Xiao Yang <yangx.jy@cn.fujitsu.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Omar Sandoval <osandov@osandov.com>, Eryu Guan <eguan@redhat.com>,
<fstests@vger.kernel.org>, <linux-block@vger.kernel.org>
Subject: Re: [PATCH] generic/473: test return EBUSY from BLKRRPART for mounted whole-dev
Date: Tue, 19 Dec 2017 18:59:12 +0800 [thread overview]
Message-ID: <5A38F100.5090305@cn.fujitsu.com> (raw)
In-Reply-To: <mqd3747at09.fsf@linux-x5ow.site>
On 2017/12/19 18:53, Johannes Thumshirn wrote:
> Xiao Yang<yangx.jy@cn.fujitsu.com> writes:
>> [root@RHEL6U9GA_Intel64 blktests]# make
>> make -C src all
>> make[1]: Entering directory `/root/blktests/src'
>> cc -Wall -o sg/syzkaller1 -O2 sg/syzkaller1.c
>> sg/syzkaller1.c: In function ‘segv_handler’:
>> sg/syzkaller1.c:118: warning: implicit declaration of function
>> ‘__atomic_load_n’
>> sg/syzkaller1.c:118: error: ‘__ATOMIC_RELAXED’ undeclared (first use
>> in this function)
>> sg/syzkaller1.c:118: error: (Each undeclared identifier is reported
>> only once
>> sg/syzkaller1.c:118: error: for each function it appears in.)
>> sg/syzkaller1.c: In function ‘syz_open_dev’:
>> sg/syzkaller1.c:204: warning: implicit declaration of function
>> ‘__atomic_fetch_add’
>> sg/syzkaller1.c:204: error: ‘__ATOMIC_SEQ_CST’ undeclared (first use
>> in this function)
>> sg/syzkaller1.c:204: warning: implicit declaration of function
>> ‘__atomic_fetch_sub’
>> sg/syzkaller1.c: In function ‘test’:
>> sg/syzkaller1.c:406: error: ‘__ATOMIC_SEQ_CST’ undeclared (first use
>> in this function)
>> make[1]: *** [sg/syzkaller1] Error 1
>> make[1]: Leaving directory `/root/blktests/src'
>> make: *** [all] Error 2
>> -----------------------------------------------------------------------------------------------------------------------
>>
>> It seems that __atomic_* functions are not available, and could you
>> tell me how to fix
>> the compiler error?
> It seems like gcc 4.4 is too old to handle __ATOMIC_*. The oldest
> version of gcc I tried was 4.8 which could handle this code perfectly
> fine.
>
> I think we need hacks in the makefile to see which compiler version we
> have and conditionally compile the code.
Hi Johannes,
Thanks for your quick reply. i will try to fix it as you suggested.
Thanks,
Xiao Yang
> Byte,
> Johannes
>
next prev parent reply other threads:[~2017-12-19 10:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 12:02 [PATCH] generic/473: test return EBUSY from BLKRRPART for mounted whole-dev Xiao Yang
2017-12-04 8:29 ` Eryu Guan
2017-12-04 9:15 ` Xiao Yang
2017-12-04 9:15 ` Xiao Yang
2017-12-04 9:25 ` Eryu Guan
2017-12-04 9:48 ` Xiao Yang
2017-12-04 9:48 ` Xiao Yang
2017-12-04 18:29 ` Omar Sandoval
2017-12-19 10:30 ` [PATCH blktests] block/013: Add test for BLKRRPART ioctl xiao yang
2017-12-19 10:30 ` xiao yang
2017-12-19 10:47 ` Johannes Thumshirn
2017-12-19 10:47 ` Johannes Thumshirn
2017-12-19 19:42 ` Omar Sandoval
2017-12-20 8:03 ` Johannes Thumshirn
2017-12-19 23:42 ` Omar Sandoval
2017-12-19 10:45 ` [PATCH] generic/473: test return EBUSY from BLKRRPART for mounted whole-dev Xiao Yang
2017-12-19 10:45 ` Xiao Yang
2017-12-19 10:53 ` Johannes Thumshirn
2017-12-19 10:53 ` Johannes Thumshirn
2017-12-19 10:59 ` Xiao Yang [this message]
2017-12-19 10:59 ` Xiao Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A38F100.5090305@cn.fujitsu.com \
--to=yangx.jy@cn.fujitsu.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.